Newly introduced findings

List of Findings

Error: GCC_ANALYZER_WARNING (CWE-775): [#def1]
xfsprogs-7.0.1/healer/xfs_healer_start.c:307:13: warning[-Wanalyzer-fd-leak]: leak of file descriptor ‘open(<unknown>, 0)’
xfsprogs-7.0.1/healer/xfs_healer_start.c:256:23: branch_true: following ‘true’ branch...
xfsprogs-7.0.1/healer/xfs_healer_start.c:256:23: branch_true: ...to here
xfsprogs-7.0.1/healer/xfs_healer_start.c:295:21: branch_false: following ‘false’ branch (when ‘mntns’ is NULL)...
xfsprogs-7.0.1/healer/xfs_healer_start.c:295:21: branch_false: ...to here
xfsprogs-7.0.1/healer/xfs_healer_start.c:295:21: acquire_resource: opened here
xfsprogs-7.0.1/healer/xfs_healer_start.c:296:12: branch_false: following ‘false’ branch...
xfsprogs-7.0.1/healer/xfs_healer_start.c:307:13: branch_false: ...to here
xfsprogs-7.0.1/healer/xfs_healer_start.c:307:12: branch_false: following ‘false’ branch...
xfsprogs-7.0.1/healer/xfs_healer_start.c:321:18: branch_false: ...to here
xfsprogs-7.0.1/healer/xfs_healer_start.c:307:13: danger: ‘open(<unknown>, 0)’ leaks here; was opened at [(5)](sarif:/runs/0/results/0/codeFlows/0/threadFlows/0/locations/4)
#  305|   		goto out;
#  306|   	}
#  307|-> 	if (mnt_ns_fd == DEFAULT_MOUNTNS_FD && mntns != NULL) {
#  308|   		/*
#  309|   		 * We specified a path to a mount namespace file but got fd 0,

Error: GCC_ANALYZER_WARNING (CWE-775): [#def2]
xfsprogs-7.0.1/io/listmount.c:275:1: warning[-Wanalyzer-fd-leak]: leak of file descriptor ‘mnt_ns_fd’
xfsprogs-7.0.1/io/listmount.c:197:16: branch_true: following ‘true’ branch (when ‘c > 0’)...
xfsprogs-7.0.1/io/listmount.c:198:17: branch_true: ...to here
xfsprogs-7.0.1/io/listmount.c:216:37: acquire_resource: opened here
xfsprogs-7.0.1/io/listmount.c:217:28: branch_false: following ‘false’ branch...
xfsprogs-7.0.1/io/listmount.c:217:28: branch_false: ...to here
xfsprogs-7.0.1/io/listmount.c:235:12: branch_true: following ‘true’ branch (when ‘smbuf’ is NULL)...
xfsprogs-7.0.1/io/listmount.c:236:17: branch_true: ...to here
xfsprogs-7.0.1/io/listmount.c:275:1: danger: ‘mnt_ns_fd’ leaks here; was opened at [(3)](sarif:/runs/0/results/0/codeFlows/0/threadFlows/0/locations/2)
#  273|   		close(mnt_ns_fd);
#  274|   	return 0;
#  275|-> }
#  276|   
#  277|   static const struct cmdinfo listmount_cmd = {

Error: GCC_ANALYZER_WARNING (CWE-775): [#def3]
xfsprogs-7.0.1/libfrog/systemd.c:55:24: warning[-Wanalyzer-fd-leak]: leak of file descriptor 'pipe_fds[0]'
xfsprogs-7.0.1/libfrog/systemd.c:54:12: branch_false: following 'false' branch (when 'ret == 0')...
xfsprogs-7.0.1/libfrog/systemd.c:57:21: branch_false: ...to here
xfsprogs-7.0.1/libfrog/systemd.c:58:12: branch_true: following 'true' branch (when 'child_pid < 0')...
xfsprogs-7.0.1/libfrog/systemd.c:55:24: branch_true: ...to here
xfsprogs-7.0.1/libfrog/systemd.c:55:24: danger: 'pipe_fds[0]' leaks here
#   53|   	ret = pipe(pipe_fds);
#   54|   	if (ret)
#   55|-> 		return -1;
#   56|   
#   57|   	child_pid = fork();

Error: GCC_ANALYZER_WARNING (CWE-775): [#def4]
xfsprogs-7.0.1/libfrog/systemd.c:55:24: warning[-Wanalyzer-fd-leak]: leak of file descriptor 'pipe_fds[1]'
xfsprogs-7.0.1/libfrog/systemd.c:54:12: branch_false: following 'false' branch (when 'ret == 0')...
xfsprogs-7.0.1/libfrog/systemd.c:57:21: branch_false: ...to here
xfsprogs-7.0.1/libfrog/systemd.c:58:12: branch_true: following 'true' branch (when 'child_pid < 0')...
xfsprogs-7.0.1/libfrog/systemd.c:55:24: branch_true: ...to here
xfsprogs-7.0.1/libfrog/systemd.c:55:24: danger: 'pipe_fds[1]' leaks here
#   53|   	ret = pipe(pipe_fds);
#   54|   	if (ret)
#   55|-> 		return -1;
#   56|   
#   57|   	child_pid = fork();

Error: GCC_ANALYZER_WARNING (CWE-476): [#def5]
xfsprogs-7.0.1/libxfs/xfs_da_btree.c:2758:17: warning[-Wanalyzer-null-dereference]: dereference of NULL '0'
xfsprogs-7.0.1/libxfs/xfs_da_btree.c:2716:1: enter_function: entry to 'xfs_dabuf_map'
xfsprogs-7.0.1/libxfs/xfs_da_btree.c:2738:12: branch_false: following 'false' branch...
xfsprogs-7.0.1/libxfs/xfs_da_btree.c:2745:13: branch_false: ...to here
xfsprogs-7.0.1/libxfs/xfs_da_btree.c:2745:12: branch_true: following 'true' branch...
xfsprogs-7.0.1/libxfs/xfs_da_btree.c:2746:23: branch_true: ...to here
xfsprogs-7.0.1/libxfs/xfs_da_btree.c:2746:23: call_function: inlined call to 'kmalloc_array' from 'xfs_dabuf_map'
xfsprogs-7.0.1/libxfs/xfs_da_btree.c:2748:17: branch_true: ...to here
xfsprogs-7.0.1/libxfs/xfs_da_btree.c:2751:21: branch_true: following 'true' branch...
xfsprogs-7.0.1/libxfs/xfs_da_btree.c:2752:26: branch_true: ...to here
xfsprogs-7.0.1/libxfs/xfs_da_btree.c:2752:20: branch_false: following 'false' branch...
xfsprogs-7.0.1/libxfs/xfs_da_btree.c:2755:28: branch_false: ...to here
xfsprogs-7.0.1/libxfs/xfs_da_btree.c:2755:20: branch_false: following 'false' branch...
xfsprogs-7.0.1/libxfs/xfs_da_btree.c:2758:32: branch_false: ...to here
xfsprogs-7.0.1/libxfs/xfs_da_btree.c:2758:17: danger: dereference of NULL 'map + (long unsigned int)i * 16'
# 2756|   			goto invalid_mapping;
# 2757|   
# 2758|-> 		map[i].bm_bn = XFS_FSB_TO_DADDR(mp, irecs[i].br_startblock);
# 2759|   		map[i].bm_len = XFS_FSB_TO_BB(mp, irecs[i].br_blockcount);
# 2760|   		off += irecs[i].br_blockcount;

Scan Properties