Fixed findings

List of Findings

Error: SHELLCHECK_WARNING (CWE-457): [#def1]
/usr/lib/dracut/modules.d/99unbound/module-setup.sh:20:18: warning[SC2154]: moddir is referenced but not assigned.
#   18|       # there is a synchronization point when other services are able
#   19|       # to make queries
#   20|->     inst_simple "$moddir"/unbound-initrd.conf /etc/systemd/system/unbound.service.d/unbound-initrd.conf
#   21|   
#   22|       # /etc and /var/lib do not have its variables

Error: SHELLCHECK_WARNING (CWE-457): [#def2]
/usr/lib/dracut/modules.d/99unbound/module-setup.sh:43:27: warning[SC2154]: initdir is referenced but not assigned.
#   41|       unbound-control
#   42|   
#   43|->     $SYSTEMCTL -q --root "$initdir" enable unbound.service
#   44|   }

Error: GCC_ANALYZER_WARNING (CWE-775): [#def3]
unbound-1.24.2/pythonmod/pythonmod.c:137:20: warning[-Wanalyzer-file-leak]: leak of FILE 'fopen(*pe.fname, "r")'
unbound-1.24.2/pythonmod/pythonmod.c:294:5: enter_function: entry to 'pythonmod_init'
unbound-1.24.2/pythonmod/pythonmod.c:309:7: branch_false: following 'false' branch (when 'pe' is non-NULL)...
unbound-1.24.2/pythonmod/pythonmod.c:315:4: branch_false: ...to here
unbound-1.24.2/pythonmod/pythonmod.c:319:11: branch_true: following 'true' branch (when 'cfg_item' is non-NULL)...
unbound-1.24.2/pythonmod/pythonmod.c:320:23: branch_true: ...to here
unbound-1.24.2/pythonmod/pythonmod.c:326:6: branch_false: following 'false' branch...
unbound-1.24.2/pythonmod/pythonmod.c:436:16: acquire_resource: opened here
unbound-1.24.2/pythonmod/pythonmod.c:438:7: branch_false: following 'false' branch...
unbound-1.24.2/pythonmod/pythonmod.c:445:17: branch_false: ...to here
unbound-1.24.2/pythonmod/pythonmod.c:449:4: call_function: calling 'clean_python_function_objects' from 'pythonmod_init'
unbound-1.24.2/pythonmod/pythonmod.c:449:4: return_function: returning to 'pythonmod_init' from 'clean_python_function_objects'
unbound-1.24.2/pythonmod/pythonmod.c:137:20: danger: 'fopen(*pe.fname, "r")' leaks here; was opened at [(8)](sarif:/runs/0/results/0/codeFlows/0/threadFlows/0/locations/7)
#  135|   
#  136|   	for(i=0; i<sizeof(function_names)/sizeof(function_names[0]); i++) {
#  137|-> 		if(PyDict_GetItemString(dict, function_names[i]) != NULL) {
#  138|   			PyDict_DelItemString(dict, function_names[i]);
#  139|   		}

Error: GCC_ANALYZER_WARNING (CWE-401): [#def4]
unbound-1.24.2/pythonmod/pythonmod.c:137:20: warning[-Wanalyzer-malloc-leak]: leak of 'fopen(*pe.fname, "r")'
unbound-1.24.2/pythonmod/pythonmod.c:294:5: enter_function: entry to 'pythonmod_init'
unbound-1.24.2/pythonmod/pythonmod.c:309:7: branch_false: following 'false' branch (when 'pe' is non-NULL)...
unbound-1.24.2/pythonmod/pythonmod.c:315:4: branch_false: ...to here
unbound-1.24.2/pythonmod/pythonmod.c:319:11: branch_true: following 'true' branch (when 'cfg_item' is non-NULL)...
unbound-1.24.2/pythonmod/pythonmod.c:320:23: branch_true: ...to here
unbound-1.24.2/pythonmod/pythonmod.c:326:6: branch_false: following 'false' branch...
unbound-1.24.2/pythonmod/pythonmod.c:436:16: acquire_memory: allocated here
unbound-1.24.2/pythonmod/pythonmod.c:438:7: branch_false: following 'false' branch...
unbound-1.24.2/pythonmod/pythonmod.c:445:17: branch_false: ...to here
unbound-1.24.2/pythonmod/pythonmod.c:449:4: call_function: calling 'clean_python_function_objects' from 'pythonmod_init'
unbound-1.24.2/pythonmod/pythonmod.c:449:4: return_function: returning to 'pythonmod_init' from 'clean_python_function_objects'
unbound-1.24.2/pythonmod/pythonmod.c:137:20: danger: 'fopen(*pe.fname, "r")' leaks here; was allocated at [(8)](sarif:/runs/0/results/1/codeFlows/0/threadFlows/0/locations/7)
#  135|   
#  136|   	for(i=0; i<sizeof(function_names)/sizeof(function_names[0]); i++) {
#  137|-> 		if(PyDict_GetItemString(dict, function_names[i]) != NULL) {
#  138|   			PyDict_DelItemString(dict, function_names[i]);
#  139|   		}

Scan Properties

analyzer-version-clippy1.95.0
analyzer-version-cppcheck2.20.0
analyzer-version-gcc16.1.1
analyzer-version-gcc-analyzer16.1.1
analyzer-version-shellcheck0.11.0
analyzer-version-unicontrol0.0.2
diffbase-analyzer-version-clippy1.95.0
diffbase-analyzer-version-cppcheck2.20.0
diffbase-analyzer-version-gcc16.1.1
diffbase-analyzer-version-gcc-analyzer16.1.1
diffbase-analyzer-version-shellcheck0.11.0
diffbase-analyzer-version-unicontrol0.0.2
diffbase-enabled-pluginsclippy, cppcheck, gcc, shellcheck, unicontrol
diffbase-exit-code0
diffbase-hostip-172-16-1-243.us-west-2.compute.internal
diffbase-known-false-positives/usr/share/csmock/known-false-positives.js
diffbase-known-false-positives-rpmknown-false-positives-0.0.0.20260524.213755.g3c6d0be.main-1.el9.noarch
diffbase-mock-configfedora-rawhide-x86_64
diffbase-project-nameunbound-1.25.1-1.fc45
diffbase-store-results-to/tmp/tmpy14bgcz3/unbound-1.25.1-1.fc45.tar.xz
diffbase-time-created2026-06-01 17:08:03
diffbase-time-finished2026-06-01 17:11:01
diffbase-toolcsmock
diffbase-tool-args'/usr/bin/csmock' '-r' 'fedora-rawhide-x86_64' '-t' 'shellcheck,cppcheck,clippy,unicontrol,gcc' '-o' '/tmp/tmpy14bgcz3/unbound-1.25.1-1.fc45.tar.xz' '--gcc-analyze' '--unicontrol-notests' '--unicontrol-bidi-only' '--install' 'pam' '--gcc-analyzer-bin=/usr/bin/gcc' '/tmp/tmpy14bgcz3/unbound-1.25.1-1.fc45.src.rpm'
diffbase-tool-versioncsmock-3.8.5.20260529.133039.g6f3b5c6-1.el9
enabled-pluginsclippy, cppcheck, gcc, shellcheck, unicontrol
exit-code0
hostip-172-16-1-243.us-west-2.compute.internal
known-false-positives/usr/share/csmock/known-false-positives.js
known-false-positives-rpmknown-false-positives-0.0.0.20260524.213755.g3c6d0be.main-1.el9.noarch
mock-configfedora-rawhide-x86_64
project-nameunbound-1.24.2-10.fc44
store-results-to/tmp/tmpfvo04lck/unbound-1.24.2-10.fc44.tar.xz
time-created2026-06-01 17:04:16
time-finished2026-06-01 17:07:44
titleFixed findings
toolcsmock
tool-args'/usr/bin/csmock' '-r' 'fedora-rawhide-x86_64' '-t' 'shellcheck,cppcheck,clippy,unicontrol,gcc' '-o' '/tmp/tmpfvo04lck/unbound-1.24.2-10.fc44.tar.xz' '--gcc-analyze' '--unicontrol-notests' '--unicontrol-bidi-only' '--install' 'pam' '--gcc-analyzer-bin=/usr/bin/gcc' '/tmp/tmpfvo04lck/unbound-1.24.2-10.fc44.src.rpm'
tool-versioncsmock-3.8.5.20260529.133039.g6f3b5c6-1.el9