Task #119495 - added.err
back to task #119495download
Error: SHELLCHECK_WARNING (CWE-563): /usr/share/tomcat/bin/catalina.sh:121:10: warning[SC2034]: darwin appears unused. Verify use (or export if used externally). # 119| case "`uname`" in # 120| CYGWIN*) cygwin=true;; # 121|-> Darwin*) darwin=true;; # 122| OS400*) os400=true;; # 123| HP-UX*) hpux=true;; Error: SHELLCHECK_WARNING (CWE-252): /usr/share/tomcat/bin/catalina.sh:143:43: warning[SC2164]: Use 'cd ... || exit' or 'cd ... || return' in case cd fails. # 141| # 142| # Only set CATALINA_HOME if not already set # 143|-> [ -z "$CATALINA_HOME" ] && CATALINA_HOME=`cd "$PRGDIR/.." >/dev/null; pwd` # 144| # 145| # Copy CATALINA_BASE from CATALINA_HOME if not already set Error: SHELLCHECK_WARNING: /usr/share/tomcat/bin/catalina.sh:363:48: warning[SC2294]: eval negates the benefit of arrays. Drop eval to preserve whitespace/symbols (or eval as string). # 361| -Dcatalina.home="$CATALINA_HOME" \ # 362| -Djava.io.tmpdir="$CATALINA_TMPDIR" \ # 363|-> org.apache.catalina.startup.Bootstrap "$@" start # 364| else # 365| eval exec "\"$_RUNJDB\"" "\"$CATALINA_LOGGING_CONFIG\"" $LOGGING_MANAGER "$JAVA_OPTS" "$CATALINA_OPTS" \ Error: SHELLCHECK_WARNING: /usr/share/tomcat/bin/catalina.sh:371:48: warning[SC2294]: eval negates the benefit of arrays. Drop eval to preserve whitespace/symbols (or eval as string). # 369| -Dcatalina.home="$CATALINA_HOME" \ # 370| -Djava.io.tmpdir="$CATALINA_TMPDIR" \ # 371|-> org.apache.catalina.startup.Bootstrap "$@" start # 372| fi # 373| fi Error: SHELLCHECK_WARNING: /usr/share/tomcat/bin/catalina.sh:390:46: warning[SC2294]: eval negates the benefit of arrays. Drop eval to preserve whitespace/symbols (or eval as string). # 388| -Dcatalina.home="\"$CATALINA_HOME\"" \ # 389| -Djava.io.tmpdir="\"$CATALINA_TMPDIR\"" \ # 390|-> org.apache.catalina.startup.Bootstrap "$@" start # 391| else # 392| eval exec "\"$_RUNJAVA\"" "\"$CATALINA_LOGGING_CONFIG\"" $LOGGING_MANAGER "$JAVA_OPTS" "$CATALINA_OPTS" \ Error: SHELLCHECK_WARNING: /usr/share/tomcat/bin/catalina.sh:397:46: warning[SC2294]: eval negates the benefit of arrays. Drop eval to preserve whitespace/symbols (or eval as string). # 395| -Dcatalina.home="\"$CATALINA_HOME\"" \ # 396| -Djava.io.tmpdir="\"$CATALINA_TMPDIR\"" \ # 397|-> org.apache.catalina.startup.Bootstrap "$@" start # 398| fi # 399| Error: SHELLCHECK_WARNING: /usr/share/tomcat/bin/catalina.sh:469:46: warning[SC2294]: eval negates the benefit of arrays. Drop eval to preserve whitespace/symbols (or eval as string). # 467| -Dcatalina.home="\"$CATALINA_HOME\"" \ # 468| -Djava.io.tmpdir="\"$CATALINA_TMPDIR\"" \ # 469|-> org.apache.catalina.startup.Bootstrap "$@" start \ # 470| >> "$CATALINA_OUT" 2>&1 "&" # 471| Error: SHELLCHECK_WARNING: /usr/share/tomcat/bin/catalina.sh:478:46: warning[SC2294]: eval negates the benefit of arrays. Drop eval to preserve whitespace/symbols (or eval as string). # 476| -Dcatalina.home="\"$CATALINA_HOME\"" \ # 477| -Djava.io.tmpdir="\"$CATALINA_TMPDIR\"" \ # 478|-> org.apache.catalina.startup.Bootstrap "$@" start \ # 479| >> "$CATALINA_OUT" 2>&1 "&" # 480| Error: SHELLCHECK_WARNING (CWE-156): /usr/share/tomcat/bin/catalina.sh:511:17: warning[SC2046]: Quote this to prevent word splitting. # 509| if [ -f "$CATALINA_PID" ]; then # 510| if [ -s "$CATALINA_PID" ]; then # 511|-> kill -0 `cat "$CATALINA_PID"` >/dev/null 2>&1 # 512| if [ $? -gt 0 ]; then # 513| echo "PID file found but either no matching process was found or the current user does not have permission to stop the process. Stop aborted." Error: SHELLCHECK_WARNING: /usr/share/tomcat/bin/catalina.sh:530:44: warning[SC2294]: eval negates the benefit of arrays. Drop eval to preserve whitespace/symbols (or eval as string). # 528| -Dcatalina.home="\"$CATALINA_HOME\"" \ # 529| -Djava.io.tmpdir="\"$CATALINA_TMPDIR\"" \ # 530|-> org.apache.catalina.startup.Bootstrap "$@" stop # 531| # 532| # stop failed. Shutdown port disabled? Try a normal kill. Error: SHELLCHECK_WARNING (CWE-156): /usr/share/tomcat/bin/catalina.sh:536:16: warning[SC2046]: Quote this to prevent word splitting. # 534| if [ ! -z "$CATALINA_PID" ]; then # 535| echo "The stop command failed. Attempting to signal the process to stop through OS signal." # 536|-> kill -15 `cat "$CATALINA_PID"` >/dev/null 2>&1 # 537| fi # 538| fi Error: SHELLCHECK_WARNING (CWE-156): /usr/share/tomcat/bin/catalina.sh:543:17: warning[SC2046]: Quote this to prevent word splitting. # 541| if [ -f "$CATALINA_PID" ]; then # 542| while [ $SLEEP -ge 0 ]; do # 543|-> kill -0 `cat "$CATALINA_PID"` >/dev/null 2>&1 # 544| if [ $? -gt 0 ]; then # 545| rm -f "$CATALINA_PID" >/dev/null 2>&1 Error: SHELLCHECK_WARNING (CWE-156): /usr/share/tomcat/bin/catalina.sh:567:19: warning[SC2046]: Quote this to prevent word splitting. # 565| fi # 566| echo "To aid diagnostics a thread dump has been written to standard out." # 567|-> kill -3 `cat "$CATALINA_PID"` # 568| fi # 569| SLEEP=`expr $SLEEP - 1 ` Error: SHELLCHECK_WARNING (CWE-156): /usr/share/tomcat/bin/catalina.sh:584:21: warning[SC2046]: Quote this to prevent word splitting. # 582| kill -9 $PID # 583| while [ $KILL_SLEEP_INTERVAL -ge 0 ]; do # 584|-> kill -0 `cat "$CATALINA_PID"` >/dev/null 2>&1 # 585| if [ $? -gt 0 ]; then # 586| rm -f "$CATALINA_PID" >/dev/null 2>&1 Error: SHELLCHECK_WARNING (CWE-252): /usr/share/tomcat/bin/makebase.sh:45:43: warning[SC2164]: Use 'cd ... || exit' or 'cd ... || return' in case cd fails. # 43| # 44| # Only set CATALINA_HOME if not already set # 45|-> [ -z "$CATALINA_HOME" ] && CATALINA_HOME=`cd "$PRGDIR/.." >/dev/null; pwd` # 46| # 47| # first arg is the target directory Error: SHELLCHECK_WARNING (CWE-457): /usr/share/tomcat/bin/setclasspath.sh:25:6: warning[SC2154]: darwin is referenced but not assigned. # 23| # Make sure prerequisite environment variables are set # 24| if [ -z "$JAVA_HOME" ] && [ -z "$JRE_HOME" ]; then # 25|-> if $darwin; then # 26| # Bugzilla 54390 # 27| if [ -x '/usr/libexec/java_home' ] ; then Error: SHELLCHECK_WARNING (CWE-571): /usr/share/tomcat/bin/setclasspath.sh:28:14: warning[SC2155]: Declare and assign separately to avoid masking return values. # 26| # Bugzilla 54390 # 27| if [ -x '/usr/libexec/java_home' ] ; then # 28|-> export JAVA_HOME=`/usr/libexec/java_home` # 29| # Bugzilla 37284 (reviewed). # 30| elif [ -d "/System/Library/Frameworks/JavaVM.framework/Versions/CurrentJDK/Home" ]; then Error: SHELLCHECK_WARNING (CWE-156): /usr/share/tomcat/bin/setclasspath.sh:28:24: warning[SC2046]: Quote this to prevent word splitting. # 26| # Bugzilla 54390 # 27| if [ -x '/usr/libexec/java_home' ] ; then # 28|-> export JAVA_HOME=`/usr/libexec/java_home` # 29| # Bugzilla 37284 (reviewed). # 30| elif [ -d "/System/Library/Frameworks/JavaVM.framework/Versions/CurrentJDK/Home" ]; then Error: SHELLCHECK_WARNING (CWE-457): /usr/share/tomcat/bin/setclasspath.sh:59:9: warning[SC2154]: os400 is referenced but not assigned. # 57| # If we're running under jdb, we need a full jdk. # 58| if [ "$1" = "debug" ] ; then # 59|-> if [ "$os400" = "true" ]; then # 60| if [ ! -x "$JAVA_HOME"/bin/java ] || [ ! -x "$JAVA_HOME"/bin/javac ]; then # 61| echo "The JAVA_HOME environment variable is not defined correctly" Error: SHELLCHECK_WARNING (CWE-563): /usr/share/tomcat/bin/tool-wrapper.sh:43:10: warning[SC2034]: darwin appears unused. Verify use (or export if used externally). # 41| case "`uname`" in # 42| CYGWIN*) cygwin=true;; # 43|-> Darwin*) darwin=true;; # 44| OS400*) os400=true;; # 45| esac Error: SHELLCHECK_WARNING (CWE-252): /usr/share/tomcat/bin/tool-wrapper.sh:64:43: warning[SC2164]: Use 'cd ... || exit' or 'cd ... || return' in case cd fails. # 62| # 63| # Only set CATALINA_HOME if not already set # 64|-> [ -z "$CATALINA_HOME" ] && CATALINA_HOME=`cd "$PRGDIR/.." >/dev/null; pwd` # 65| # 66| # Ensure that any user defined CLASSPATH variables are not used on startup, Error: SHELLCHECK_WARNING: /usr/share/tomcat/bin/tool-wrapper.sh:132:37: warning[SC2294]: eval negates the benefit of arrays. Drop eval to preserve whitespace/symbols (or eval as string). # 130| -classpath "\"$CLASSPATH\"" \ # 131| -Dcatalina.home="\"$CATALINA_HOME\"" \ # 132|-> org.apache.catalina.startup.Tool "$@"