Fixed findings

List of Findings

Error: COMPILER_WARNING (CWE-134): [#def1]
rtkit-0.11/rtkit-daemon.c: scope_hint: In function ‘dbus_handler’
rtkit-0.11/rtkit-daemon.c:1336:25: warning[-Wformat-security]: format not a string literal and no format arguments
# 1336 |                         assert_se(r = dbus_message_new_error_printf(m, translate_error_forward(ret), strerror(-ret)));
#      |                         ^~~~~~~~~
# 1334|   
# 1335|                   if ((ret = verify_canary_refusal()) < 0) {
# 1336|->                         assert_se(r = dbus_message_new_error_printf(m, translate_error_forward(ret), strerror(-ret)));
# 1337|                           goto finish;
# 1338|                   }

Error: COMPILER_WARNING (CWE-134): [#def2]
rtkit-0.11/rtkit-daemon.c:1361:25: warning[-Wformat-security]: format not a string literal and no format arguments
# 1361 |                         assert_se(r = dbus_message_new_error_printf(m, translate_error_forward(ret), strerror(-ret)));
#      |                         ^~~~~~~~~
# 1359|                   if ((ret = lookup_client(&u, &p, &t, c, m, (pid_t)process, (pid_t) thread)) < 0) {
# 1360|                           syslog(LOG_DEBUG, "Failed to look up client: %s\n", strerror(-ret));
# 1361|->                         assert_se(r = dbus_message_new_error_printf(m, translate_error_forward(ret), strerror(-ret)));
# 1362|                           goto finish;
# 1363|                   }

Error: GCC_ANALYZER_WARNING (CWE-457): [#def3]
rtkit-0.11/rtkit-daemon.c:1365:28: warning[-Wanalyzer-use-of-uninitialized-value]: use of uninitialized value ‘p’
rtkit-0.11/rtkit-daemon.c:1316:26: enter_function: entry to ‘dbus_handler’
rtkit-0.11/rtkit-daemon.c:1324:9: call_function: calling ‘user_gc’ from ‘dbus_handler’
rtkit-0.11/rtkit-daemon.c:1324:9: return_function: returning to ‘dbus_handler’ from ‘user_gc’
rtkit-0.11/rtkit-daemon.c:1326:13: branch_true: following ‘true’ branch (when ‘is2 != 0’)...
rtkit-0.11/rtkit-daemon.c:1328:34: branch_true: ...to here
rtkit-0.11/rtkit-daemon.c:1335:28: call_function: calling ‘verify_canary_refusal’ from ‘dbus_handler’
rtkit-0.11/rtkit-daemon.c:1335:28: return_function: returning to ‘dbus_handler’ from ‘verify_canary_refusal’
rtkit-0.11/rtkit-daemon.c:1335:20: branch_false: following ‘false’ branch...
rtkit-0.11/rtkit-daemon.c:1340:20: branch_false: ...to here
rtkit-0.11/rtkit-daemon.c:1340:20: branch_true: following ‘true’ branch (when ‘is2 != 0’)...
rtkit-0.11/rtkit-daemon.c:1341:31: branch_true: ...to here
rtkit-0.11/rtkit-daemon.c:1352:20: branch_false: following ‘false’ branch (when ‘ret != 0’)...
rtkit-0.11/rtkit-daemon.c:1359:28: branch_false: ...to here
rtkit-0.11/rtkit-daemon.c:1359:20: branch_false: following ‘false’ branch...
rtkit-0.11/rtkit-daemon.c:1365:28: branch_false: ...to here
rtkit-0.11/rtkit-daemon.c:1365:28: danger: use of uninitialized value ‘p’ here
# 1363|                   }
# 1364|   
# 1365|->                 if ((ret = verify_polkit(c, u, p, "org.freedesktop.RealtimeKit1.acquire-real-time")) < 0) {
# 1366|                           assert_se(r = dbus_message_new_error_printf(m, translate_error_forward(ret), strerror(-ret)));
# 1367|                           goto finish;

Error: COMPILER_WARNING (CWE-134): [#def4]
rtkit-0.11/rtkit-daemon.c:1366:25: warning[-Wformat-security]: format not a string literal and no format arguments
# 1366 |                         assert_se(r = dbus_message_new_error_printf(m, translate_error_forward(ret), strerror(-ret)));
#      |                         ^~~~~~~~~
# 1364|   
# 1365|                   if ((ret = verify_polkit(c, u, p, "org.freedesktop.RealtimeKit1.acquire-real-time")) < 0) {
# 1366|->                         assert_se(r = dbus_message_new_error_printf(m, translate_error_forward(ret), strerror(-ret)));
# 1367|                           goto finish;
# 1368|                   }

Error: COMPILER_WARNING (CWE-134): [#def5]
rtkit-0.11/rtkit-daemon.c:1371:25: warning[-Wformat-security]: format not a string literal and no format arguments
# 1371 |                         assert_se(r = dbus_message_new_error_printf(m, translate_error_forward(ret), strerror(-ret)));
#      |                         ^~~~~~~~~
# 1369|   
# 1370|                   if ((ret = process_set_realtime(u, p, t, priority))) {
# 1371|->                         assert_se(r = dbus_message_new_error_printf(m, translate_error_forward(ret), strerror(-ret)));
# 1372|                           goto finish;
# 1373|                   }

Error: COMPILER_WARNING (CWE-134): [#def6]
rtkit-0.11/rtkit-daemon.c:1388:25: warning[-Wformat-security]: format not a string literal and no format arguments
# 1388 |                         assert_se(r = dbus_message_new_error_printf(m, translate_error_forward(ret), strerror(-ret)));
#      |                         ^~~~~~~~~
# 1386|   
# 1387|                   if ((ret = verify_canary_refusal()) < 0) {
# 1388|->                         assert_se(r = dbus_message_new_error_printf(m, translate_error_forward(ret), strerror(-ret)));
# 1389|                           goto finish;
# 1390|                   }

Error: COMPILER_WARNING (CWE-134): [#def7]
rtkit-0.11/rtkit-daemon.c:1413:25: warning[-Wformat-security]: format not a string literal and no format arguments
# 1413 |                         assert_se(r = dbus_message_new_error_printf(m, translate_error_forward(ret), strerror(-ret)));
#      |                         ^~~~~~~~~
# 1411|                   if ((ret = lookup_client(&u, &p, &t, c, m, (pid_t)process, (pid_t) thread)) < 0) {
# 1412|                           syslog(LOG_DEBUG, "Failed to look up client: %s\n", strerror(-ret));
# 1413|->                         assert_se(r = dbus_message_new_error_printf(m, translate_error_forward(ret), strerror(-ret)));
# 1414|                           goto finish;
# 1415|                   }

Error: GCC_ANALYZER_WARNING (CWE-457): [#def8]
rtkit-0.11/rtkit-daemon.c:1417:28: warning[-Wanalyzer-use-of-uninitialized-value]: use of uninitialized value ‘p’
rtkit-0.11/rtkit-daemon.c:1316:26: enter_function: entry to ‘dbus_handler’
rtkit-0.11/rtkit-daemon.c:1324:9: call_function: calling ‘user_gc’ from ‘dbus_handler’
rtkit-0.11/rtkit-daemon.c:1324:9: return_function: returning to ‘dbus_handler’ from ‘user_gc’
rtkit-0.11/rtkit-daemon.c:1326:12: branch_false: following ‘false’ branch...
rtkit-0.11/rtkit-daemon.c:1327:20: branch_false: ...to here
rtkit-0.11/rtkit-daemon.c:1326:13: branch_false: following ‘false’ branch (when ‘is2 == 0’)...
rtkit-0.11/rtkit-daemon.c:1377:20: branch_false: ...to here
rtkit-0.11/rtkit-daemon.c:1377:20: branch_true: following ‘true’ branch (when ‘is2 != 0’)...
rtkit-0.11/rtkit-daemon.c:1380:34: branch_true: ...to here
rtkit-0.11/rtkit-daemon.c:1387:28: call_function: calling ‘verify_canary_refusal’ from ‘dbus_handler’
rtkit-0.11/rtkit-daemon.c:1387:28: return_function: returning to ‘dbus_handler’ from ‘verify_canary_refusal’
rtkit-0.11/rtkit-daemon.c:1387:20: branch_false: following ‘false’ branch...
rtkit-0.11/rtkit-daemon.c:1392:20: branch_false: ...to here
rtkit-0.11/rtkit-daemon.c:1392:20: branch_true: following ‘true’ branch (when ‘is2 != 0’)...
rtkit-0.11/rtkit-daemon.c:1393:31: branch_true: ...to here
rtkit-0.11/rtkit-daemon.c:1404:20: branch_false: following ‘false’ branch (when ‘ret != 0’)...
rtkit-0.11/rtkit-daemon.c:1411:28: branch_false: ...to here
rtkit-0.11/rtkit-daemon.c:1411:20: branch_false: following ‘false’ branch...
rtkit-0.11/rtkit-daemon.c:1417:28: branch_false: ...to here
rtkit-0.11/rtkit-daemon.c:1417:28: danger: use of uninitialized value ‘p’ here
# 1415|                   }
# 1416|   
# 1417|->                 if ((ret = verify_polkit(c, u, p, "org.freedesktop.RealtimeKit1.acquire-high-priority")) < 0) {
# 1418|                           assert_se(r = dbus_message_new_error_printf(m, translate_error_forward(ret), strerror(-ret)));
# 1419|                           goto finish;

Error: COMPILER_WARNING (CWE-134): [#def9]
rtkit-0.11/rtkit-daemon.c:1418:25: warning[-Wformat-security]: format not a string literal and no format arguments
# 1418 |                         assert_se(r = dbus_message_new_error_printf(m, translate_error_forward(ret), strerror(-ret)));
#      |                         ^~~~~~~~~
# 1416|   
# 1417|                   if ((ret = verify_polkit(c, u, p, "org.freedesktop.RealtimeKit1.acquire-high-priority")) < 0) {
# 1418|->                         assert_se(r = dbus_message_new_error_printf(m, translate_error_forward(ret), strerror(-ret)));
# 1419|                           goto finish;
# 1420|                   }

Error: COMPILER_WARNING (CWE-134): [#def10]
rtkit-0.11/rtkit-daemon.c:1423:25: warning[-Wformat-security]: format not a string literal and no format arguments
# 1423 |                         assert_se(r = dbus_message_new_error_printf(m, translate_error_forward(ret), strerror(-ret)));
#      |                         ^~~~~~~~~
# 1421|   
# 1422|                   if ((ret = process_set_high_priority(u, p, t, priority))) {
# 1423|->                         assert_se(r = dbus_message_new_error_printf(m, translate_error_forward(ret), strerror(-ret)));
# 1424|                           goto finish;
# 1425|                   }

Scan Properties