Newly introduced findings

List of Findings

Error: SHELLCHECK_WARNING (CWE-563): [#def1]
/usr/bin/plymouth-set-default-theme:69:9: warning[SC2034]: CONFIG_FILE_LINES_ARRAY appears unused. Verify use (or export if used externally).
#   67|   
#   68|           #Build the initial array for the NeedsFile list
#   69|->         CONFIG_FILE_LINES_ARRAY=()
#   70|   
#   71|           #Handle all the valid lines in the file

Error: SHELLCHECK_WARNING (CWE-563): [#def2]
/usr/bin/plymouth-set-default-theme:107:17: warning[SC2034]: CONFIG_FILE_LINE_LAST_CHAR appears unused. Verify use (or export if used externally).
#  105|                   KEY_VALUE=""
#  106|   
#  107|->                 CONFIG_FILE_LINE_LAST_CHAR=${CONFIG_FILE_LINE:$((${#CONFIG_FILE_LINE} -1 )):1}
#  108|                   IFS="="
#  109|                   CONFIG_FILE_LINE=($CONFIG_FILE_LINE)

Error: SHELLCHECK_WARNING (CWE-140): [#def3]
/usr/bin/plymouth-set-default-theme:109:35: warning[SC2206]: Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a.
#  107|                   CONFIG_FILE_LINE_LAST_CHAR=${CONFIG_FILE_LINE:$((${#CONFIG_FILE_LINE} -1 )):1}
#  108|                   IFS="="
#  109|->                 CONFIG_FILE_LINE=($CONFIG_FILE_LINE)
#  110|                   unset IFS
#  111|   

Error: CPPCHECK_WARNING (CWE-476): [#def4]
plymouth-26.134.222/src/libply-splash-core/ply-device-manager.c:867: warning[nullPointerOutOfMemory]: If memory allocation fails, then there is a possible null pointer dereference: manager
#  865|           manager->loop = NULL;
#  866|           manager->xkb_context = xkb_context_new (XKB_CONTEXT_NO_FLAGS);
#  867|->         manager->extra_esc_key = extra_esc_key;
#  868|   
#  869|           if (manager->xkb_context == NULL)

Error: CPPCHECK_WARNING (CWE-457): [#def5]
plymouth-26.134.222/src/libply-splash-core/ply-keyboard.c:161: warning[uninitvar]: Uninitialized variable: *&capacity
#  159|           ply_list_node_t *node;
#  160|   
#  161|->         ply_buffer_borrow_bytes (keyboard->line_buffer, &bytes, &size, &capacity) {
#  162|                   ply_utf8_string_remove_last_character (&bytes, &size);
#  163|           }

Error: COMPILER_WARNING (CWE-252): [#def6]
plymouth-26.134.222/src/libply-splash-core/ply-kmsg-reader.c: scope_hint: In function ‘handle_kmsg_message’
plymouth-26.134.222/src/libply-splash-core/ply-kmsg-reader.c:135:17: warning[-Wunused-result]: ignoring return value of ‘asprintf’ declared with attribute ‘warn_unused_result’
#  135 |                 asprintf (&format_begin, bold_enabled ? "\033[0;1;%im" : "\033[0;%im", color);
#      |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
#  133|                           break;
#  134|                   }
#  135|->                 asprintf (&format_begin, bold_enabled ? "\033[0;1;%im" : "\033[0;%im", color);
#  136|   
#  137|                   message_substr = strtok_r (message, "\n", &saveptr);

Error: GCC_ANALYZER_WARNING: [#def7]
plymouth-26.134.222/src/libply/ply-utils.c:1357:23: warning[-Wanalyzer-fd-use-without-check]: ‘read’ on possibly invalid file descriptor ‘open("/proc/consoles", 0)’
plymouth-26.134.222/src/libply/ply-utils.c:1353:12: branch_true: following ‘true’ branch...
plymouth-26.134.222/src/libply/ply-utils.c:1354:17: branch_true: ...to here
plymouth-26.134.222/src/libply/ply-utils.c:1356:22: acquire_resource: opened here
plymouth-26.134.222/src/libply/ply-utils.c:1357:23: danger: ‘open("/proc/consoles", 0)’ could be invalid: unchecked value from [(3)](sarif:/runs/0/results/8/codeFlows/0/threadFlows/0/locations/2)
# 1355|   
# 1356|                   fd = open ("/proc/consoles", O_RDONLY);
# 1357|->                 len = read (fd, proc_consoles, sizeof(proc_consoles));
# 1358|                   close (fd);
# 1359|   

Error: CPPCHECK_WARNING (CWE-457): [#def8]
plymouth-26.134.222/src/main.c:1706: warning[uninitvar]: Uninitialized variable: *&capacity
# 1704|           if (!node) return;
# 1705|   
# 1706|->         ply_buffer_borrow_bytes (state->entry_buffer, &bytes, &size, &capacity) {
# 1707|                   ply_utf8_string_remove_last_character (&bytes, &size);
# 1708|           }

Error: COMPILER_WARNING (CWE-252): [#def9]
plymouth-26.134.222/src/plugins/controls/label-freetype/plugin.c: scope_hint: In function ‘find_default_monospace_font_path’
plymouth-26.134.222/src/plugins/controls/label-freetype/plugin.c:177:9: warning[-Wunused-result]: ignoring return value of ‘fgets’ declared with attribute ‘warn_unused_result’
#  177 |         fgets (fc_match_out, sizeof(fc_match_out), fp);
#      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
#  175|                   return MONOSPACE_FONT_FALLBACK;
#  176|   
#  177|->         fgets (fc_match_out, sizeof(fc_match_out), fp);
#  178|   
#  179|           pclose (fp);

Error: COMPILER_WARNING (CWE-252): [#def10]
plymouth-26.134.222/src/plugins/controls/label-freetype/plugin.c: scope_hint: In function ‘find_default_monospace_bold_font_path’
plymouth-26.134.222/src/plugins/controls/label-freetype/plugin.c:197:9: warning[-Wunused-result]: ignoring return value of ‘fgets’ declared with attribute ‘warn_unused_result’
#  197 |         fgets (fc_match_out, sizeof(fc_match_out), fp);
#      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
#  195|                   return MONOSPACE_BOLD_FONT_FALLBACK;
#  196|   
#  197|->         fgets (fc_match_out, sizeof(fc_match_out), fp);
#  198|   
#  199|           pclose (fp);

Error: CPPCHECK_WARNING (CWE-476): [#def11]
plymouth-26.134.222/src/plugins/controls/label-freetype/plugin.c:837: warning[nullPointerOutOfMemory]: If memory allocation fails, then there is a possible null pointer dereference: new_font
#  835|           label->font = new_font;
#  836|   
#  837|->         if (strstr (new_font, "Mono") || strstr (new_font, "mono")) {
#  838|                   if (!label->is_monospaced) {
#  839|                           FT_Done_Face (label->face);

Error: CPPCHECK_WARNING (CWE-476): [#def12]
plymouth-26.134.222/src/plugins/splash/fade-throbber/plugin.c:252: warning[nullPointerOutOfMemory]: If memory allocation fails, then there is a possible null pointer dereference: plugin
#  250|   
#  251|           /* Likely only able to set the font if the font is in the initrd */
#  252|->         plugin->monospace_font = ply_key_file_get_value (key_file, "fade-throbber", "MonospaceFont");
#  253|   
#  254|           if (plugin->monospace_font == NULL)

Error: CPPCHECK_WARNING (CWE-476): [#def13]
plymouth-26.134.222/src/plugins/splash/fade-throbber/plugin.c:262: warning[nullPointerOutOfMemory]: If memory allocation fails, then there is a possible null pointer dereference: plugin
#  260|                                           PLY_CONSOLE_VIEWER_LOG_TEXT_COLOR);
#  261|   
#  262|->         plugin->console_background_color =
#  263|                   ply_key_file_get_ulong (key_file, "fade-throbber",
#  264|                                           "ConsoleLogBackgroundColor",

Error: CPPCHECK_WARNING (CWE-476): [#def14]
plymouth-26.134.222/src/plugins/splash/script/plugin.c:230: warning[nullPointerOutOfMemory]: If memory allocation fails, then there is a possible null pointer dereference: plugin
#  228|   
#  229|           /* Likely only able to set the font if the font is in the initrd */
#  230|->         plugin->monospace_font = ply_key_file_get_value (key_file, "script", "MonospaceFont");
#  231|   
#  232|           if (plugin->monospace_font == NULL)

Error: CPPCHECK_WARNING (CWE-476): [#def15]
plymouth-26.134.222/src/plugins/splash/script/plugin.c:240: warning[nullPointerOutOfMemory]: If memory allocation fails, then there is a possible null pointer dereference: plugin
#  238|                                           PLY_CONSOLE_VIEWER_LOG_TEXT_COLOR);
#  239|   
#  240|->         plugin->console_background_color =
#  241|                   ply_key_file_get_ulong (key_file, "script",
#  242|                                           "ConsoleLogBackgroundColor",

Error: CPPCHECK_WARNING (CWE-476): [#def16]
plymouth-26.134.222/src/plugins/splash/script/script-lib-sprite.c:584: warning[nullPointerOutOfMemory]: If memory allocation fails, then there is a possible null pointer dereference: data
#  582|           data->displays = ply_list_new ();
#  583|   
#  584|->         data->boot_buffer = boot_buffer;
#  585|           data->monospace_font = monospace_font;
#  586|           data->console_text_color = console_text_color;

Error: CPPCHECK_WARNING (CWE-476): [#def17]
plymouth-26.134.222/src/plugins/splash/script/script-lib-sprite.c:585: warning[nullPointerOutOfMemory]: If memory allocation fails, then there is a possible null pointer dereference: data
#  583|   
#  584|           data->boot_buffer = boot_buffer;
#  585|->         data->monospace_font = monospace_font;
#  586|           data->console_text_color = console_text_color;
#  587|           data->console_background_color = console_background_color;

Error: CPPCHECK_WARNING (CWE-476): [#def18]
plymouth-26.134.222/src/plugins/splash/script/script-lib-sprite.c:586: warning[nullPointerOutOfMemory]: If memory allocation fails, then there is a possible null pointer dereference: data
#  584|           data->boot_buffer = boot_buffer;
#  585|           data->monospace_font = monospace_font;
#  586|->         data->console_text_color = console_text_color;
#  587|           data->console_background_color = console_background_color;
#  588|   

Error: CPPCHECK_WARNING (CWE-476): [#def19]
plymouth-26.134.222/src/plugins/splash/script/script-lib-sprite.c:587: warning[nullPointerOutOfMemory]: If memory allocation fails, then there is a possible null pointer dereference: data
#  585|           data->monospace_font = monospace_font;
#  586|           data->console_text_color = console_text_color;
#  587|->         data->console_background_color = console_background_color;
#  588|   
#  589|           for (node = ply_list_get_first_node (pixel_displays);

Error: CPPCHECK_WARNING (CWE-476): [#def20]
plymouth-26.134.222/src/plugins/splash/script/script-lib-sprite.c:723: warning[nullPointerOutOfMemory]: If memory allocation fails, then there is a possible null pointer dereference: data
#  721|           data->background_color_start = 0x000000;
#  722|           data->background_color_end = 0x000000;
#  723|->         data->full_refresh = true;
#  724|           data->needs_redraw = true;
#  725|           script_return_t ret = script_execute (state, data->script_main_op);

Error: CPPCHECK_WARNING (CWE-476): [#def21]
plymouth-26.134.222/src/plugins/splash/script/script-lib-sprite.c:724: warning[nullPointerOutOfMemory]: If memory allocation fails, then there is a possible null pointer dereference: data
#  722|           data->background_color_end = 0x000000;
#  723|           data->full_refresh = true;
#  724|->         data->needs_redraw = true;
#  725|           script_return_t ret = script_execute (state, data->script_main_op);
#  726|   

Error: CPPCHECK_WARNING (CWE-476): [#def22]
plymouth-26.134.222/src/plugins/splash/script/script-lib-sprite.c:727: warning[nullPointerOutOfMemory]: If memory allocation fails, then there is a possible null pointer dereference: data
#  725|           script_return_t ret = script_execute (state, data->script_main_op);
#  726|   
#  727|->         data->should_show_console_messages = false;
#  728|           data->plugin_console_messages_updating = false;
#  729|           data->console_viewer_needs_redraw = false;

Error: CPPCHECK_WARNING (CWE-476): [#def23]
plymouth-26.134.222/src/plugins/splash/script/script-lib-sprite.c:728: warning[nullPointerOutOfMemory]: If memory allocation fails, then there is a possible null pointer dereference: data
#  726|   
#  727|           data->should_show_console_messages = false;
#  728|->         data->plugin_console_messages_updating = false;
#  729|           data->console_viewer_needs_redraw = false;
#  730|   

Error: CPPCHECK_WARNING (CWE-476): [#def24]
plymouth-26.134.222/src/plugins/splash/script/script-lib-sprite.c:729: warning[nullPointerOutOfMemory]: If memory allocation fails, then there is a possible null pointer dereference: data
#  727|           data->should_show_console_messages = false;
#  728|           data->plugin_console_messages_updating = false;
#  729|->         data->console_viewer_needs_redraw = false;
#  730|   
#  731|           script_obj_unref (ret.object);

Error: CPPCHECK_WARNING (CWE-476): [#def25]
plymouth-26.134.222/src/plugins/splash/space-flares/plugin.c:631: warning[nullPointerOutOfMemory]: If memory allocation fails, then there is a possible null pointer dereference: plugin
#  629|   
#  630|           /* Likely only able to set the font if the font is in the initrd */
#  631|->         plugin->monospace_font = ply_key_file_get_value (key_file, "space-flares", "MonospaceFont");
#  632|   
#  633|           if (plugin->monospace_font == NULL)

Error: CPPCHECK_WARNING (CWE-476): [#def26]
plymouth-26.134.222/src/plugins/splash/space-flares/plugin.c:633: warning[nullPointerOutOfMemory]: If memory allocation fails, then there is a possible null pointer dereference: plugin
#  631|           plugin->monospace_font = ply_key_file_get_value (key_file, "space-flares", "MonospaceFont");
#  632|   
#  633|->         if (plugin->monospace_font == NULL)
#  634|                   plugin->monospace_font = strdup ("monospace 10");
#  635|   

Error: CPPCHECK_WARNING (CWE-476): [#def27]
plymouth-26.134.222/src/plugins/splash/space-flares/plugin.c:636: warning[nullPointerOutOfMemory]: If memory allocation fails, then there is a possible null pointer dereference: plugin
#  634|                   plugin->monospace_font = strdup ("monospace 10");
#  635|   
#  636|->         plugin->console_text_color =
#  637|                   ply_key_file_get_ulong (key_file, "space-flares",
#  638|                                           "ConsoleLogTextColor",

Error: CPPCHECK_WARNING (CWE-476): [#def28]
plymouth-26.134.222/src/plugins/splash/space-flares/plugin.c:641: warning[nullPointerOutOfMemory]: If memory allocation fails, then there is a possible null pointer dereference: plugin
#  639|                                           PLY_CONSOLE_VIEWER_LOG_TEXT_COLOR);
#  640|   
#  641|->         plugin->console_background_color =
#  642|                   ply_key_file_get_ulong (key_file, "space-flares",
#  643|                                           "ConsoleLogBackgroundColor",

Error: CPPCHECK_WARNING (CWE-476): [#def29]
plymouth-26.134.222/src/plugins/splash/space-flares/plugin.c:646: warning[nullPointerOutOfMemory]: If memory allocation fails, then there is a possible null pointer dereference: plugin
#  644|                                           0x00000000);
#  645|   
#  646|->         plugin->state = PLY_BOOT_SPLASH_DISPLAY_NORMAL;
#  647|           plugin->progress = 0;
#  648|           plugin->progress_target = -1;

Scan Properties