Fixed findings

List of Findings

Error: GCC_ANALYZER_WARNING (CWE-476): [#def1]
lttng-ust-2.14.0/src/common/ringbuffer/ring_buffer_backend.c:52:9: warning[-Wanalyzer-null-dereference]: dereference of NULL '0'
#   50|   		return -EINVAL;
#   51|   
#   52|-> 	subbuf_size = chanb->subbuf_size;
#   53|   	num_subbuf_alloc = num_subbuf;
#   54|   

Error: GCC_ANALYZER_WARNING (CWE-476): [#def2]
lttng-ust-2.14.0/src/common/ringbuffer/ring_buffer_backend.c:185:9: warning[-Wanalyzer-null-dereference]: dereference of NULL '0'
#  183|   	config = &chanb->config;
#  184|   
#  185|-> 	num_subbuf_alloc = chanb->num_subbuf;
#  186|   	if (chanb->extra_reader_sb)
#  187|   		num_subbuf_alloc++;

Error: GCC_ANALYZER_WARNING (CWE-476): [#def3]
lttng-ust-2.14.0/src/common/ringbuffer/ring_buffer_backend.c:433:19: warning[-Wanalyzer-null-dereference]: dereference of NULL '0'
#  431|   	config = &chanb->config;
#  432|   	orig_len = len;
#  433|-> 	offset &= chanb->buf_size - 1;
#  434|   
#  435|   	if (caa_unlikely(!len))

Error: GCC_ANALYZER_WARNING (CWE-476): [#def4]
lttng-ust-2.14.0/src/common/ringbuffer/ring_buffer_backend.c:487:19: warning[-Wanalyzer-null-dereference]: dereference of NULL '0'
lttng-ust-2.14.0/src/common/ringbuffer/ring_buffer_backend.c:485:12: branch_false: following 'false' branch...
lttng-ust-2.14.0/src/common/ringbuffer/ring_buffer_backend.c:487:19: branch_false: ...to here
lttng-ust-2.14.0/src/common/ringbuffer/ring_buffer_backend.c:487:19: danger: dereference of NULL '<unknown>'
#  485|   	if (caa_unlikely(!len))
#  486|   		return -EINVAL;
#  487|-> 	offset &= chanb->buf_size - 1;
#  488|   	orig_offset = offset;
#  489|   	id = bufb->buf_rsb.id;

Error: GCC_ANALYZER_WARNING (CWE-476): [#def5]
lttng-ust-2.14.0/src/common/ringbuffer/ring_buffer_backend.c:540:19: warning[-Wanalyzer-null-dereference]: dereference of NULL '0'
#  538|   		return NULL;
#  539|   	config = &chanb->config;
#  540|-> 	offset &= chanb->buf_size - 1;
#  541|   	id = bufb->buf_rsb.id;
#  542|   	sb_bindex = subbuffer_id_get_index(config, id);

Error: GCC_ANALYZER_WARNING (CWE-476): [#def6]
lttng-ust-2.14.0/src/common/ringbuffer/ring_buffer_backend.c:580:19: warning[-Wanalyzer-null-dereference]: dereference of NULL '0'
#  578|   		return NULL;
#  579|   	config = &chanb->config;
#  580|-> 	offset &= chanb->buf_size - 1;
#  581|   	sbidx = offset >> chanb->subbuf_size_order;
#  582|   	sb = shmp_index(handle, bufb->buf_wsb, sbidx);

Error: COMPILER_WARNING: [#def7]
lttng-ust-2.14.0/src/common/snprintf/vfprintf.c: scope_hint: In function 'ust_safe_vfprintf'
lttng-ust-2.14.0/src/common/snprintf/vfprintf.c:248:45: warning[-Wunterminated-string-initialization]: initializer-string for array of 'char' truncates NUL terminator but destination lacks 'nonstring' attribute (17 chars into 16 available)
#  248 |         static const char xdigs_lower[16] = "0123456789abcdef";
#      |                                             ^~~~~~~~~~~~~~~~~~
#  246|   	 {'0','0','0','0','0','0','0','0','0','0','0','0','0','0','0','0'};
#  247|   
#  248|-> 	static const char xdigs_lower[16] = "0123456789abcdef";
#  249|   	static const char xdigs_upper[16] = "0123456789ABCDEF";
#  250|   

Error: COMPILER_WARNING: [#def8]
lttng-ust-2.14.0/src/common/snprintf/vfprintf.c:249:45: warning[-Wunterminated-string-initialization]: initializer-string for array of 'char' truncates NUL terminator but destination lacks 'nonstring' attribute (17 chars into 16 available)
#  249 |         static const char xdigs_upper[16] = "0123456789ABCDEF";
#      |                                             ^~~~~~~~~~~~~~~~~~
cc1: note: unrecognized command-line option '-Wno-gnu' may have been intended to silence earlier diagnostics
#  247|   
#  248|   	static const char xdigs_lower[16] = "0123456789abcdef";
#  249|-> 	static const char xdigs_upper[16] = "0123456789ABCDEF";
#  250|   
#  251|   	/*

Error: COMPILER_WARNING (CWE-563): [#def9]
lttng-ust-2.14.0/src/lib/lttng-ust-ctl/ustctl.c: scope_hint: In function 'lttng_ust_ctl_get_mmap_base'
lttng-ust-2.14.0/src/lib/lttng-ust-ctl/ustctl.c:117:17: warning[-Wunused-value]: statement with no effect
#  117 |                 true; \
#      |                 ^~~~
lttng-ust-2.14.0/src/lib/lttng-ust-ctl/ustctl.c:1762:13: note: in expansion of macro 'sigbus_begin'
# 1762 |         if (sigbus_begin())
#      |             ^~~~~~~~~~~~
#  115|   		/* SIGBUS. */ \
#  116|   		CMM_STORE_SHARED(lttng_ust_sigbus_state.jmp_ready, 0); \
#  117|-> 		true; \
#  118|   	} \
#  119|   	cmm_barrier(); \

Scan Properties