Fixed findings

List of Findings

Error: SHELLCHECK_WARNING: [#def1]
/usr/libexec/libvirt-guests.sh:109:5: warning[SC3043]: In POSIX sh, 'local' is undefined.
#  107|       local uri="$1"
#  108|       local persistent="$2"
#  109|->     local list="$(run_virsh_c "$uri" list --uuid $persistent)"
#  110|   
#  111|       if [ $? -ne 0 ]; then

Error: SHELLCHECK_WARNING (CWE-571): [#def2]
/usr/libexec/libvirt-guests.sh:109:11: warning[SC2155]: Declare and assign separately to avoid masking return values.
#  107|       local uri="$1"
#  108|       local persistent="$2"
#  109|->     local list="$(run_virsh_c "$uri" list --uuid $persistent)"
#  110|   
#  111|       if [ $? -ne 0 ]; then

Error: SHELLCHECK_WARNING: [#def3]
/usr/libexec/libvirt-guests.sh:134:5: warning[SC3043]: In POSIX sh, 'local' is undefined.
#  132|       local uri="$1"
#  133|       local uuid="$2"
#  134|->     local id="$(run_virsh "$uri" domid "$uuid")"
#  135|   
#  136|       guest_running="false"

Error: SHELLCHECK_WARNING (CWE-571): [#def4]
/usr/libexec/libvirt-guests.sh:134:11: warning[SC2155]: Declare and assign separately to avoid masking return values.
#  132|       local uri="$1"
#  133|       local uuid="$2"
#  134|->     local id="$(run_virsh "$uri" domid "$uuid")"
#  135|   
#  136|       guest_running="false"

Error: SHELLCHECK_WARNING: [#def5]
/usr/libexec/libvirt-guests.sh:485:9: warning[SC3043]: In POSIX sh, 'local' is undefined.
#  483|           eval_gettext "Running guests on \$uri URI: "
#  484|   
#  485|->         local list="$(list_guests "$uri")"
#  486|           if [ $? -eq 0 ]; then
#  487|               local empty=true

Error: SHELLCHECK_WARNING (CWE-571): [#def6]
/usr/libexec/libvirt-guests.sh:485:15: warning[SC2155]: Declare and assign separately to avoid masking return values.
#  483|           eval_gettext "Running guests on \$uri URI: "
#  484|   
#  485|->         local list="$(list_guests "$uri")"
#  486|           if [ $? -eq 0 ]; then
#  487|               local empty=true

Error: SHELLCHECK_WARNING: [#def7]
/usr/libexec/libvirt-guests.sh:501:13: warning[SC3043]: In POSIX sh, 'local' is undefined.
#  499|   
#  500|           if "$persistent_only"; then
#  501|->             local transient="$(list_guests "$uri" "--transient")"
#  502|               if [ $? -eq 0 ]; then
#  503|                   local empty="true"

Error: SHELLCHECK_WARNING (CWE-571): [#def8]
/usr/libexec/libvirt-guests.sh:501:19: warning[SC2155]: Declare and assign separately to avoid masking return values.
#  499|   
#  500|           if "$persistent_only"; then
#  501|->             local transient="$(list_guests "$uri" "--transient")"
#  502|               if [ $? -eq 0 ]; then
#  503|                   local empty="true"

Error: GCC_ANALYZER_WARNING (CWE-457): [#def9]
libvirt-12.0.0/src/hyperv/hyperv_driver.c:928:17: warning[-Wanalyzer-use-of-uninitialized-value]: use of uninitialized value ‘ideChannels[ctrlr_idx]’
libvirt-12.0.0/src/hyperv/hyperv_driver.c:2900:1: enter_function: entry to ‘hypervDomainDefineXML’
libvirt-12.0.0/src/hyperv/hyperv_driver.c:2903:33: call_function: calling ‘hypervConnectGetHostname’ from ‘hypervDomainDefineXML’
libvirt-12.0.0/src/hyperv/hyperv_driver.c:2903:33: return_function: returning to ‘hypervDomainDefineXML’ from ‘hypervConnectGetHostname’
libvirt-12.0.0/src/hyperv/hyperv_driver.c:2914:8: branch_false: following ‘false’ branch...
libvirt-12.0.0/src/hyperv/hyperv_driver.c:2918:50: branch_false: ...to here
libvirt-12.0.0/src/hyperv/hyperv_driver.c:2918:8: branch_false: following ‘false’ branch...
libvirt-12.0.0/src/hyperv/hyperv_driver.c:2929:14: branch_false: ...to here
libvirt-12.0.0/src/hyperv/hyperv_driver.c:2933:8: branch_false: following ‘false’ branch...
libvirt-12.0.0/src/hyperv/hyperv_driver.c:2936:25: branch_false: ...to here
libvirt-12.0.0/src/hyperv/hyperv_driver.c:2938:8: branch_false: following ‘false’ branch...
libvirt-12.0.0/src/hyperv/hyperv_driver.c:2941:9: branch_false: ...to here
libvirt-12.0.0/src/hyperv/hyperv_driver.c:2941:8: branch_false: following ‘false’ branch...
libvirt-12.0.0/src/hyperv/hyperv_driver.c:2946:9: branch_false: ...to here
libvirt-12.0.0/src/hyperv/hyperv_driver.c:2946:8: branch_false: following ‘false’ branch...
libvirt-12.0.0/src/hyperv/hyperv_driver.c:2950:45: branch_false: ...to here
libvirt-12.0.0/src/hyperv/hyperv_driver.c:2950:14: call_function: calling ‘hypervDomainLookupByName’ from ‘hypervDomainDefineXML’
libvirt-12.0.0/src/hyperv/hyperv_driver.c:2950:14: return_function: returning to ‘hypervDomainDefineXML’ from ‘hypervDomainLookupByName’
libvirt-12.0.0/src/hyperv/hyperv_driver.c:2953:8: branch_false: following ‘false’ branch...
libvirt-12.0.0/src/hyperv/hyperv_driver.c:2957:9: branch_false: ...to here
libvirt-12.0.0/src/hyperv/hyperv_driver.c:2957:8: branch_false: following ‘false’ branch...
libvirt-12.0.0/src/hyperv/hyperv_driver.c:2961:9: branch_false: ...to here
libvirt-12.0.0/src/hyperv/hyperv_driver.c:2961:8: branch_false: following ‘false’ branch...
libvirt-12.0.0/src/hyperv/hyperv_driver.c:2965:9: branch_false: ...to here
libvirt-12.0.0/src/hyperv/hyperv_driver.c:2965:9: call_function: calling ‘hypervDomainAttachStorage’ from ‘hypervDomainDefineXML’
#  926|           case VIR_DOMAIN_DISK_BUS_IDE:
#  927|               ctrlr_idx = def->disks[i]->info.addr.drive.bus;
#  928|->             if (hypervDomainAttachStorageVolume(domain, def->disks[i],
#  929|                                                   ideChannels[ctrlr_idx], hostname) < 0) {
#  930|                   return -1;

Error: GCC_ANALYZER_WARNING (CWE-457): [#def10]
libvirt-12.0.0/src/hyperv/hyperv_driver.c:935:17: warning[-Wanalyzer-use-of-uninitialized-value]: use of uninitialized value ‘scsiControllers[ctrlr_idx]’
libvirt-12.0.0/src/hyperv/hyperv_driver.c:2900:1: enter_function: entry to ‘hypervDomainDefineXML’
libvirt-12.0.0/src/hyperv/hyperv_driver.c:2903:33: call_function: calling ‘hypervConnectGetHostname’ from ‘hypervDomainDefineXML’
libvirt-12.0.0/src/hyperv/hyperv_driver.c:2903:33: return_function: returning to ‘hypervDomainDefineXML’ from ‘hypervConnectGetHostname’
libvirt-12.0.0/src/hyperv/hyperv_driver.c:2914:8: branch_false: following ‘false’ branch...
libvirt-12.0.0/src/hyperv/hyperv_driver.c:2918:50: branch_false: ...to here
libvirt-12.0.0/src/hyperv/hyperv_driver.c:2918:8: branch_false: following ‘false’ branch...
libvirt-12.0.0/src/hyperv/hyperv_driver.c:2929:14: branch_false: ...to here
libvirt-12.0.0/src/hyperv/hyperv_driver.c:2933:8: branch_false: following ‘false’ branch...
libvirt-12.0.0/src/hyperv/hyperv_driver.c:2936:25: branch_false: ...to here
libvirt-12.0.0/src/hyperv/hyperv_driver.c:2938:8: branch_false: following ‘false’ branch...
libvirt-12.0.0/src/hyperv/hyperv_driver.c:2941:9: branch_false: ...to here
libvirt-12.0.0/src/hyperv/hyperv_driver.c:2941:8: branch_false: following ‘false’ branch...
libvirt-12.0.0/src/hyperv/hyperv_driver.c:2946:9: branch_false: ...to here
libvirt-12.0.0/src/hyperv/hyperv_driver.c:2946:8: branch_false: following ‘false’ branch...
libvirt-12.0.0/src/hyperv/hyperv_driver.c:2950:45: branch_false: ...to here
libvirt-12.0.0/src/hyperv/hyperv_driver.c:2950:14: call_function: calling ‘hypervDomainLookupByName’ from ‘hypervDomainDefineXML’
libvirt-12.0.0/src/hyperv/hyperv_driver.c:2950:14: return_function: returning to ‘hypervDomainDefineXML’ from ‘hypervDomainLookupByName’
libvirt-12.0.0/src/hyperv/hyperv_driver.c:2953:8: branch_false: following ‘false’ branch...
libvirt-12.0.0/src/hyperv/hyperv_driver.c:2957:9: branch_false: ...to here
libvirt-12.0.0/src/hyperv/hyperv_driver.c:2957:8: branch_false: following ‘false’ branch...
libvirt-12.0.0/src/hyperv/hyperv_driver.c:2961:9: branch_false: ...to here
libvirt-12.0.0/src/hyperv/hyperv_driver.c:2961:8: branch_false: following ‘false’ branch...
libvirt-12.0.0/src/hyperv/hyperv_driver.c:2965:9: branch_false: ...to here
libvirt-12.0.0/src/hyperv/hyperv_driver.c:2965:9: call_function: calling ‘hypervDomainAttachStorage’ from ‘hypervDomainDefineXML’
#  933|           case VIR_DOMAIN_DISK_BUS_SCSI:
#  934|               ctrlr_idx = def->disks[i]->info.addr.drive.controller;
#  935|->             if (hypervDomainAttachStorageVolume(domain, def->disks[i],
#  936|                                                   scsiControllers[ctrlr_idx], hostname) < 0) {
#  937|                   return -1;

Scan Properties

analyzer-version-clippy1.95.0
analyzer-version-cppcheck2.20.0
analyzer-version-gcc16.1.1
analyzer-version-gcc-analyzer16.1.1
analyzer-version-shellcheck0.11.0
analyzer-version-unicontrol0.0.2
diffbase-analyzer-version-clippy1.95.0
diffbase-analyzer-version-cppcheck2.20.0
diffbase-analyzer-version-gcc16.1.1
diffbase-analyzer-version-gcc-analyzer16.1.1
diffbase-analyzer-version-shellcheck0.11.0
diffbase-analyzer-version-unicontrol0.0.2
diffbase-enabled-pluginsclippy, cppcheck, gcc, shellcheck, unicontrol
diffbase-exit-code0
diffbase-hostip-172-16-1-68.us-west-2.compute.internal
diffbase-known-false-positives/usr/share/csmock/known-false-positives.js
diffbase-known-false-positives-rpmknown-false-positives-0.0.0.20260524.213755.g3c6d0be.main-1.el9.noarch
diffbase-mock-configfedora-rawhide-x86_64
diffbase-project-namelibvirt-12.3.0-1.fc45
diffbase-store-results-to/tmp/tmpdg0m10fl/libvirt-12.3.0-1.fc45.tar.xz
diffbase-time-created2026-06-01 15:01:59
diffbase-time-finished2026-06-01 15:12:07
diffbase-toolcsmock
diffbase-tool-args'/usr/bin/csmock' '-r' 'fedora-rawhide-x86_64' '-t' 'shellcheck,cppcheck,clippy,unicontrol,gcc' '-o' '/tmp/tmpdg0m10fl/libvirt-12.3.0-1.fc45.tar.xz' '--gcc-analyze' '--unicontrol-notests' '--unicontrol-bidi-only' '--install' 'pam' '--gcc-analyzer-bin=/usr/bin/gcc' '/tmp/tmpdg0m10fl/libvirt-12.3.0-1.fc45.src.rpm'
diffbase-tool-versioncsmock-3.8.5.20260529.133039.g6f3b5c6-1.el9
enabled-pluginsclippy, cppcheck, gcc, shellcheck, unicontrol
exit-code0
hostip-172-16-1-68.us-west-2.compute.internal
known-false-positives/usr/share/csmock/known-false-positives.js
known-false-positives-rpmknown-false-positives-0.0.0.20260524.213755.g3c6d0be.main-1.el9.noarch
mock-configfedora-rawhide-x86_64
project-namelibvirt-12.0.0-3.fc44
store-results-to/tmp/tmp616uthx4/libvirt-12.0.0-3.fc44.tar.xz
time-created2026-06-01 14:49:37
time-finished2026-06-01 15:01:41
titleFixed findings
toolcsmock
tool-args'/usr/bin/csmock' '-r' 'fedora-rawhide-x86_64' '-t' 'shellcheck,cppcheck,clippy,unicontrol,gcc' '-o' '/tmp/tmp616uthx4/libvirt-12.0.0-3.fc44.tar.xz' '--gcc-analyze' '--unicontrol-notests' '--unicontrol-bidi-only' '--install' 'pam' '--gcc-analyzer-bin=/usr/bin/gcc' '/tmp/tmp616uthx4/libvirt-12.0.0-3.fc44.src.rpm'
tool-versioncsmock-3.8.5.20260529.133039.g6f3b5c6-1.el9