Newly introduced findings

List of Findings

Error: SHELLCHECK_WARNING (CWE-456): [#def1]
/usr/libexec/git-core/git-gui:12:5: warning[SC2121]: To assign a variable, use just 'var=value', no 'set ..'.
#   10|    exec 'wish' "$argv0" -- "$@"
#   11|   
#   12|-> set appvers {0.21.0.264.gbb52cd}
#   13|   set copyright [string map [list (c) \u00a9] {
#   14|   Copyright (c) 2006-2010 Shawn Pearce, et. al.

Error: SHELLCHECK_WARNING (CWE-569): [#def2]
/usr/libexec/git-core/git-gui:12:13: warning[SC1083]: This { is literal. Check expression (missing ;/\n?) or quote it.
#   10|    exec 'wish' "$argv0" -- "$@"
#   11|   
#   12|-> set appvers {0.21.0.264.gbb52cd}
#   13|   set copyright [string map [list (c) \u00a9] {
#   14|   Copyright (c) 2006-2010 Shawn Pearce, et. al.

Error: SHELLCHECK_WARNING (CWE-569): [#def3]
/usr/libexec/git-core/git-gui:12:32: warning[SC1083]: This } is literal. Check expression (missing ;/\n?) or quote it.
#   10|    exec 'wish' "$argv0" -- "$@"
#   11|   
#   12|-> set appvers {0.21.0.264.gbb52cd}
#   13|   set copyright [string map [list (c) \u00a9] {
#   14|   Copyright (c) 2006-2010 Shawn Pearce, et. al.

Error: GCC_ANALYZER_WARNING (CWE-688): [#def4]
git-2.54.0/strbuf.h:310:9: warning[-Wanalyzer-null-argument]: use of NULL ‘s’ where non-null expected
git-2.54.0/builtin/config.c:1594:5: enter_function: entry to ‘cmd_config’
git-2.54.0/builtin/config.c:1621:12: branch_false: following ‘false’ branch...
git-2.54.0/builtin/config.c:1627:16: branch_false: ...to here
git-2.54.0/builtin/config.c:1627:16: call_function: calling ‘cmd_config_actions’ from ‘cmd_config’
#  308|   static inline void strbuf_addstr(struct strbuf *sb, const char *s)
#  309|   {
#  310|-> 	strbuf_add(sb, s, strlen(s));
#  311|   }
#  312|   

Scan Properties