Fixed findings

List of Findings

Error: SHELLCHECK_WARNING (CWE-457): [#def1]
/usr/bin/dracut:1554:48: warning[SC2154]: dbusconfdir is referenced but not assigned.
# 1552|   set_global_var "dbus" "dbusconfdir" "/etc/dbus-1"
# 1553|   set_global_var "dbus" "dbusinterfaces" "${dbus}/interfaces"
# 1554|-> set_global_var "dbus" "dbusinterfacesconfdir" "${dbusconfdir}/interfaces"
# 1555|   set_global_var "dbus" "dbusservices" "${dbus}/services"
# 1556|   set_global_var "dbus" "dbusservicesconfdir" "${dbusconfdir}/services"

Error: SHELLCHECK_WARNING (CWE-457): [#def2]
/usr/bin/dracut:1568:43: warning[SC2154]: udevconfdir is referenced but not assigned.
# 1566|   set_global_var "udev" "udevconfdir" "/etc/udev"
# 1567|   set_global_var "udev" "udevrulesdir" "${udevdir}/rules.d"
# 1568|-> set_global_var "udev" "udevrulesconfdir" "${udevconfdir}/rules.d"
# 1569|   
# 1570|   # systemd global variables

Error: SHELLCHECK_WARNING (CWE-457): [#def3]
/usr/bin/dracut:1582:51: warning[SC2154]: systemdutilconfdir is referenced but not assigned.
# 1580|   set_global_var "systemd" "systemdcatalog" "${systemdutildir}/catalog"
# 1581|   set_global_var "systemd" "systemdnetwork" "${systemdutildir}/network"
# 1582|-> set_global_var "systemd" "systemdnetworkconfdir" "${systemdutilconfdir}/network"
# 1583|   set_global_var "systemd" "systemdntpunits" "${systemdutildir}/ntp-units.d"
# 1584|   set_global_var "systemd" "systemdntpunitsconfdir" "${systemdutilconfdir}/ntp-units.d"

Error: SHELLCHECK_WARNING (CWE-758): [#def4]
/usr/lib/dracut/dracut-version.sh:1:1: error[SC2148]: Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive.
#    1|-> DRACUT_VERSION=108-6.fc45

Error: SHELLCHECK_WARNING (CWE-563): [#def5]
/usr/lib/dracut/dracut-version.sh:1:1: warning[SC2034]: DRACUT_VERSION appears unused. Verify use (or export if used externally).
#    1|-> DRACUT_VERSION=108-6.fc45

Error: SHELLCHECK_WARNING (CWE-457): [#def6]
/usr/lib/dracut/modules.d/11fips/module-setup.sh:49:33: warning[SC2154]: hostonly_default_device is referenced but not assigned.
#   47|   
#   48|       # with hostonly_default_device fs module for /boot is not installed by default
#   49|->     if [[ ${hostonly-} ]] && [[ $hostonly_default_device == "no" ]]; then
#   50|           _bootfstype=$(find_mp_fstype /boot)
#   51|           if [[ -n $_bootfstype ]]; then

Error: SHELLCHECK_WARNING (CWE-457): [#def7]
/usr/lib/dracut/modules.d/11systemd-cryptsetup/module-setup.sh:59:36: warning[SC2154]: initdir is referenced but not assigned.
#   57|           "$systemdsystemunitdir"/initrd-root-device.target.wants/remote-cryptsetup.target
#   58|   
#   59|->     if [[ ${hostonly-} ]] && [[ -f $initdir/etc/crypttab ]]; then
#   60|           # for each entry in /etc/crypttab check if the key file is backed by a socket unit and if so,
#   61|           # include it along with its corresponding service unit.

Error: SHELLCHECK_WARNING (CWE-457): [#def8]
/usr/lib/dracut/modules.d/11systemd-networkd/module-setup.sh:66:10: warning[SC2154]: systemdnetworkconfdir is referenced but not assigned.
#   64|   
#   65|       inst_simple "$moddir"/99-default.network \
#   66|->         "$systemdnetworkconfdir"/zzzz-dracut-default.network
#   67|   
#   68|       inst_hook cmdline 99 "$moddir"/networkd-config.sh

Error: SHELLCHECK_WARNING (CWE-457): [#def9]
/usr/lib/dracut/modules.d/14watchdog-modules/module-setup.sh:28:17: warning[SC2154]: initdir is referenced but not assigned.
#   26|               IFS=,
#   27|               echo "${!_drivers[*]}"
#   28|->         )\"" > "${initdir}"/etc/cmdline.d/00-watchdog.conf
#   29|       fi
#   30|       return 0

Error: SHELLCHECK_WARNING (CWE-457): [#def10]
/usr/lib/dracut/modules.d/20i18n/module-setup.sh:312:39: warning[SC2154]: i18n_install_all is referenced but not assigned.
#  310|           install_base
#  311|   
#  312|->         if [[ ${hostonly-} ]] && ! [[ ${i18n_install_all} == "yes" ]]; then
#  313|               install_local_i18n || install_all_kbd
#  314|           else

Error: SHELLCHECK_WARNING (CWE-457): [#def11]
/usr/lib/dracut/modules.d/35network-manager/module-setup.sh:81:52: warning[SC2154]: systemdnetworkconfdir is referenced but not assigned.
#   79|               "${systemdnetwork}/99-default.link" \
#   80|               "${systemdnetwork}/98-default-mac-none.link"
#   81|->         [[ ${hostonly-} ]] && inst_multiple -H -o "${systemdnetworkconfdir}/*.link"
#   82|       fi
#   83|   

Error: SHELLCHECK_WARNING (CWE-457): [#def12]
/usr/lib/dracut/modules.d/40network/module-setup.sh:22:38: warning[SC2154]: omit_dracutmodules is referenced but not assigned.
#   20|           # install the first viable module, unless there omitted
#   21|           module_check $module > /dev/null 2>&1
#   22|->         if [[ $? == 255 ]] && ! [[ " $omit_dracutmodules " == *\ $module\ * ]] && check_module "$module"; then
#   23|               echo "$module"
#   24|               return 0

Error: SHELLCHECK_WARNING (CWE-457): [#def13]
/usr/lib/dracut/modules.d/45plymouth/module-setup.sh:36:12: warning[SC2154]: moddir is referenced but not assigned.
#   34|           || [ ! -x "${dracutsysrootdir-}${PKGLIBDIR}"/plymouth-populate-initrd ]; then
#   35|           # shellcheck disable=SC1090
#   36|->         . "$moddir"/plymouth-populate-initrd.sh
#   37|       else
#   38|           PLYMOUTH_POPULATE_SOURCE_FUNCTIONS="$dracutfunctions" \

Error: SHELLCHECK_WARNING (CWE-457): [#def14]
/usr/lib/dracut/modules.d/45plymouth/plymouth-populate-initrd.sh:11:19: warning[SC2154]: initdir is referenced but not assigned.
#    9|   
#   10|   # shellcheck disable=SC2174
#   11|-> mkdir -m 0755 -p "${initdir}/usr/share/plymouth"
#   12|   
#   13|   inst_libdir_file "plymouth/text.so" "plymouth/details.so"

Error: SHELLCHECK_WARNING (CWE-457): [#def15]
/usr/lib/dracut/modules.d/70btrfs/module-setup.sh:35:35: warning[SC2154]: initdir is referenced but not assigned.
#   33|   installkernel() {
#   34|       hostonly='' instmods btrfs
#   35|->     printf "%s\n" "$(cmdline)" > "${initdir}/etc/cmdline.d/00-btrfs.conf"
#   36|   }
#   37|   

Error: SHELLCHECK_WARNING (CWE-457): [#def16]
/usr/lib/dracut/modules.d/70crypt/module-setup.sh:84:62: warning[SC2154]: initdir is referenced but not assigned.
#   82|           local _cryptconf
#   83|           _cryptconf=$(cmdline)
#   84|->         [[ $_cryptconf ]] && printf "%s\n" "$_cryptconf" >> "${initdir}/etc/cmdline.d/90crypt.conf"
#   85|       fi
#   86|   

Error: SHELLCHECK_WARNING (CWE-457): [#def17]
/usr/lib/dracut/modules.d/70dmraid/module-setup.sh:71:60: warning[SC2154]: initdir is referenced but not assigned.
#   69|       if [[ $hostonly_cmdline == "yes" ]]; then
#   70|           _raidconf=$(cmdline)
#   71|->         [[ $_raidconf ]] && printf "%s\n" "$_raidconf" >> "${initdir}/etc/cmdline.d/90dmraid.conf"
#   72|       fi
#   73|   

Error: SHELLCHECK_WARNING (CWE-457): [#def18]
/usr/lib/dracut/modules.d/70lvm/module-setup.sh:56:58: warning[SC2154]: initdir is referenced but not assigned.
#   54|           local _lvmconf
#   55|           _lvmconf=$(cmdline)
#   56|->         [[ $_lvmconf ]] && printf "%s\n" "$_lvmconf" >> "${initdir}/etc/cmdline.d/90lvm.conf"
#   57|       fi
#   58|   

Error: SHELLCHECK_WARNING (CWE-457): [#def19]
/usr/lib/dracut/modules.d/70lvm/module-setup.sh:61:33: warning[SC2154]: lvmconf is referenced but not assigned (did you mean '_lvmconf'?).
#   59|       inst_rules "$moddir/64-lvm.rules"
#   60|   
#   61|->     if [[ ${hostonly-} ]] || [[ $lvmconf == "yes" ]]; then
#   62|           if [[ -f "${dracutsysrootdir-}/etc/lvm/lvm.conf" ]]; then
#   63|               inst_simple -H /etc/lvm/lvm.conf

Error: SHELLCHECK_WARNING (CWE-457): [#def20]
/usr/lib/dracut/modules.d/70mdraid/module-setup.sh:76:60: warning[SC2154]: initdir is referenced but not assigned.
#   74|           local _raidconf
#   75|           _raidconf=$(cmdline)
#   76|->         [[ $_raidconf ]] && printf "%s\n" "$_raidconf" >> "${initdir}/etc/cmdline.d/90mdraid.conf"
#   77|       fi
#   78|   

Error: SHELLCHECK_WARNING (CWE-457): [#def21]
/usr/lib/dracut/modules.d/70mdraid/module-setup.sh:94:33: warning[SC2154]: mdadmconf is referenced but not assigned.
#   92|       inst_rules "$moddir/59-persistent-storage-md.rules"
#   93|   
#   94|->     if [[ ${hostonly-} ]] || [[ $mdadmconf == "yes" ]]; then
#   95|           if [[ -f "${dracutsysrootdir-}/etc/mdadm.conf" ]]; then
#   96|               inst -H /etc/mdadm.conf

Error: SHELLCHECK_WARNING (CWE-457): [#def22]
/usr/lib/dracut/modules.d/70multipath/module-setup.sh:114:37: warning[SC2154]: hostonly_mode is referenced but not assigned.
#  112|   
#  113|       mpathconf_installed \
#  114|->         && [[ ${hostonly-} ]] && [[ $hostonly_mode == "strict" ]] && {
#  115|           for_each_host_dev_and_slaves_all add_hostonly_mpath_conf
#  116|           if ((${#_allow[@]} > 0)); then

Error: SHELLCHECK_WARNING (CWE-457): [#def23]
/usr/lib/dracut/modules.d/70ppcmac/module-setup.sh:36:15: warning[SC2154]: hostonly_mode is referenced but not assigned.
#   34|       # only PowerMac3,6 has a module, special case
#   35|       if [[ ${DRACUT_ARCH:-$(uname -m)} != ppc64* ]]; then
#   36|->         if [[ $hostonly_mode != "strict" ]] || [[ ${hostonly-} && "$(pmac_model)" == "PowerMac3,6" ]]; then
#   37|               hostonly=$(optional_hostonly) instmods therm_windtunnel
#   38|           fi

Error: SHELLCHECK_WARNING (CWE-457): [#def24]
/usr/lib/dracut/modules.d/73pcsc/module-setup.sh:39:31: warning[SC2154]: initdir is referenced but not assigned.
#   37|           pcscd.service \
#   38|           pcscd.socket; do
#   39|->         $SYSTEMCTL -q --root "$initdir" enable "$i"
#   40|       done
#   41|   

Error: SHELLCHECK_WARNING (CWE-457): [#def25]
/usr/lib/dracut/modules.d/74iscsi/module-setup.sh:204:62: warning[SC2154]: initdir is referenced but not assigned.
#  202|           local _iscsiconf
#  203|           _iscsiconf=$(cmdline)
#  204|->         [[ $_iscsiconf ]] && printf "%s\n" "$_iscsiconf" >> "${initdir}/etc/cmdline.d/95iscsi.conf"
#  205|       fi
#  206|   

Error: SHELLCHECK_WARNING (CWE-457): [#def26]
/usr/lib/dracut/modules.d/74lunmask/module-setup.sh:66:43: warning[SC2154]: initdir is referenced but not assigned.
#   64|   
#   65|           for _lunmask in $(cmdline); do
#   66|->             printf "%s\n" "$_lunmask" >> "${initdir}/etc/cmdline.d/95lunmask.conf"
#   67|           done
#   68|       fi

Error: SHELLCHECK_WARNING (CWE-457): [#def27]
/usr/lib/dracut/modules.d/74nfs/module-setup.sh:87:58: warning[SC2154]: initdir is referenced but not assigned.
#   85|           local _netconf
#   86|           _netconf="$(cmdline)"
#   87|->         [[ $_netconf ]] && printf "%s\n" "$_netconf" >> "${initdir}/etc/cmdline.d/95nfs.conf"
#   88|       fi
#   89|   

Error: SHELLCHECK_WARNING (CWE-457): [#def28]
/usr/lib/dracut/modules.d/74nvmf/module-setup.sh:143:62: warning[SC2154]: initdir is referenced but not assigned.
#  141|           local _nvmf_args
#  142|           _nvmf_args=$(cmdline)
#  143|->         [[ "$_nvmf_args" ]] && printf "%s" "$_nvmf_args" >> "${initdir}/etc/cmdline.d/95nvmf-args.conf"
#  144|       fi
#  145|       inst_simple -H "/etc/nvme/hostnqn"

Error: SHELLCHECK_WARNING (CWE-457): [#def29]
/usr/lib/dracut/modules.d/74resume/module-setup.sh:66:64: warning[SC2154]: initdir is referenced but not assigned.
#   64|       if [[ $hostonly_cmdline == "yes" ]]; then
#   65|           _resumeconf=$(cmdline)
#   66|->         [[ $_resumeconf ]] && printf "%s\n" "$_resumeconf" >> "${initdir}/etc/cmdline.d/95resume.conf"
#   67|       fi
#   68|   

Error: SHELLCHECK_WARNING (CWE-457): [#def30]
/usr/lib/dracut/modules.d/74rootfs-block/module-setup.sh:70:64: warning[SC2154]: initdir is referenced but not assigned.
#   68|           local _journaldev
#   69|           _journaldev=$(cmdline_journal)
#   70|->         [[ $_journaldev ]] && printf "%s\n" "$_journaldev" >> "${initdir}/etc/cmdline.d/95root-journaldev.conf"
#   71|           local _rootdev
#   72|           _rootdev=$(cmdline_rootfs)

Error: SHELLCHECK_WARNING (CWE-457): [#def31]
/usr/lib/dracut/modules.d/77initqueue/module-setup.sh:17:31: warning[SC2154]: initdir is referenced but not assigned.
#   15|           inst_script "$moddir/dracut-initqueue.sh" /usr/bin/dracut-initqueue
#   16|           inst_simple "$moddir/dracut-initqueue.service" "$systemdsystemunitdir/dracut-initqueue.service"
#   17|->         $SYSTEMCTL -q --root "$initdir" add-wants initrd.target dracut-initqueue.service
#   18|       fi
#   19|   

Error: SHELLCHECK_WARNING (CWE-457): [#def32]
/usr/lib/dracut/modules.d/80base/init.sh:150:21: warning[SC2154]: systemdutildir is referenced but not assigned.
#  148|   
#  149|   # start up udev and trigger cold plugs
#  150|-> UDEV_LOG=$UDEV_LOG "$systemdutildir"/systemd-udevd --daemon --resolve-names=never
#  151|   
#  152|   UDEV_QUEUE_EMPTY="udevadm settle --timeout=0"

Scan Properties