Fixed findings

List of Findings

Error: COMPILER_WARNING: [#def1]
cracklib-2.9.11/lib/fascist.c: scope_hint: In function ‘GTry’
cracklib-2.9.11/lib/fascist.c:434:1: warning[-Wold-style-definition]: old-style function definition
#  434 | GTry(rawtext, password)
#      | ^~~~
#  432|   
#  433|   int
#  434|-> GTry(rawtext, password)
#  435|       char *rawtext;
#  436|       char *password;

Error: COMPILER_WARNING: [#def2]
cracklib-2.9.11/lib/fascist.c:434:1: warning[-Wold-style-definition]: old-style function definition
#  432|   
#  433|   int
#  434|-> GTry(rawtext, password)
#  435|       char *rawtext;
#  436|       char *password;

Error: COMPILER_WARNING: [#def3]
cracklib-2.9.11/lib/fascist.c: scope_hint: In function ‘FascistGecos’
cracklib-2.9.11/lib/fascist.c:648:1: warning[-Wold-style-definition]: old-style function definition
#  648 | FascistGecos(password, uid)
#      | ^~~~~~~~~~~~
#  646|   
#  647|   char *
#  648|-> FascistGecos(password, uid)
#  649|       char *password;
#  650|       int uid;

Error: COMPILER_WARNING: [#def4]
cracklib-2.9.11/lib/fascist.c:648:1: warning[-Wold-style-definition]: old-style function definition
#  646|   
#  647|   char *
#  648|-> FascistGecos(password, uid)
#  649|       char *password;
#  650|       int uid;

Error: COMPILER_WARNING (CWE-563): [#def5]
cracklib-2.9.11/lib/fascist.c: scope_hint: In function ‘FascistLookUser’
cracklib-2.9.11/lib/fascist.c:714:11: warning[-Wunused-variable]: unused variable ‘maxrepeat’
#  714 |     int i,maxrepeat;
#      |           ^~~~~~~~~
#  712|   		const char *user, const char *gecos)
#  713|   {
#  714|->     int i,maxrepeat;
#  715|       char *ptr;
#  716|       char *jptr;

Error: COMPILER_WARNING: [#def6]
cracklib-2.9.11/lib/fascist.c: scope_hint: In function ‘FascistLook’
cracklib-2.9.11/lib/fascist.c:865:1: warning[-Wold-style-definition]: old-style function definition
#  865 | FascistLook(pwp, instring)
#      | ^~~~~~~~~~~
#  863|   
#  864|   char *
#  865|-> FascistLook(pwp, instring)
#  866|       PWDICT *pwp;
#  867|       char *instring;

Error: COMPILER_WARNING: [#def7]
cracklib-2.9.11/lib/fascist.c:865:1: warning[-Wold-style-definition]: old-style function definition
#  863|   
#  864|   char *
#  865|-> FascistLook(pwp, instring)
#  866|       PWDICT *pwp;
#  867|       char *instring;

Error: COMPILER_WARNING: [#def8]
cracklib-2.9.11/lib/fascist.c: scope_hint: In function ‘FascistCheckUser’
cracklib-2.9.11/lib/fascist.c:873:1: warning[-Wold-style-definition]: old-style function definition
#  873 | FascistCheckUser(password, path, user, gecos)
#      | ^~~~~~~~~~~~~~~~
#  871|   
#  872|   const char *
#  873|-> FascistCheckUser(password, path, user, gecos)
#  874|       const char *password;
#  875|       const char *path;

Error: COMPILER_WARNING: [#def9]
cracklib-2.9.11/lib/fascist.c:873:1: warning[-Wold-style-definition]: old-style function definition
#  871|   
#  872|   const char *
#  873|-> FascistCheckUser(password, path, user, gecos)
#  874|       const char *password;
#  875|       const char *path;

Error: COMPILER_WARNING: [#def10]
cracklib-2.9.11/lib/fascist.c: scope_hint: In function ‘FascistCheck’
cracklib-2.9.11/lib/fascist.c:915:1: warning[-Wold-style-definition]: old-style function definition
#  915 | FascistCheck(password, path)
#      | ^~~~~~~~~~~~
#  913|   
#  914|   const char *
#  915|-> FascistCheck(password, path)
#  916|       const char *password;
#  917|       const char *path;

Error: COMPILER_WARNING: [#def11]
cracklib-2.9.11/lib/fascist.c:915:1: warning[-Wold-style-definition]: old-style function definition
#  913|   
#  914|   const char *
#  915|-> FascistCheck(password, path)
#  916|       const char *password;
#  917|       const char *path;

Error: COMPILER_WARNING: [#def12]
cracklib-2.9.11/lib/packlib.c: scope_hint: In function ‘PWOpen’
cracklib-2.9.11/lib/packlib.c:63:1: warning[-Wold-style-definition]: old-style function definition
#   63 | PWOpen(prefix, mode)
#      | ^~~~~~
#   61|   
#   62|   PWDICT *
#   63|-> PWOpen(prefix, mode)
#   64|       const char *prefix;
#   65|       char *mode;

Error: COMPILER_WARNING: [#def13]
cracklib-2.9.11/lib/packlib.c:63:1: warning[-Wold-style-definition]: old-style function definition
#   61|   
#   62|   PWDICT *
#   63|-> PWOpen(prefix, mode)
#   64|       const char *prefix;
#   65|       char *mode;

Error: GCC_ANALYZER_WARNING (CWE-775): [#def14]
cracklib-2.9.11/lib/packlib.c:77:13: warning[-Wanalyzer-file-leak]: leak of FILE ‘ifp’
cracklib-2.9.11/lib/packlib.c:78:8: branch_false: following ‘false’ branch (when ‘pdesc’ is non-NULL)...
cracklib-2.9.11/lib/packlib.c:81:5: branch_false: ...to here
cracklib-2.9.11/lib/packlib.c:88:8: branch_true: following ‘true’ branch...
cracklib-2.9.11/lib/packlib.c:90:17: branch_true: ...to here
cracklib-2.9.11/lib/packlib.c:92:20: branch_true: following ‘true’ branch...
cracklib-2.9.11/lib/packlib.c:95:25: branch_true: ...to here
cracklib-2.9.11/lib/packlib.c:98:28: branch_false: following ‘false’ branch...
cracklib-2.9.11/lib/packlib.c:123:24: branch_false: ...to here
cracklib-2.9.11/lib/packlib.c:123:24: acquire_resource: opened here
cracklib-2.9.11/lib/packlib.c:123:8: branch_false: following ‘false’ branch...
cracklib-2.9.11/lib/packlib.c:136:23: branch_false: ...to here
cracklib-2.9.11/lib/packlib.c:145:8: branch_false: following ‘false’ branch...
cracklib-2.9.11/lib/packlib.c:155:9: branch_false: ...to here
cracklib-2.9.11/lib/packlib.c:157:12: branch_false: following ‘false’ branch...
cracklib-2.9.11/lib/packlib.c:176:14: branch_false: ...to here
cracklib-2.9.11/lib/packlib.c:176:12: branch_false: following ‘false’ branch...
cracklib-2.9.11/lib/packlib.c:225:12: branch_false: following ‘false’ branch...
cracklib-2.9.11/lib/packlib.c:245:13: branch_false: ...to here
cracklib-2.9.11/lib/packlib.c:245:12: branch_false: following ‘false’ branch...
cracklib-2.9.11/lib/packlib.c:264:13: branch_false: ...to here
cracklib-2.9.11/lib/packlib.c:264:12: branch_false: following ‘false’ branch...
cracklib-2.9.11/lib/packlib.c:283:13: branch_false: ...to here
cracklib-2.9.11/lib/packlib.c:283:12: branch_false: following ‘false’ branch...
cracklib-2.9.11/lib/packlib.c:79:16: branch_false: ...to here
cracklib-2.9.11/lib/packlib.c:77:13: danger: ‘ifp’ leaks here; was opened at [(9)](sarif:/runs/0/results/5/codeFlows/0/threadFlows/0/locations/8)
#   75|       void *wfp;
#   76|   
#   77|->     pdesc = malloc(sizeof(*pdesc));
#   78|       if (pdesc == NULL)
#   79|   	return NULL;

Error: GCC_ANALYZER_WARNING (CWE-401): [#def15]
cracklib-2.9.11/lib/packlib.c:77:13: warning[-Wanalyzer-malloc-leak]: leak of ‘ifp’
cracklib-2.9.11/lib/packlib.c:78:8: branch_false: following ‘false’ branch (when ‘pdesc’ is non-NULL)...
cracklib-2.9.11/lib/packlib.c:81:5: branch_false: ...to here
cracklib-2.9.11/lib/packlib.c:88:8: branch_true: following ‘true’ branch...
cracklib-2.9.11/lib/packlib.c:90:17: branch_true: ...to here
cracklib-2.9.11/lib/packlib.c:92:20: branch_true: following ‘true’ branch...
cracklib-2.9.11/lib/packlib.c:95:25: branch_true: ...to here
cracklib-2.9.11/lib/packlib.c:98:28: branch_false: following ‘false’ branch...
cracklib-2.9.11/lib/packlib.c:123:24: branch_false: ...to here
cracklib-2.9.11/lib/packlib.c:123:24: acquire_memory: allocated here
cracklib-2.9.11/lib/packlib.c:123:8: branch_false: following ‘false’ branch...
cracklib-2.9.11/lib/packlib.c:136:23: branch_false: ...to here
cracklib-2.9.11/lib/packlib.c:145:8: branch_false: following ‘false’ branch...
cracklib-2.9.11/lib/packlib.c:155:9: branch_false: ...to here
cracklib-2.9.11/lib/packlib.c:157:12: branch_false: following ‘false’ branch...
cracklib-2.9.11/lib/packlib.c:176:14: branch_false: ...to here
cracklib-2.9.11/lib/packlib.c:176:12: branch_false: following ‘false’ branch...
cracklib-2.9.11/lib/packlib.c:225:12: branch_false: following ‘false’ branch...
cracklib-2.9.11/lib/packlib.c:245:13: branch_false: ...to here
cracklib-2.9.11/lib/packlib.c:245:12: branch_false: following ‘false’ branch...
cracklib-2.9.11/lib/packlib.c:264:13: branch_false: ...to here
cracklib-2.9.11/lib/packlib.c:264:12: branch_false: following ‘false’ branch...
cracklib-2.9.11/lib/packlib.c:283:13: branch_false: ...to here
cracklib-2.9.11/lib/packlib.c:283:12: branch_false: following ‘false’ branch...
cracklib-2.9.11/lib/packlib.c:79:16: branch_false: ...to here
cracklib-2.9.11/lib/packlib.c:77:13: danger: ‘ifp’ leaks here; was allocated at [(9)](sarif:/runs/0/results/6/codeFlows/0/threadFlows/0/locations/8)
#   75|       void *wfp;
#   76|   
#   77|->     pdesc = malloc(sizeof(*pdesc));
#   78|       if (pdesc == NULL)
#   79|   	return NULL;

Error: GCC_ANALYZER_WARNING (CWE-775): [#def16]
cracklib-2.9.11/lib/packlib.c:138:9: warning[-Wanalyzer-file-leak]: leak of FILE ‘fopen(&wname,  mode)’
cracklib-2.9.11/lib/packlib.c:78:8: branch_false: following ‘false’ branch (when ‘pdesc’ is non-NULL)...
cracklib-2.9.11/lib/packlib.c:81:5: branch_false: ...to here
cracklib-2.9.11/lib/packlib.c:88:8: branch_true: following ‘true’ branch...
cracklib-2.9.11/lib/packlib.c:90:17: branch_true: ...to here
cracklib-2.9.11/lib/packlib.c:92:20: branch_false: following ‘false’ branch...
cracklib-2.9.11/lib/packlib.c:123:24: branch_false: ...to here
cracklib-2.9.11/lib/packlib.c:123:8: branch_false: following ‘false’ branch...
cracklib-2.9.11/lib/packlib.c:136:23: branch_false: ...to here
cracklib-2.9.11/lib/packlib.c:136:23: acquire_resource: opened here
cracklib-2.9.11/lib/packlib.c:136:8: branch_true: following ‘true’ branch...
cracklib-2.9.11/lib/packlib.c:138:9: branch_true: ...to here
cracklib-2.9.11/lib/packlib.c:145:8: branch_false: following ‘false’ branch...
cracklib-2.9.11/lib/packlib.c:155:9: branch_false: ...to here
cracklib-2.9.11/lib/packlib.c:157:12: branch_false: following ‘false’ branch...
cracklib-2.9.11/lib/packlib.c:176:14: branch_false: ...to here
cracklib-2.9.11/lib/packlib.c:176:12: branch_false: following ‘false’ branch...
cracklib-2.9.11/lib/packlib.c:225:12: branch_false: following ‘false’ branch...
cracklib-2.9.11/lib/packlib.c:245:13: branch_false: ...to here
cracklib-2.9.11/lib/packlib.c:245:12: branch_false: following ‘false’ branch...
cracklib-2.9.11/lib/packlib.c:264:13: branch_false: ...to here
cracklib-2.9.11/lib/packlib.c:264:12: branch_false: following ‘false’ branch...
cracklib-2.9.11/lib/packlib.c:283:13: branch_false: ...to here
cracklib-2.9.11/lib/packlib.c:138:9: danger: ‘fopen(&wname,  mode)’ leaks here; was opened at [(9)](sarif:/runs/0/results/7/codeFlows/0/threadFlows/0/locations/8)
#  136|       if ((pdesc->wfp = fopen(wname, mode)))
#  137|       {
#  138|-> 	pdesc->flags |= PFOR_USEHWMS;
#  139|       }
#  140|   

Error: GCC_ANALYZER_WARNING (CWE-401): [#def17]
cracklib-2.9.11/lib/packlib.c:138:9: warning[-Wanalyzer-malloc-leak]: leak of ‘fopen(&wname,  mode)’
cracklib-2.9.11/lib/packlib.c:78:8: branch_false: following ‘false’ branch (when ‘pdesc’ is non-NULL)...
cracklib-2.9.11/lib/packlib.c:81:5: branch_false: ...to here
cracklib-2.9.11/lib/packlib.c:88:8: branch_true: following ‘true’ branch...
cracklib-2.9.11/lib/packlib.c:90:17: branch_true: ...to here
cracklib-2.9.11/lib/packlib.c:92:20: branch_false: following ‘false’ branch...
cracklib-2.9.11/lib/packlib.c:123:24: branch_false: ...to here
cracklib-2.9.11/lib/packlib.c:123:8: branch_false: following ‘false’ branch...
cracklib-2.9.11/lib/packlib.c:136:23: branch_false: ...to here
cracklib-2.9.11/lib/packlib.c:136:23: acquire_memory: allocated here
cracklib-2.9.11/lib/packlib.c:136:8: branch_true: following ‘true’ branch...
cracklib-2.9.11/lib/packlib.c:138:9: branch_true: ...to here
cracklib-2.9.11/lib/packlib.c:145:8: branch_false: following ‘false’ branch...
cracklib-2.9.11/lib/packlib.c:155:9: branch_false: ...to here
cracklib-2.9.11/lib/packlib.c:157:12: branch_false: following ‘false’ branch...
cracklib-2.9.11/lib/packlib.c:176:14: branch_false: ...to here
cracklib-2.9.11/lib/packlib.c:176:12: branch_false: following ‘false’ branch...
cracklib-2.9.11/lib/packlib.c:225:12: branch_false: following ‘false’ branch...
cracklib-2.9.11/lib/packlib.c:245:13: branch_false: ...to here
cracklib-2.9.11/lib/packlib.c:245:12: branch_false: following ‘false’ branch...
cracklib-2.9.11/lib/packlib.c:264:13: branch_false: ...to here
cracklib-2.9.11/lib/packlib.c:264:12: branch_false: following ‘false’ branch...
cracklib-2.9.11/lib/packlib.c:283:13: branch_false: ...to here
cracklib-2.9.11/lib/packlib.c:138:9: danger: ‘fopen(&wname,  mode)’ leaks here; was allocated at [(9)](sarif:/runs/0/results/8/codeFlows/0/threadFlows/0/locations/8)
#  136|       if ((pdesc->wfp = fopen(wname, mode)))
#  137|       {
#  138|-> 	pdesc->flags |= PFOR_USEHWMS;
#  139|       }
#  140|   

Error: GCC_ANALYZER_WARNING (CWE-688): [#def18]
cracklib-2.9.11/lib/packlib.c:289:21: warning[-Wanalyzer-null-argument]: use of NULL ‘fopen(&wname,  mode)’ where non-null expected
cracklib-2.9.11/lib/packlib.c:78:8: branch_false: following ‘false’ branch (when ‘pdesc’ is non-NULL)...
cracklib-2.9.11/lib/packlib.c:81:5: branch_false: ...to here
cracklib-2.9.11/lib/packlib.c:88:8: branch_true: following ‘true’ branch...
cracklib-2.9.11/lib/packlib.c:90:17: branch_true: ...to here
cracklib-2.9.11/lib/packlib.c:92:20: branch_true: following ‘true’ branch...
cracklib-2.9.11/lib/packlib.c:95:25: branch_true: ...to here
cracklib-2.9.11/lib/packlib.c:98:28: branch_false: following ‘false’ branch...
cracklib-2.9.11/lib/packlib.c:123:24: branch_false: ...to here
cracklib-2.9.11/lib/packlib.c:123:8: branch_false: following ‘false’ branch...
cracklib-2.9.11/lib/packlib.c:136:23: branch_false: ...to here
cracklib-2.9.11/lib/packlib.c:136:23: acquire_memory: allocated here
cracklib-2.9.11/lib/packlib.c:136:8: release_memory: assuming ‘fopen(&wname,  mode)’ is NULL
cracklib-2.9.11/lib/packlib.c:136:8: branch_false: following ‘false’ branch...
cracklib-2.9.11/lib/packlib.c:141:5: branch_false: ...to here
cracklib-2.9.11/lib/packlib.c:145:8: branch_false: following ‘false’ branch...
cracklib-2.9.11/lib/packlib.c:155:9: branch_false: ...to here
cracklib-2.9.11/lib/packlib.c:157:12: branch_false: following ‘false’ branch...
cracklib-2.9.11/lib/packlib.c:176:14: branch_false: ...to here
cracklib-2.9.11/lib/packlib.c:180:16: branch_false: following ‘false’ branch...
cracklib-2.9.11/lib/packlib.c:198:17: branch_false: ...to here
cracklib-2.9.11/lib/packlib.c:198:16: branch_false: following ‘false’ branch...
cracklib-2.9.11/lib/packlib.c:218:13: branch_false: ...to here
cracklib-2.9.11/lib/packlib.c:225:12: branch_false: following ‘false’ branch...
cracklib-2.9.11/lib/packlib.c:245:13: branch_false: ...to here
cracklib-2.9.11/lib/packlib.c:245:12: branch_false: following ‘false’ branch...
cracklib-2.9.11/lib/packlib.c:264:13: branch_false: ...to here
cracklib-2.9.11/lib/packlib.c:264:12: branch_false: following ‘false’ branch...
cracklib-2.9.11/lib/packlib.c:283:13: branch_false: ...to here
cracklib-2.9.11/lib/packlib.c:283:12: branch_true: following ‘true’ branch...
cracklib-2.9.11/lib/packlib.c:287:16: branch_true: ...to here
cracklib-2.9.11/lib/packlib.c:287:16: branch_true: following ‘true’ branch (when ‘use64 != 0’)...
cracklib-2.9.11/lib/packlib.c:289:21: branch_true: ...to here
cracklib-2.9.11/lib/packlib.c:289:21: danger: argument 4 (‘fopen(&wname,  mode)’) NULL where non-null expected
#  287|               if (use64)
#  288|               {
#  289|->                 if (fread(pdesc64.hwms, 1, sizeof(pdesc64.hwms), wfp) != sizeof(pdesc64.hwms))
#  290|                   {
#  291|                       pdesc->flags &= ~PFOR_USEHWMS;

Error: GCC_ANALYZER_WARNING (CWE-688): [#def19]
cracklib-2.9.11/lib/packlib.c:298:22: warning[-Wanalyzer-null-argument]: use of NULL ‘fopen(&wname,  mode)’ where non-null expected
cracklib-2.9.11/lib/packlib.c:78:8: branch_false: following ‘false’ branch (when ‘pdesc’ is non-NULL)...
cracklib-2.9.11/lib/packlib.c:81:5: branch_false: ...to here
cracklib-2.9.11/lib/packlib.c:88:8: branch_true: following ‘true’ branch...
cracklib-2.9.11/lib/packlib.c:90:17: branch_true: ...to here
cracklib-2.9.11/lib/packlib.c:92:20: branch_false: following ‘false’ branch...
cracklib-2.9.11/lib/packlib.c:123:24: branch_false: ...to here
cracklib-2.9.11/lib/packlib.c:123:8: branch_false: following ‘false’ branch...
cracklib-2.9.11/lib/packlib.c:136:23: branch_false: ...to here
cracklib-2.9.11/lib/packlib.c:136:23: acquire_memory: allocated here
cracklib-2.9.11/lib/packlib.c:136:8: release_memory: assuming ‘fopen(&wname,  mode)’ is NULL
cracklib-2.9.11/lib/packlib.c:136:8: branch_false: following ‘false’ branch...
cracklib-2.9.11/lib/packlib.c:141:5: branch_false: ...to here
cracklib-2.9.11/lib/packlib.c:145:8: branch_false: following ‘false’ branch...
cracklib-2.9.11/lib/packlib.c:155:9: branch_false: ...to here
cracklib-2.9.11/lib/packlib.c:157:12: branch_false: following ‘false’ branch...
cracklib-2.9.11/lib/packlib.c:176:14: branch_false: ...to here
cracklib-2.9.11/lib/packlib.c:176:12: branch_false: following ‘false’ branch...
cracklib-2.9.11/lib/packlib.c:225:12: branch_false: following ‘false’ branch...
cracklib-2.9.11/lib/packlib.c:245:13: branch_false: ...to here
cracklib-2.9.11/lib/packlib.c:245:12: branch_false: following ‘false’ branch...
cracklib-2.9.11/lib/packlib.c:264:13: branch_false: ...to here
cracklib-2.9.11/lib/packlib.c:264:12: branch_false: following ‘false’ branch...
cracklib-2.9.11/lib/packlib.c:283:13: branch_false: ...to here
cracklib-2.9.11/lib/packlib.c:283:12: branch_true: following ‘true’ branch...
cracklib-2.9.11/lib/packlib.c:287:16: branch_true: ...to here
cracklib-2.9.11/lib/packlib.c:287:16: branch_false: following ‘false’ branch (when ‘use64 == 0’)...
cracklib-2.9.11/lib/packlib.c:298:28: branch_false: ...to here
cracklib-2.9.11/lib/packlib.c:298:22: danger: argument 4 (‘fopen(&wname,  mode)’) NULL where non-null expected
#  296|                   }
#  297|               }
#  298|->             else if (fread(pdesc->hwms, 1, sizeof(pdesc->hwms), wfp) != sizeof(pdesc->hwms))
#  299|   	    {
#  300|   		pdesc->flags &= ~PFOR_USEHWMS;

Error: COMPILER_WARNING: [#def20]
cracklib-2.9.11/lib/packlib.c: scope_hint: In function ‘PWClose’
cracklib-2.9.11/lib/packlib.c:315:1: warning[-Wold-style-definition]: old-style function definition
#  315 | PWClose(pwp)
#      | ^~~~~~~
#  313|   
#  314|   int
#  315|-> PWClose(pwp)
#  316|       PWDICT *pwp;
#  317|   {

Error: COMPILER_WARNING: [#def21]
cracklib-2.9.11/lib/packlib.c:315:1: warning[-Wold-style-definition]: old-style function definition
#  313|   
#  314|   int
#  315|-> PWClose(pwp)
#  316|       PWDICT *pwp;
#  317|   {

Error: COMPILER_WARNING: [#def22]
cracklib-2.9.11/lib/packlib.c: scope_hint: In function ‘PutPW’
cracklib-2.9.11/lib/packlib.c:379:1: warning[-Wold-style-definition]: old-style function definition
#  379 | PutPW(pwp, string)
#      | ^~~~~
#  377|   
#  378|   int
#  379|-> PutPW(pwp, string)
#  380|       PWDICT *pwp;
#  381|       char *string;

Error: COMPILER_WARNING: [#def23]
cracklib-2.9.11/lib/packlib.c:379:1: warning[-Wold-style-definition]: old-style function definition
#  377|   
#  378|   int
#  379|-> PutPW(pwp, string)
#  380|       PWDICT *pwp;
#  381|       char *string;

Error: COMPILER_WARNING: [#def24]
cracklib-2.9.11/lib/packlib.c: scope_hint: In function ‘GetPW’
cracklib-2.9.11/lib/packlib.c:442:1: warning[-Wold-style-definition]: old-style function definition
#  442 | GetPW(pwp, number)
#      | ^~~~~
#  440|   
#  441|   char *
#  442|-> GetPW(pwp, number)
#  443|       PWDICT *pwp;
#  444|       uint32_t number;

Error: COMPILER_WARNING: [#def25]
cracklib-2.9.11/lib/packlib.c:442:1: warning[-Wold-style-definition]: old-style function definition
#  440|   
#  441|   char *
#  442|-> GetPW(pwp, number)
#  443|       PWDICT *pwp;
#  444|       uint32_t number;

Error: COMPILER_WARNING: [#def26]
cracklib-2.9.11/lib/packlib.c: scope_hint: In function ‘FindPW’
cracklib-2.9.11/lib/packlib.c:544:1: warning[-Wold-style-definition]: old-style function definition
#  544 | FindPW(pwp, string)
#      | ^~~~~~
#  542|   
#  543|   unsigned int
#  544|-> FindPW(pwp, string)
#  545|       PWDICT *pwp;
#  546|       char *string;

Error: COMPILER_WARNING: [#def27]
cracklib-2.9.11/lib/packlib.c:544:1: warning[-Wold-style-definition]: old-style function definition
#  542|   
#  543|   unsigned int
#  544|-> FindPW(pwp, string)
#  545|       PWDICT *pwp;
#  546|       char *string;

Error: COMPILER_WARNING: [#def28]
cracklib-2.9.11/lib/rules.c: scope_hint: In function ‘Debug’
cracklib-2.9.11/lib/rules.c:29:1: warning[-Wold-style-definition]: old-style function definition
#   29 | Debug(val, a, b, c, d, e, f, g)
#      | ^~~~~
#   27|   #else
#   28|   static void
#   29|-> Debug(val, a, b, c, d, e, f, g)
#   30|       int val;
#   31|       char *a, *b, *c, *d, *e, *f, *g;

Error: COMPILER_WARNING: [#def29]
cracklib-2.9.11/lib/rules.c:29:1: warning[-Wold-style-definition]: old-style function definition
#   27|   #else
#   28|   static void
#   29|-> Debug(val, a, b, c, d, e, f, g)
#   30|       int val;
#   31|       char *a, *b, *c, *d, *e, *f, *g;

Error: COMPILER_WARNING: [#def30]
cracklib-2.9.11/lib/rules.c: scope_hint: In function ‘Suffix’
cracklib-2.9.11/lib/rules.c:64:1: warning[-Wold-style-definition]: old-style function definition
#   64 | Suffix(myword, suffix)
#      | ^~~~~~
#   62|   
#   63|   int
#   64|-> Suffix(myword, suffix)
#   65|       char *myword;
#   66|       char *suffix;

Error: COMPILER_WARNING: [#def31]
cracklib-2.9.11/lib/rules.c:64:1: warning[-Wold-style-definition]: old-style function definition
#   62|   
#   63|   int
#   64|-> Suffix(myword, suffix)
#   65|       char *myword;
#   66|       char *suffix;

Error: COMPILER_WARNING: [#def32]
cracklib-2.9.11/lib/rules.c: scope_hint: In function ‘Reverse’
cracklib-2.9.11/lib/rules.c:83:1: warning[-Wold-style-definition]: old-style function definition
#   83 | Reverse(str, area)                      /* return a pointer to a reversal */
#      | ^~~~~~~
#   81|   
#   82|   char *
#   83|-> Reverse(str, area)			/* return a pointer to a reversal */
#   84|       char *str;
#   85|       char *area;

Error: COMPILER_WARNING: [#def33]
cracklib-2.9.11/lib/rules.c:83:1: warning[-Wold-style-definition]: old-style function definition
#   81|   
#   82|   char *
#   83|-> Reverse(str, area)			/* return a pointer to a reversal */
#   84|       char *str;
#   85|       char *area;

Error: COMPILER_WARNING: [#def34]
cracklib-2.9.11/lib/rules.c: scope_hint: In function ‘Uppercase’
cracklib-2.9.11/lib/rules.c:99:1: warning[-Wold-style-definition]: old-style function definition
#   99 | Uppercase(str, area)                    /* return a pointer to an uppercase */
#      | ^~~~~~~~~
#   97|   
#   98|   char *
#   99|-> Uppercase(str, area)			/* return a pointer to an uppercase */
#  100|       char *str;
#  101|       char *area;

Error: COMPILER_WARNING: [#def35]
cracklib-2.9.11/lib/rules.c:99:1: warning[-Wold-style-definition]: old-style function definition
#   97|   
#   98|   char *
#   99|-> Uppercase(str, area)			/* return a pointer to an uppercase */
#  100|       char *str;
#  101|       char *area;

Error: COMPILER_WARNING: [#def36]
cracklib-2.9.11/lib/rules.c: scope_hint: In function ‘Lowercase’
cracklib-2.9.11/lib/rules.c:116:1: warning[-Wold-style-definition]: old-style function definition
#  116 | Lowercase(str, area)                    /* return a pointer to an lowercase */
#      | ^~~~~~~~~
#  114|   
#  115|   char *
#  116|-> Lowercase(str, area)			/* return a pointer to an lowercase */
#  117|       char *str;
#  118|       char *area;

Error: COMPILER_WARNING: [#def37]
cracklib-2.9.11/lib/rules.c:116:1: warning[-Wold-style-definition]: old-style function definition
#  114|   
#  115|   char *
#  116|-> Lowercase(str, area)			/* return a pointer to an lowercase */
#  117|       char *str;
#  118|       char *area;

Error: COMPILER_WARNING: [#def38]
cracklib-2.9.11/lib/rules.c: scope_hint: In function ‘Capitalise’
cracklib-2.9.11/lib/rules.c:133:1: warning[-Wold-style-definition]: old-style function definition
#  133 | Capitalise(str, area)                   /* return a pointer to an capitalised */
#      | ^~~~~~~~~~
#  131|   
#  132|   char *
#  133|-> Capitalise(str, area)			/* return a pointer to an capitalised */
#  134|       char *str;
#  135|       char *area;

Error: COMPILER_WARNING: [#def39]
cracklib-2.9.11/lib/rules.c:133:1: warning[-Wold-style-definition]: old-style function definition
#  131|   
#  132|   char *
#  133|-> Capitalise(str, area)			/* return a pointer to an capitalised */
#  134|       char *str;
#  135|       char *area;

Error: COMPILER_WARNING: [#def40]
cracklib-2.9.11/lib/rules.c: scope_hint: In function ‘Pluralise’
cracklib-2.9.11/lib/rules.c:152:1: warning[-Wold-style-definition]: old-style function definition
#  152 | Pluralise(string, area)         /* returns a pointer to a plural */
#      | ^~~~~~~~~
#  150|   
#  151|   char *
#  152|-> Pluralise(string, area)		/* returns a pointer to a plural */
#  153|       char *string;
#  154|       char *area;

Error: COMPILER_WARNING: [#def41]
cracklib-2.9.11/lib/rules.c:152:1: warning[-Wold-style-definition]: old-style function definition
#  150|   
#  151|   char *
#  152|-> Pluralise(string, area)		/* returns a pointer to a plural */
#  153|       char *string;
#  154|       char *area;

Error: COMPILER_WARNING: [#def42]
cracklib-2.9.11/lib/rules.c: scope_hint: In function ‘Substitute’
cracklib-2.9.11/lib/rules.c:193:1: warning[-Wold-style-definition]: old-style function definition
#  193 | Substitute(string, old, new, area)      /* returns pointer to a swapped about copy */
#      | ^~~~~~~~~~
#  191|   
#  192|   char *
#  193|-> Substitute(string, old, new, area)	/* returns pointer to a swapped about copy */
#  194|       char *string;
#  195|       char old;

Error: COMPILER_WARNING: [#def43]
cracklib-2.9.11/lib/rules.c:193:1: warning[-Wold-style-definition]: old-style function definition
#  191|   
#  192|   char *
#  193|-> Substitute(string, old, new, area)	/* returns pointer to a swapped about copy */
#  194|       char *string;
#  195|       char old;

Error: COMPILER_WARNING: [#def44]
cracklib-2.9.11/lib/rules.c: scope_hint: In function ‘Purge’
cracklib-2.9.11/lib/rules.c:211:1: warning[-Wold-style-definition]: old-style function definition
#  211 | Purge(string, target, area)             /* returns pointer to a purged copy */
#      | ^~~~~
#  209|   
#  210|   char *
#  211|-> Purge(string, target, area)		/* returns pointer to a purged copy */
#  212|       char *string;
#  213|       char target;

Error: COMPILER_WARNING: [#def45]
cracklib-2.9.11/lib/rules.c:211:1: warning[-Wold-style-definition]: old-style function definition
#  209|   
#  210|   char *
#  211|-> Purge(string, target, area)		/* returns pointer to a purged copy */
#  212|       char *string;
#  213|       char target;

Error: COMPILER_WARNING: [#def46]
cracklib-2.9.11/lib/rules.c: scope_hint: In function ‘MatchClass’
cracklib-2.9.11/lib/rules.c:238:1: warning[-Wold-style-definition]: old-style function definition
#  238 | MatchClass(class, input)
#      | ^~~~~~~~~~
#  236|   
#  237|   int
#  238|-> MatchClass(class, input)
#  239|       char class;
#  240|       char input;

Error: COMPILER_WARNING: [#def47]
cracklib-2.9.11/lib/rules.c:238:1: warning[-Wold-style-definition]: old-style function definition
#  236|   
#  237|   int
#  238|-> MatchClass(class, input)
#  239|       char class;
#  240|       char input;

Error: COMPILER_WARNING: [#def48]
cracklib-2.9.11/lib/rules.c: scope_hint: In function ‘PolyStrchr’
cracklib-2.9.11/lib/rules.c:357:1: warning[-Wold-style-definition]: old-style function definition
#  357 | PolyStrchr(string, class)
#      | ^~~~~~~~~~
#  355|   
#  356|   char *
#  357|-> PolyStrchr(string, class)
#  358|       char *string;
#  359|       char class;

Error: COMPILER_WARNING: [#def49]
cracklib-2.9.11/lib/rules.c:357:1: warning[-Wold-style-definition]: old-style function definition
#  355|   
#  356|   char *
#  357|-> PolyStrchr(string, class)
#  358|       char *string;
#  359|       char class;

Error: COMPILER_WARNING: [#def50]
cracklib-2.9.11/lib/rules.c: scope_hint: In function ‘PolySubst’
cracklib-2.9.11/lib/rules.c:373:1: warning[-Wold-style-definition]: old-style function definition
#  373 | PolySubst(string, class, new, area)     /* returns pointer to a swapped about copy */
#      | ^~~~~~~~~
#  371|   
#  372|   char *
#  373|-> PolySubst(string, class, new, area)	/* returns pointer to a swapped about copy */
#  374|       char *string;
#  375|       char class;

Error: COMPILER_WARNING: [#def51]
cracklib-2.9.11/lib/rules.c:373:1: warning[-Wold-style-definition]: old-style function definition
#  371|   
#  372|   char *
#  373|-> PolySubst(string, class, new, area)	/* returns pointer to a swapped about copy */
#  374|       char *string;
#  375|       char class;

Error: COMPILER_WARNING: [#def52]
cracklib-2.9.11/lib/rules.c: scope_hint: In function ‘PolyPurge’
cracklib-2.9.11/lib/rules.c:391:1: warning[-Wold-style-definition]: old-style function definition
#  391 | PolyPurge(string, class, area)  /* returns pointer to a purged copy */
#      | ^~~~~~~~~
#  389|   
#  390|   char *
#  391|-> PolyPurge(string, class, area)	/* returns pointer to a purged copy */
#  392|       char *string;
#  393|       char class;

Error: COMPILER_WARNING: [#def53]
cracklib-2.9.11/lib/rules.c:391:1: warning[-Wold-style-definition]: old-style function definition
#  389|   
#  390|   char *
#  391|-> PolyPurge(string, class, area)	/* returns pointer to a purged copy */
#  392|       char *string;
#  393|       char class;

Error: COMPILER_WARNING: [#def54]
cracklib-2.9.11/lib/rules.c: scope_hint: In function ‘Char2Int’
cracklib-2.9.11/lib/rules.c:412:1: warning[-Wold-style-definition]: old-style function definition
#  412 | Char2Int(character)
#      | ^~~~~~~~
#  410|   
#  411|   int
#  412|-> Char2Int(character)
#  413|       char character;
#  414|   {

Error: COMPILER_WARNING: [#def55]
cracklib-2.9.11/lib/rules.c:412:1: warning[-Wold-style-definition]: old-style function definition
#  410|   
#  411|   int
#  412|-> Char2Int(character)
#  413|       char character;
#  414|   {

Error: COMPILER_WARNING: [#def56]
cracklib-2.9.11/lib/rules.c: scope_hint: In function ‘Mangle’
cracklib-2.9.11/lib/rules.c:429:1: warning[-Wold-style-definition]: old-style function definition
#  429 | Mangle(input, control, area)            /* returns a pointer to a controlled Mangle */
#      | ^~~~~~
#  427|   
#  428|   char *
#  429|-> Mangle(input, control, area)		/* returns a pointer to a controlled Mangle */
#  430|       char *input;
#  431|       char *control;

Error: COMPILER_WARNING: [#def57]
cracklib-2.9.11/lib/rules.c:429:1: warning[-Wold-style-definition]: old-style function definition
#  427|   
#  428|   char *
#  429|-> Mangle(input, control, area)		/* returns a pointer to a controlled Mangle */
#  430|       char *input;
#  431|       char *control;

Error: COMPILER_WARNING: [#def58]
cracklib-2.9.11/lib/rules.c: scope_hint: In function ‘PMatch’
cracklib-2.9.11/lib/rules.c:818:1: warning[-Wold-style-definition]: old-style function definition
#  818 | PMatch(control, string)
#      | ^~~~~~
#  816|   
#  817|   int
#  818|-> PMatch(control, string)
#  819|   char *control;
#  820|   char *string;

Error: COMPILER_WARNING: [#def59]
cracklib-2.9.11/lib/rules.c:818:1: warning[-Wold-style-definition]: old-style function definition
#  816|   
#  817|   int
#  818|-> PMatch(control, string)
#  819|   char *control;
#  820|   char *string;

Error: COMPILER_WARNING: [#def60]
cracklib-2.9.11/lib/stringlib.c: scope_hint: In function ‘Chop’
cracklib-2.9.11/lib/stringlib.c:16:1: warning[-Wold-style-definition]: old-style function definition
#   16 | Chop(string)
#      | ^~~~
#   14|   
#   15|   char
#   16|-> Chop(string)
#   17|       register char *string;
#   18|   {

Error: COMPILER_WARNING: [#def61]
cracklib-2.9.11/lib/stringlib.c:16:1: warning[-Wold-style-definition]: old-style function definition
#   14|   
#   15|   char
#   16|-> Chop(string)
#   17|       register char *string;
#   18|   {

Error: COMPILER_WARNING: [#def62]
cracklib-2.9.11/lib/stringlib.c: scope_hint: In function ‘Trim’
cracklib-2.9.11/lib/stringlib.c:33:1: warning[-Wold-style-definition]: old-style function definition
#   33 | Trim(string)
#      | ^~~~
#   31|   
#   32|   char *
#   33|-> Trim(string)
#   34|       register char *string;
#   35|   {

Error: COMPILER_WARNING: [#def63]
cracklib-2.9.11/lib/stringlib.c:33:1: warning[-Wold-style-definition]: old-style function definition
#   31|   
#   32|   char *
#   33|-> Trim(string)
#   34|       register char *string;
#   35|   {

Error: COMPILER_WARNING: [#def64]
cracklib-2.9.11/lib/stringlib.c: scope_hint: In function ‘Clone’
cracklib-2.9.11/lib/stringlib.c:47:1: warning[-Wold-style-definition]: old-style function definition
#   47 | Clone(string)
#      | ^~~~~
#   45|   
#   46|   char *
#   47|-> Clone(string)
#   48|       char *string;
#   49|   {

Error: COMPILER_WARNING: [#def65]
cracklib-2.9.11/lib/stringlib.c:47:1: warning[-Wold-style-definition]: old-style function definition
#   45|   
#   46|   char *
#   47|-> Clone(string)
#   48|       char *string;
#   49|   {

Error: COMPILER_WARNING: [#def66]
cracklib-2.9.11/util/packer.c: scope_hint: In function ‘main’
cracklib-2.9.11/util/packer.c:16:1: warning[-Wold-style-definition]: old-style function definition
#   16 | main(argc, argv)
#      | ^~~~
#   14|   
#   15|   int
#   16|-> main(argc, argv)
#   17|       int argc;
#   18|       char *argv[];

Error: COMPILER_WARNING: [#def67]
cracklib-2.9.11/util/packer.c:16:1: warning[-Wold-style-definition]: old-style function definition
#   14|   
#   15|   int
#   16|-> main(argc, argv)
#   17|       int argc;
#   18|       char *argv[];

Error: COMPILER_WARNING: [#def68]
cracklib-2.9.11/util/unpacker.c: scope_hint: In function ‘main’
cracklib-2.9.11/util/unpacker.c:15:1: warning[-Wold-style-definition]: old-style function definition
#   15 | main(argc, argv)
#      | ^~~~
#   13|   
#   14|   int
#   15|-> main(argc, argv)
#   16|       int argc;
#   17|       char *argv[];

Error: COMPILER_WARNING: [#def69]
cracklib-2.9.11/util/unpacker.c:15:1: warning[-Wold-style-definition]: old-style function definition
#   13|   
#   14|   int
#   15|-> main(argc, argv)
#   16|       int argc;
#   17|       char *argv[];

Scan Properties

analyzer-version-clippy1.95.0
analyzer-version-cppcheck2.20.0
analyzer-version-gcc16.1.1
analyzer-version-gcc-analyzer16.1.1
analyzer-version-shellcheck0.11.0
analyzer-version-unicontrol0.0.2
diffbase-analyzer-version-clippy1.95.0
diffbase-analyzer-version-cppcheck2.20.0
diffbase-analyzer-version-gcc16.1.1
diffbase-analyzer-version-gcc-analyzer16.1.1
diffbase-analyzer-version-shellcheck0.11.0
diffbase-analyzer-version-unicontrol0.0.2
diffbase-enabled-pluginsclippy, cppcheck, gcc, shellcheck, unicontrol
diffbase-exit-code0
diffbase-hostip-172-16-1-130.us-west-2.compute.internal
diffbase-known-false-positives/usr/share/csmock/known-false-positives.js
diffbase-known-false-positives-rpmknown-false-positives-0.0.0.20260524.213755.g3c6d0be.main-1.el9.noarch
diffbase-mock-configfedora-rawhide-x86_64
diffbase-project-namecracklib-2.10.3-1.fc45
diffbase-store-results-to/tmp/tmprfixrv9v/cracklib-2.10.3-1.fc45.tar.xz
diffbase-time-created2026-06-01 11:41:49
diffbase-time-finished2026-06-01 11:42:54
diffbase-toolcsmock
diffbase-tool-args'/usr/bin/csmock' '-r' 'fedora-rawhide-x86_64' '-t' 'shellcheck,cppcheck,clippy,unicontrol,gcc' '-o' '/tmp/tmprfixrv9v/cracklib-2.10.3-1.fc45.tar.xz' '--gcc-analyze' '--unicontrol-notests' '--unicontrol-bidi-only' '--install' 'pam' '--gcc-analyzer-bin=/usr/bin/gcc' '/tmp/tmprfixrv9v/cracklib-2.10.3-1.fc45.src.rpm'
diffbase-tool-versioncsmock-3.8.5.20260529.133039.g6f3b5c6-1.el9
enabled-pluginsclippy, cppcheck, gcc, shellcheck, unicontrol
exit-code0
hostip-172-16-1-130.us-west-2.compute.internal
known-false-positives/usr/share/csmock/known-false-positives.js
known-false-positives-rpmknown-false-positives-0.0.0.20260524.213755.g3c6d0be.main-1.el9.noarch
mock-configfedora-rawhide-x86_64
project-namecracklib-2.9.11-10.fc44
store-results-to/tmp/tmpcmkj8jbt/cracklib-2.9.11-10.fc44.tar.xz
time-created2026-06-01 11:40:07
time-finished2026-06-01 11:41:41
titleFixed findings
toolcsmock
tool-args'/usr/bin/csmock' '-r' 'fedora-rawhide-x86_64' '-t' 'shellcheck,cppcheck,clippy,unicontrol,gcc' '-o' '/tmp/tmpcmkj8jbt/cracklib-2.9.11-10.fc44.tar.xz' '--gcc-analyze' '--unicontrol-notests' '--unicontrol-bidi-only' '--install' 'pam' '--gcc-analyzer-bin=/usr/bin/gcc' '/tmp/tmpcmkj8jbt/cracklib-2.9.11-10.fc44.src.rpm'
tool-versioncsmock-3.8.5.20260529.133039.g6f3b5c6-1.el9