Fixed findings

List of Findings

Error: COMPILER_WARNING (CWE-704): [#def1]
certmonger-0.79.21/src/keygen-o.c: scope_hint: In function ‘cm_keygen_o_main’
certmonger-0.79.21/src/keygen-o.c:323:19: warning[-Wdiscarded-qualifiers]: initialization discards ‘const’ qualifier from pointer target type
#  323 |         char *n = EVP_PKEY_get0_type_name(pkey);
#      |                   ^~~~~~~~~~~~~~~~~~~~~~~
#  321|   	}
#  322|   
#  323|-> 	char *n = EVP_PKEY_get0_type_name(pkey);
#  324|   	cm_log(1, "debug: generated type %s for %d\n", n, cm_key_algorithm);
#  325|   

Error: COMPILER_WARNING (CWE-704): [#def2]
certmonger-0.79.21/src/keygen-o.c:323:19: warning[-Wdiscarded-qualifiers]: initialization discards ‘const’ qualifier from pointer target type
#  321|   	}
#  322|   
#  323|-> 	char *n = EVP_PKEY_get0_type_name(pkey);
#  324|   	cm_log(1, "debug: generated type %s for %d\n", n, cm_key_algorithm);
#  325|   

Error: COMPILER_WARNING (CWE-704): [#def3]
certmonger-0.79.21/src/keyiread-o.c: scope_hint: In function ‘cm_keyiread_o_main’
certmonger-0.79.21/src/keyiread-o.c:169:35: warning[-Wdiscarded-qualifiers]: initialization discards ‘const’ qualifier from pointer target type
#  169 |                         char *n = EVP_PKEY_get0_type_name(pkey);
#      |                                   ^~~~~~~~~~~~~~~~~~~~~~~
#  167|   			cm_log(1, "debug: pkey ID is %d\n", EVP_PKEY_get_id(pkey));
#  168|   
#  169|-> 			char *n = EVP_PKEY_get0_type_name(pkey);
#  170|   			cm_log(1, "debug: type %s\n", n);
#  171|   

Error: COMPILER_WARNING (CWE-704): [#def4]
certmonger-0.79.21/src/keyiread-o.c:169:35: warning[-Wdiscarded-qualifiers]: initialization discards ‘const’ qualifier from pointer target type
#  167|   			cm_log(1, "debug: pkey ID is %d\n", EVP_PKEY_get_id(pkey));
#  168|   
#  169|-> 			char *n = EVP_PKEY_get0_type_name(pkey);
#  170|   			cm_log(1, "debug: type %s\n", n);
#  171|   

Error: COMPILER_WARNING: [#def5]
certmonger-0.79.21/src/keyiread-o.c:202:36: warning[-Wimplicit-fallthrough=]: this statement may fall through
#  202 |                                 if (strcasecmp(name, "ML-DSA-87") == 0) {
#      |                                    ^
certmonger-0.79.21/src/keyiread-o.c:207:25: note: here
#  207 |                         default:
#      |                         ^~~~~~~
#  200|   					break;
#  201|   				} else
#  202|-> 				if (strcasecmp(name, "ML-DSA-87") == 0) {
#  203|   					alg = "ML-DSA-87";
#  204|   					break;

Error: COMPILER_WARNING (CWE-704): [#def6]
certmonger-0.79.21/src/keyiread-o.c:252:46: warning[-Wdiscarded-qualifiers]: initialization discards ‘const’ qualifier from pointer target type
#  252 |                                 char *name = EVP_PKEY_get0_type_name(pkey);
#      |                                              ^~~~~~~~~~~~~~~~~~~~~~~
#  250|   #ifdef CM_ENABLE_ML_DSA
#  251|   			case 0:  /* no key type base */
#  252|-> 				char *name = EVP_PKEY_get0_type_name(pkey);
#  253|   
#  254|   				if (strcasecmp(name, "ML-DSA-44") == 0) {

Error: COMPILER_WARNING (CWE-704): [#def7]
certmonger-0.79.21/src/keyiread-o.c:252:46: warning[-Wdiscarded-qualifiers]: initialization discards ‘const’ qualifier from pointer target type
#  250|   #ifdef CM_ENABLE_ML_DSA
#  251|   			case 0:  /* no key type base */
#  252|-> 				char *name = EVP_PKEY_get0_type_name(pkey);
#  253|   
#  254|   				if (strcasecmp(name, "ML-DSA-44") == 0) {

Error: COMPILER_WARNING: [#def8]
certmonger-0.79.21/src/keyiread-o.c:262:36: warning[-Wimplicit-fallthrough=]: this statement may fall through
#  262 |                                 if (strcasecmp(name, "ML-DSA-87") == 0) {
#      |                                    ^
certmonger-0.79.21/src/keyiread-o.c:267:25: note: here
#  267 |                         default:
#      |                         ^~~~~~~
#  260|   					break;
#  261|   				} else
#  262|-> 				if (strcasecmp(name, "ML-DSA-87") == 0) {
#  263|   					alg = "ML-DSA-87";
#  264|   					break;

Error: COMPILER_WARNING: [#def9]
certmonger-0.79.21/src/submit-e.c: scope_hint: In function ‘cm_submit_e_helper_main’
certmonger-0.79.21/src/submit-e.c:887:24: warning: extra tokens at end of ‘#ifdef’ directive
#  887 | #ifdef CM_ENABLE_ML_DSA:
#      |                        ^
#  885|   		break;
#  886|   #endif
#  887|-> #ifdef CM_ENABLE_ML_DSA:
#  888|   	case cm_key_ml_dsa_44:
#  889|   		key_type = "ML-DSA-44";

Error: COMPILER_WARNING: [#def10]
certmonger-0.79.21/src/submit-e.c:887:24: warning[warning]: extra tokens at end of ‘#ifdef’ directive
#  885|   		break;
#  886|   #endif
#  887|-> #ifdef CM_ENABLE_ML_DSA:
#  888|   	case cm_key_ml_dsa_44:
#  889|   		key_type = "ML-DSA-44";

Error: COMPILER_WARNING: [#def11]
certmonger-0.79.21/tests/tools/keyiread.c: scope_hint: In function ‘type_name’
certmonger-0.79.21/tests/tools/keyiread.c:67:24: warning: extra tokens at end of ‘#ifdef’ directive
#   67 | #ifdef CM_ENABLE_ML_DSA:
#      |                        ^
#   65|   		break;
#   66|   #endif
#   67|-> #ifdef CM_ENABLE_ML_DSA:
#   68|   	case cm_key_ml_dsa_44:
#   69|   		return "ML-DSA-44";

Error: COMPILER_WARNING: [#def12]
certmonger-0.79.21/tests/tools/keyiread.c:67:24: warning[warning]: extra tokens at end of ‘#ifdef’ directive
#   65|   		break;
#   66|   #endif
#   67|-> #ifdef CM_ENABLE_ML_DSA:
#   68|   	case cm_key_ml_dsa_44:
#   69|   		return "ML-DSA-44";

Error: COMPILER_WARNING: [#def13]
certmonger-0.79.21/tests/tools/keyiread.c: scope_hint: In function ‘munge_key_size’
certmonger-0.79.21/tests/tools/keyiread.c:100:24: warning: extra tokens at end of ‘#ifdef’ directive
#  100 | #ifdef CM_ENABLE_ML_DSA:
#      |                        ^
#   98|   		break;
#   99|   #endif
#  100|-> #ifdef CM_ENABLE_ML_DSA:
#  101|   	case cm_key_ml_dsa_44:
#  102|   	case cm_key_ml_dsa_65:

Error: COMPILER_WARNING: [#def14]
certmonger-0.79.21/tests/tools/keyiread.c:100:24: warning[warning]: extra tokens at end of ‘#ifdef’ directive
#   98|   		break;
#   99|   #endif
#  100|-> #ifdef CM_ENABLE_ML_DSA:
#  101|   	case cm_key_ml_dsa_44:
#  102|   	case cm_key_ml_dsa_65:

Scan Properties