Fixed findings

List of Findings

Error: COMPILER_WARNING (CWE-704): [#def1]
NetworkManager-1.56.0/src/core/dhcp/nm-dhcp-utils.c: scope_hint: In function ‘ip4_process_dhcpcd_rfc3442_routes’
NetworkManager-1.56.0/src/core/dhcp/nm-dhcp-utils.c:53:15: warning[-Wdiscarded-qualifiers]: assignment discards ‘const’ qualifier from pointer target type
#   53 |         slash = strchr(*r, '/');
#      |               ^
#   51|           guint32 rt_addr, rt_route;
#   52|   
#   53|->         slash = strchr(*r, '/');
#   54|           if (slash) {
#   55|               *slash  = '\0';

Error: COMPILER_WARNING (CWE-704): [#def2]
NetworkManager-1.56.0/src/core/dhcp/nm-dhcp-utils.c:53:15: warning[-Wdiscarded-qualifiers]: assignment discards ‘const’ qualifier from pointer target type
#   51|           guint32 rt_addr, rt_route;
#   52|   
#   53|->         slash = strchr(*r, '/');
#   54|           if (slash) {
#   55|               *slash  = '\0';

Error: COMPILER_WARNING (CWE-704): [#def3]
NetworkManager-1.56.0/src/core/dns/nm-dns-manager.c: scope_hint: In function ‘_domain_track_is_shadowed’
NetworkManager-1.56.0/src/core/dns/nm-dns-manager.c:1530:12: warning[-Wdiscarded-qualifiers]: assignment discards ‘const’ qualifier from pointer target type
# 1530 |     parent = strchr(domain, '.');
#      |            ^
# 1528|       }
# 1529|   
# 1530|->     parent = strchr(domain, '.');
# 1531|       while (parent && parent[1]) {
# 1532|           parent++;

Error: COMPILER_WARNING (CWE-704): [#def4]
NetworkManager-1.56.0/src/core/dns/nm-dns-manager.c:1530:12: warning[-Wdiscarded-qualifiers]: assignment discards ‘const’ qualifier from pointer target type
# 1528|       }
# 1529|   
# 1530|->     parent = strchr(domain, '.');
# 1531|       while (parent && parent[1]) {
# 1532|           parent++;

Error: COMPILER_WARNING (CWE-704): [#def5]
NetworkManager-1.56.0/src/core/nm-checkpoint.c: scope_hint: In function ‘parse_connection_from_shadowed_file’
NetworkManager-1.56.0/src/core/nm-checkpoint.c:169:14: warning[-Wdiscarded-qualifiers]: assignment discards ‘const’ qualifier from pointer target type
#  169 |     sep      = strrchr(path, '/');
#      |              ^
#  167|           return NULL;
#  168|   
#  169|->     sep      = strrchr(path, '/');
#  170|       base_dir = g_strndup(path, sep - path);
#  171|   

Error: COMPILER_WARNING (CWE-704): [#def6]
NetworkManager-1.56.0/src/core/nm-checkpoint.c:169:14: warning[-Wdiscarded-qualifiers]: assignment discards ‘const’ qualifier from pointer target type
#  167|           return NULL;
#  168|   
#  169|->     sep      = strrchr(path, '/');
#  170|       base_dir = g_strndup(path, sep - path);
#  171|   

Error: GCC_ANALYZER_WARNING (CWE-457): [#def7]
NetworkManager-1.56.0/src/core/nm-l3-config-data.c:1178:22: warning[-Wanalyzer-use-of-uninitialized-value]: use of uninitialized value ‘*obj_new.<U81e0>.ip_address.addr_source’
NetworkManager-1.56.0/src/core/nm-l3-config-data.c:3147:1: enter_function: entry to ‘nm_l3_config_data_new_from_platform’
NetworkManager-1.56.0/src/core/nm-l3-config-data.c:3158:8: branch_false: following ‘false’ branch...
NetworkManager-1.56.0/src/core/nm-l3-config-data.c:3161:12: branch_false: ...to here
NetworkManager-1.56.0/src/core/nm-l3-config-data.c:3163:5: call_function: calling ‘_init_from_platform’ from ‘nm_l3_config_data_new_from_platform’
# 1176|                    *
# 1177|                    * For other sources, the longer lifetime wins. */
# 1178|->                 if ((obj_new->ip_address.addr_source == NM_IP_CONFIG_SOURCE_KERNEL
# 1179|                        && obj_old->ip_address.addr_source != NM_IP_CONFIG_SOURCE_KERNEL)
# 1180|                       || nm_platform_ip_address_cmp_expiry(NMP_OBJECT_CAST_IP_ADDRESS(obj_old),

Error: GCC_ANALYZER_WARNING (CWE-457): [#def8]
NetworkManager-1.56.0/src/core/nm-l3-config-data.c:1204:21: warning[-Wanalyzer-use-of-uninitialized-value]: use of uninitialized value ‘*obj_new.<U81e0>.ip_route.rt_source’
NetworkManager-1.56.0/src/core/nm-l3-config-data.c:3147:1: enter_function: entry to ‘nm_l3_config_data_new_from_platform’
NetworkManager-1.56.0/src/core/nm-l3-config-data.c:3158:8: branch_false: following ‘false’ branch...
NetworkManager-1.56.0/src/core/nm-l3-config-data.c:3161:12: branch_false: ...to here
NetworkManager-1.56.0/src/core/nm-l3-config-data.c:3163:5: call_function: calling ‘_init_from_platform’ from ‘nm_l3_config_data_new_from_platform’
# 1202|               case NMP_OBJECT_TYPE_IP6_ROUTE:
# 1203|                   /* keep the maximum rt_source. */
# 1204|->                 if (obj_new->ip_route.rt_source < obj_old->ip_route.rt_source) {
# 1205|                       obj_new = nmp_object_stackinit_obj(&obj_new_stackinit, obj_new);
# 1206|                       obj_new_stackinit.ip_route.rt_source = obj_old->ip_route.rt_source;

Error: COMPILER_WARNING (CWE-704): [#def9]
NetworkManager-1.56.0/src/core/supplicant/nm-supplicant-settings-verify.c: scope_hint: In function ‘validate_type_keyword’
NetworkManager-1.56.0/src/core/supplicant/nm-supplicant-settings-verify.c:239:11: warning[-Wdiscarded-qualifiers]: assignment discards ‘const’ qualifier from pointer target type
#  239 |         s = strchr(value, ' ');
#      |           ^
#  237|               return TRUE;
#  238|   
#  239|->         s = strchr(value, ' ');
#  240|           if (s) {
#  241|               s[0] = '\0';

Error: COMPILER_WARNING (CWE-704): [#def10]
NetworkManager-1.56.0/src/core/supplicant/nm-supplicant-settings-verify.c:239:11: warning[-Wdiscarded-qualifiers]: assignment discards ‘const’ qualifier from pointer target type
#  237|               return TRUE;
#  238|   
#  239|->         s = strchr(value, ' ');
#  240|           if (s) {
#  241|               s[0] = '\0';

Error: COMPILER_WARNING (CWE-704): [#def11]
NetworkManager-1.56.0/src/libnm-core-aux-intern/nm-libnm-core-utils.c: scope_hint: In function ‘nm_utils_validate_shared_dhcp_range’
NetworkManager-1.56.0/src/libnm-core-aux-intern/nm-libnm-core-utils.c:524:21: warning[-Wdiscarded-qualifiers]: assignment discards ‘const’ qualifier from pointer target type
#  524 |     end_address_str = strchr(shared_dhcp_range, ',');
#      |                     ^
#  522|       }
#  523|   
#  524|->     end_address_str = strchr(shared_dhcp_range, ',');
#  525|       if (!end_address_str) {
#  526|           g_set_error_literal(error,

Error: COMPILER_WARNING (CWE-704): [#def12]
NetworkManager-1.56.0/src/libnm-core-aux-intern/nm-libnm-core-utils.c:524:21: warning[-Wdiscarded-qualifiers]: assignment discards ‘const’ qualifier from pointer target type
#  522|       }
#  523|   
#  524|->     end_address_str = strchr(shared_dhcp_range, ',');
#  525|       if (!end_address_str) {
#  526|           g_set_error_literal(error,

Error: COMPILER_WARNING (CWE-704): [#def13]
NetworkManager-1.56.0/src/libnm-core-aux-intern/nm-libnm-core-utils.c: scope_hint: In function ‘nm_dns_uri_parse’
NetworkManager-1.56.0/src/libnm-core-aux-intern/nm-libnm-core-utils.c:828:14: warning[-Wdiscarded-qualifiers]: assignment discards ‘const’ qualifier from pointer target type
#  828 |         perc = strchr(addr, '%');
#      |              ^
#  826|   
#  827|           /* IPv6 link-local scope-id */
#  828|->         perc = strchr(addr, '%');
#  829|           if (perc) {
#  830|               *perc = '\0';

Error: COMPILER_WARNING (CWE-704): [#def14]
NetworkManager-1.56.0/src/libnm-core-aux-intern/nm-libnm-core-utils.c:828:14: warning[-Wdiscarded-qualifiers]: assignment discards ‘const’ qualifier from pointer target type
#  826|   
#  827|           /* IPv6 link-local scope-id */
#  828|->         perc = strchr(addr, '%');
#  829|           if (perc) {
#  830|               *perc = '\0';

Error: COMPILER_WARNING (CWE-704): [#def15]
NetworkManager-1.56.0/src/libnm-core-impl/nm-setting-bridge.c: scope_hint: In function ‘nm_bridge_vlan_from_str’
NetworkManager-1.56.0/src/libnm-core-impl/nm-setting-bridge.c:494:7: warning[-Wdiscarded-qualifiers]: assignment discards ‘const’ qualifier from pointer target type
#  494 |     c = strchr(tokens[0], '-');
#      |       ^
#  492|       }
#  493|   
#  494|->     c = strchr(tokens[0], '-');
#  495|       if (c)
#  496|           *c = '\0';

Error: COMPILER_WARNING (CWE-704): [#def16]
NetworkManager-1.56.0/src/libnm-core-impl/nm-setting-bridge.c:494:7: warning[-Wdiscarded-qualifiers]: assignment discards ‘const’ qualifier from pointer target type
#  492|       }
#  493|   
#  494|->     c = strchr(tokens[0], '-');
#  495|       if (c)
#  496|           *c = '\0';

Error: COMPILER_WARNING (CWE-704): [#def17]
NetworkManager-1.56.0/src/libnm-core-impl/nm-setting.c: scope_hint: In function ‘nm_range_from_str’
NetworkManager-1.56.0/src/libnm-core-impl/nm-setting.c:4531:7: warning[-Wdiscarded-qualifiers]: assignment discards ‘const’ qualifier from pointer target type
# 4531 |     c = strchr(str, '-');
#      |       ^
# 4529|       g_return_val_if_fail(!error || !*error, NULL);
# 4530|   
# 4531|->     c = strchr(str, '-');
# 4532|       if (c) {
# 4533|           str = nm_strndup_a(300, str, c - str, &str_free);

Error: COMPILER_WARNING (CWE-704): [#def18]
NetworkManager-1.56.0/src/libnm-core-impl/nm-setting.c:4531:7: warning[-Wdiscarded-qualifiers]: assignment discards ‘const’ qualifier from pointer target type
# 4529|       g_return_val_if_fail(!error || !*error, NULL);
# 4530|   
# 4531|->     c = strchr(str, '-');
# 4532|       if (c) {
# 4533|           str = nm_strndup_a(300, str, c - str, &str_free);

Error: CPPCHECK_WARNING (CWE-457): [#def19]
NetworkManager-1.56.0/src/libnm-platform/wifi/nm-wifi-utils-wext.c:834: error[uninitvar]: Uninitialized variable: iwr
#  832|       fd = socket(PF_INET, SOCK_DGRAM | SOCK_CLOEXEC, 0);
#  833|       if (fd >= 0) {
#  834|->         nm_utils_ifname_cpy(iwr.ifr_ifrn.ifrn_name, iface);
#  835|           if (ioctl(fd, SIOCGIWNAME, &iwr) == 0)
#  836|               is_wifi = TRUE;

Error: COMPILER_WARNING (CWE-704): [#def20]
NetworkManager-1.56.0/src/libnm-systemd-shared/src/basic/fd-util.c:30: included_from: Included from here.
NetworkManager-1.56.0/src/libnm-systemd-shared/src/basic/sort-util.h: scope_hint: In function ‘bsearch_safe’
NetworkManager-1.56.0/src/libnm-systemd-shared/src/basic/sort-util.h:34:16: warning[-Wdiscarded-qualifiers]: return discards ‘const’ qualifier from pointer target type
#   34 |         return bsearch(key, base, nmemb, size, compar);
#      |                ^~~~~~~
#   32|   
#   33|           assert(base);
#   34|->         return bsearch(key, base, nmemb, size, compar);
#   35|   }
#   36|   

Error: COMPILER_WARNING (CWE-704): [#def21]
NetworkManager-1.56.0/src/libnm-systemd-shared/src/basic/sort-util.h:34:16: warning[-Wdiscarded-qualifiers]: return discards ‘const’ qualifier from pointer target type
#   32|   
#   33|           assert(base);
#   34|->         return bsearch(key, base, nmemb, size, compar);
#   35|   }
#   36|   

Error: COMPILER_WARNING (CWE-704): [#def22]
NetworkManager-1.56.0/src/libnm-systemd-shared/src/basic/string-util.c: scope_hint: In function ‘strrstr’
NetworkManager-1.56.0/src/libnm-systemd-shared/src/basic/string-util.c:1482:24: warning[-Wdiscarded-qualifiers]: return discards ‘const’ qualifier from pointer target type
# 1482 |                 return strchr(haystack, 0);
#      |                        ^~~~~~
# 1480|            * last char, not before. */
# 1481|           if (*needle == 0)
# 1482|->                 return strchr(haystack, 0);
# 1483|   
# 1484|           for (const char *p = strstr(haystack, needle), *q; p; p = q) {

Error: COMPILER_WARNING (CWE-704): [#def23]
NetworkManager-1.56.0/src/libnm-systemd-shared/src/basic/string-util.c:1482:24: warning[-Wdiscarded-qualifiers]: return discards ‘const’ qualifier from pointer target type
# 1480|            * last char, not before. */
# 1481|           if (*needle == 0)
# 1482|->                 return strchr(haystack, 0);
# 1483|   
# 1484|           for (const char *p = strstr(haystack, needle), *q; p; p = q) {

Error: COMPILER_WARNING (CWE-704): [#def24]
NetworkManager-1.56.0/src/libnm-systemd-shared/src/basic/siphash24.h:10: included_from: Included from here.
NetworkManager-1.56.0/src/libnm-systemd-shared/src/basic/hash-funcs.h:6: included_from: Included from here.
NetworkManager-1.56.0/src/libnm-systemd-shared/src/basic/hashmap.h:8: included_from: Included from here.
NetworkManager-1.56.0/src/libnm-systemd-shared/src/shared/dns-domain.h:10: included_from: Included from here.
NetworkManager-1.56.0/src/libnm-systemd-shared/nm-sd-utils-shared.c:12: included_from: Included from here.
NetworkManager-1.56.0/src/libnm-systemd-shared/src/basic/string-util.h: scope_hint: In function ‘strstr_ptr’
NetworkManager-1.56.0/src/libnm-systemd-shared/src/basic/string-util.h:33:16: warning[-Wdiscarded-qualifiers]: return discards ‘const’ qualifier from pointer target type
#   33 |         return strstr(haystack, needle);
#      |                ^~~~~~
#   31|           if (!haystack || !needle)
#   32|                   return NULL;
#   33|->         return strstr(haystack, needle);
#   34|   }
#   35|   

Error: COMPILER_WARNING (CWE-704): [#def25]
NetworkManager-1.56.0/src/libnm-systemd-shared/src/basic/string-util.h:33:16: warning[-Wdiscarded-qualifiers]: return discards ‘const’ qualifier from pointer target type
#   31|           if (!haystack || !needle)
#   32|                   return NULL;
#   33|->         return strstr(haystack, needle);
#   34|   }
#   35|   

Error: COMPILER_WARNING (CWE-704): [#def26]
NetworkManager-1.56.0/src/libnm-udev-aux/nm-udev-utils.c: scope_hint: In function ‘_subsystem_split’
NetworkManager-1.56.0/src/libnm-udev-aux/nm-udev-utils.c:102:7: warning[-Wdiscarded-qualifiers]: assignment discards ‘const’ qualifier from pointer target type
#  102 |     s = strstr(subsystem_full, "/");
#      |       ^
#  100|       nm_assert(to_free);
#  101|   
#  102|->     s = strstr(subsystem_full, "/");
#  103|       if (s) {
#  104|           tmp            = g_strdup(subsystem_full);

Error: COMPILER_WARNING (CWE-704): [#def27]
NetworkManager-1.56.0/src/libnm-udev-aux/nm-udev-utils.c:102:7: warning[-Wdiscarded-qualifiers]: assignment discards ‘const’ qualifier from pointer target type
#  100|       nm_assert(to_free);
#  101|   
#  102|->     s = strstr(subsystem_full, "/");
#  103|       if (s) {
#  104|           tmp            = g_strdup(subsystem_full);

Error: COMPILER_WARNING (CWE-704): [#def28]
NetworkManager-1.56.0/src/nm-initrd-generator/nmi-cmdline-reader.c: scope_hint: In function ‘reader_parse_rd_znet’
NetworkManager-1.56.0/src/nm-initrd-generator/nmi-cmdline-reader.c:1254:13: warning[-Wdiscarded-qualifiers]: assignment discards ‘const’ qualifier from pointer target type
# 1254 |         val = strchr(tmp, '=');
#      |             ^
# 1252|           char       *val;
# 1253|   
# 1254|->         val = strchr(tmp, '=');
# 1255|           if (!val) {
# 1256|               /* an invalid (or empty) entry. Ignore. */

Error: COMPILER_WARNING (CWE-704): [#def29]
NetworkManager-1.56.0/src/nm-initrd-generator/nmi-cmdline-reader.c:1254:13: warning[-Wdiscarded-qualifiers]: assignment discards ‘const’ qualifier from pointer target type
# 1252|           char       *val;
# 1253|   
# 1254|->         val = strchr(tmp, '=');
# 1255|           if (!val) {
# 1256|               /* an invalid (or empty) entry. Ignore. */

Scan Properties

analyzer-version-clippy1.95.0
analyzer-version-cppcheck2.20.0
analyzer-version-gcc16.1.1
analyzer-version-gcc-analyzer16.1.1
analyzer-version-shellcheck0.11.0
analyzer-version-unicontrol0.0.2
diffbase-analyzer-version-clippy1.95.0
diffbase-analyzer-version-cppcheck2.20.0
diffbase-analyzer-version-gcc16.1.1
diffbase-analyzer-version-gcc-analyzer16.1.1
diffbase-analyzer-version-shellcheck0.11.0
diffbase-analyzer-version-unicontrol0.0.2
diffbase-enabled-pluginsclippy, cppcheck, gcc, shellcheck, unicontrol
diffbase-exit-code0
diffbase-hostip-172-16-1-253.us-west-2.compute.internal
diffbase-known-false-positives/usr/share/csmock/known-false-positives.js
diffbase-known-false-positives-rpmknown-false-positives-0.0.0.20260524.213755.g3c6d0be.main-1.el9.noarch
diffbase-mock-configfedora-rawhide-x86_64
diffbase-project-nameNetworkManager-1.57.3~dev-1.fc45
diffbase-store-results-to/tmp/tmp82u1qpd6/NetworkManager-1.57.3~dev-1.fc45.tar.xz
diffbase-time-created2026-06-01 11:39:38
diffbase-time-finished2026-06-01 12:01:40
diffbase-toolcsmock
diffbase-tool-args'/usr/bin/csmock' '-r' 'fedora-rawhide-x86_64' '-t' 'shellcheck,cppcheck,clippy,unicontrol,gcc' '-o' '/tmp/tmp82u1qpd6/NetworkManager-1.57.3~dev-1.fc45.tar.xz' '--gcc-analyze' '--unicontrol-notests' '--unicontrol-bidi-only' '--install' 'pam' '--gcc-analyzer-bin=/usr/bin/gcc' '/tmp/tmp82u1qpd6/NetworkManager-1.57.3~dev-1.fc45.src.rpm'
diffbase-tool-versioncsmock-3.8.5.20260529.133039.g6f3b5c6-1.el9
enabled-pluginsclippy, cppcheck, gcc, shellcheck, unicontrol
exit-code0
hostip-172-16-1-253.us-west-2.compute.internal
known-false-positives/usr/share/csmock/known-false-positives.js
known-false-positives-rpmknown-false-positives-0.0.0.20260524.213755.g3c6d0be.main-1.el9.noarch
mock-configfedora-rawhide-x86_64
project-nameNetworkManager-1.56.0-1.fc44
store-results-to/tmp/tmptkj_kaz6/NetworkManager-1.56.0-1.fc44.tar.xz
time-created2026-06-01 11:17:19
time-finished2026-06-01 11:39:20
titleFixed findings
toolcsmock
tool-args'/usr/bin/csmock' '-r' 'fedora-rawhide-x86_64' '-t' 'shellcheck,cppcheck,clippy,unicontrol,gcc' '-o' '/tmp/tmptkj_kaz6/NetworkManager-1.56.0-1.fc44.tar.xz' '--gcc-analyze' '--unicontrol-notests' '--unicontrol-bidi-only' '--install' 'pam' '--gcc-analyzer-bin=/usr/bin/gcc' '/tmp/tmptkj_kaz6/NetworkManager-1.56.0-1.fc44.src.rpm'
tool-versioncsmock-3.8.5.20260529.133039.g6f3b5c6-1.el9