Newly introduced findings

List of Findings

Error: COMPILER_WARNING: [#def1]
NetworkManager-1.57.3-dev/src/core/bpf/clat.bpf.c:108: Error: junk at end of line, first unrecognized character is `%'
#  106|       if (*data + offset + size > *data_end) {
#  107|           bpf_skb_pull_data(skb, offset + size);
#  108|->         *data     = SKB_DATA(skb);
#  109|           *data_end = SKB_DATA_END(skb);
#  110|       }

Error: COMPILER_WARNING: [#def2]
NetworkManager-1.57.3-dev/src/core/bpf/clat.bpf.c:109: Error: junk at end of line, first unrecognized character is `%'
#  107|           bpf_skb_pull_data(skb, offset + size);
#  108|           *data     = SKB_DATA(skb);
#  109|->         *data_end = SKB_DATA_END(skb);
#  110|       }
#  111|   

Error: COMPILER_WARNING: [#def3]
NetworkManager-1.57.3-dev/src/core/bpf/clat.bpf.c:241: Error: junk at end of line, first unrecognized character is `%'
#  239|   rewrite_icmp(struct __sk_buff *skb, const struct ipv6hdr *ip6h, bool has_eth)
#  240|   {
#  241|->     void            *data_end = SKB_DATA_END(skb);
#  242|       void            *data     = SKB_DATA(skb);
#  243|       struct icmphdr   icmp_buf;  /* copy of the old ICMPv4 header */

Error: COMPILER_WARNING: [#def4]
NetworkManager-1.57.3-dev/src/core/bpf/clat.bpf.c:242: Error: junk at end of line, first unrecognized character is `%'
#  240|   {
#  241|       void            *data_end = SKB_DATA_END(skb);
#  242|->     void            *data     = SKB_DATA(skb);
#  243|       struct icmphdr   icmp_buf;  /* copy of the old ICMPv4 header */
#  244|       struct icmp6hdr  icmp6_buf; /* buffer for the new ICMPv6 header */

Error: COMPILER_WARNING: [#def5]
/tmp/ccQ2eKaO.s: scope_hint: Assembler messages
NetworkManager-1.57.3-dev/src/core/bpf/clat.bpf.c:528: Error: junk at end of line, first unrecognized character is `%'
#  526|   {
#  527|       int             ret      = TC_ACT_OK;
#  528|->     void           *data_end = SKB_DATA_END(skb);
#  529|       void           *data     = SKB_DATA(skb);
#  530|       struct ipv6hdr *ip6h;

Error: COMPILER_WARNING: [#def6]
NetworkManager-1.57.3-dev/src/core/bpf/clat.bpf.c:529: Error: junk at end of line, first unrecognized character is `%'
#  527|       int             ret      = TC_ACT_OK;
#  528|       void           *data_end = SKB_DATA_END(skb);
#  529|->     void           *data     = SKB_DATA(skb);
#  530|       struct ipv6hdr *ip6h;
#  531|       struct ipv6hdr  dst_hdr = {

Error: COMPILER_WARNING: [#def7]
NetworkManager-1.57.3-dev/src/core/bpf/clat.bpf.c:602: Error: junk at end of line, first unrecognized character is `%'
#  600|           goto out;
#  601|   
#  602|->     data     = SKB_DATA(skb);
#  603|       data_end = SKB_DATA_END(skb);
#  604|   

Error: COMPILER_WARNING: [#def8]
NetworkManager-1.57.3-dev/src/core/bpf/clat.bpf.c:603: Error: junk at end of line, first unrecognized character is `%'
#  601|   
#  602|       data     = SKB_DATA(skb);
#  603|->     data_end = SKB_DATA_END(skb);
#  604|   
#  605|       if (!ensure_header(&ip6h, skb, &data, &data_end, L2_H_LEN(has_eth)))

Error: COMPILER_WARNING: [#def9]
NetworkManager-1.57.3-dev/src/core/bpf/clat.bpf.c:768: Error: junk at end of line, first unrecognized character is `%'
#  766|   rewrite_icmpv6_inner(struct __sk_buff *skb, __u32 *csum_diff, bool has_eth)
#  767|   {
#  768|->     void            *data_end = SKB_DATA_END(skb);
#  769|       void            *data     = SKB_DATA(skb);
#  770|       struct icmphdr  *icmp;

Error: COMPILER_WARNING: [#def10]
NetworkManager-1.57.3-dev/src/core/bpf/clat.bpf.c:769: Error: junk at end of line, first unrecognized character is `%'
#  767|   {
#  768|       void            *data_end = SKB_DATA_END(skb);
#  769|->     void            *data     = SKB_DATA(skb);
#  770|       struct icmphdr  *icmp;
#  771|       struct icmp6hdr *icmp6;

Error: COMPILER_WARNING: [#def11]
NetworkManager-1.57.3-dev/src/core/bpf/clat.bpf.c:807: Error: junk at end of line, first unrecognized character is `%'
#  805|   
#  806|       if (csum_diff) {
#  807|->         data_end = SKB_DATA_END(skb);
#  808|           data     = SKB_DATA(skb);
#  809|   

Error: COMPILER_WARNING: [#def12]
NetworkManager-1.57.3-dev/src/core/bpf/clat.bpf.c:808: Error: junk at end of line, first unrecognized character is `%'
#  806|       if (csum_diff) {
#  807|           data_end = SKB_DATA_END(skb);
#  808|->         data     = SKB_DATA(skb);
#  809|   
#  810|           if (!ensure_header(&icmp,

Error: COMPILER_WARNING: [#def13]
NetworkManager-1.57.3-dev/src/core/bpf/clat.bpf.c:828: Error: junk at end of line, first unrecognized character is `%'
#  826|   rewrite_ipv6_inner(struct __sk_buff *skb, struct iphdr *dst_hdr, __u32 *csum_diff, bool has_eth)
#  827|   {
#  828|->     void           *data_end = SKB_DATA_END(skb);
#  829|       void           *data     = SKB_DATA(skb);
#  830|       struct ipv6hdr *ip6h;

Error: COMPILER_WARNING: [#def14]
NetworkManager-1.57.3-dev/src/core/bpf/clat.bpf.c:829: Error: junk at end of line, first unrecognized character is `%'
#  827|   {
#  828|       void           *data_end = SKB_DATA_END(skb);
#  829|->     void           *data     = SKB_DATA(skb);
#  830|       struct ipv6hdr *ip6h;
#  831|       __be32          addr4;

Error: COMPILER_WARNING: [#def15]
NetworkManager-1.57.3-dev/src/core/bpf/clat.bpf.c:879: Error: junk at end of line, first unrecognized character is `%'
#  877|   rewrite_icmpv6(struct __sk_buff *skb, int *out_length_diff, bool has_eth)
#  878|   {
#  879|->     void            *data_end = SKB_DATA_END(skb);
#  880|       void            *data     = SKB_DATA(skb);
#  881|       struct iphdr    *ip;

Error: COMPILER_WARNING: [#def16]
NetworkManager-1.57.3-dev/src/core/bpf/clat.bpf.c:880: Error: junk at end of line, first unrecognized character is `%'
#  878|   {
#  879|       void            *data_end = SKB_DATA_END(skb);
#  880|->     void            *data     = SKB_DATA(skb);
#  881|       struct iphdr    *ip;
#  882|       struct icmp6hdr *icmp6;

Error: COMPILER_WARNING: [#def17]
NetworkManager-1.57.3-dev/src/core/bpf/clat.bpf.c:939: Error: junk at end of line, first unrecognized character is `%'
#  937|       *out_length_diff = (int) IP_H_LEN - (int) IP6_H_LEN;
#  938|   
#  939|->     data_end = SKB_DATA_END(skb);
#  940|       data     = SKB_DATA(skb);
#  941|   

Error: COMPILER_WARNING: [#def18]
NetworkManager-1.57.3-dev/src/core/bpf/clat.bpf.c:940: Error: junk at end of line, first unrecognized character is `%'
#  938|   
#  939|       data_end = SKB_DATA_END(skb);
#  940|->     data     = SKB_DATA(skb);
#  941|   
#  942|       if (!ensure_header(&ip, skb, &data, &data_end, L2_H_LEN(has_eth) + IP6_H_LEN + ICMP_H_LEN))

Error: COMPILER_WARNING: [#def19]
NetworkManager-1.57.3-dev/src/core/bpf/clat.bpf.c:970: Error: junk at end of line, first unrecognized character is `%'
#  968|   {
#  969|       int             ret      = TC_ACT_OK;
#  970|->     void           *data_end = SKB_DATA_END(skb);
#  971|       void           *data     = SKB_DATA(skb);
#  972|       struct ethhdr  *eth;

Error: COMPILER_WARNING: [#def20]
NetworkManager-1.57.3-dev/src/core/bpf/clat.bpf.c:971: Error: junk at end of line, first unrecognized character is `%'
#  969|       int             ret      = TC_ACT_OK;
#  970|       void           *data_end = SKB_DATA_END(skb);
#  971|->     void           *data     = SKB_DATA(skb);
#  972|       struct ethhdr  *eth;
#  973|       struct ipv6hdr *ip6h;

Error: COMPILER_WARNING: [#def21]
NetworkManager-1.57.3-dev/src/core/bpf/clat.bpf.c:1111: Error: junk at end of line, first unrecognized character is `%'
# 1109|        * an ICMPv6 error packet. Update the length and the checksum. */
# 1110|       if (length_diff != 0) {
# 1111|->         data     = SKB_DATA(skb);
# 1112|           data_end = SKB_DATA_END(skb);
# 1113|   

Error: COMPILER_WARNING: [#def22]
NetworkManager-1.57.3-dev/src/core/bpf/clat.bpf.c:1112: Error: junk at end of line, first unrecognized character is `%'
# 1110|       if (length_diff != 0) {
# 1111|           data     = SKB_DATA(skb);
# 1112|->         data_end = SKB_DATA_END(skb);
# 1113|   
# 1114|           if (!ensure_header(&ip6h, skb, &data, &data_end, L2_H_LEN(has_eth)))

Error: COMPILER_WARNING: [#def23]
NetworkManager-1.57.3-dev/src/core/bpf/clat.bpf.c:1133: Error: junk at end of line, first unrecognized character is `%'
# 1131|       }
# 1132|   
# 1133|->     data     = SKB_DATA(skb);
# 1134|       data_end = SKB_DATA_END(skb);
# 1135|   

Error: COMPILER_WARNING: [#def24]
NetworkManager-1.57.3-dev/src/core/bpf/clat.bpf.c:1134: Error: junk at end of line, first unrecognized character is `%'
# 1132|   
# 1133|       data     = SKB_DATA(skb);
# 1134|->     data_end = SKB_DATA_END(skb);
# 1135|   
# 1136|       if (!ensure_header(&iph, skb, &data, &data_end, L2_H_LEN(has_eth)))

Error: GCC_ANALYZER_WARNING (CWE-457): [#def25]
NetworkManager-1.57.3-dev/src/core/nm-l3-config-data.c:1228:22: warning[-Wanalyzer-use-of-uninitialized-value]: use of uninitialized value ‘*obj_new.<U6780>.ip_address.addr_source’
NetworkManager-1.57.3-dev/src/core/nm-l3-config-data.c:3364:1: enter_function: entry to ‘nm_l3_config_data_new_from_platform’
NetworkManager-1.57.3-dev/src/core/nm-l3-config-data.c:3375:8: branch_false: following ‘false’ branch...
NetworkManager-1.57.3-dev/src/core/nm-l3-config-data.c:3378:12: branch_false: ...to here
NetworkManager-1.57.3-dev/src/core/nm-l3-config-data.c:3380:5: call_function: calling ‘_init_from_platform’ from ‘nm_l3_config_data_new_from_platform’
# 1226|                    *
# 1227|                    * For other sources, the longer lifetime wins. */
# 1228|->                 if ((obj_new->ip_address.addr_source == NM_IP_CONFIG_SOURCE_KERNEL
# 1229|                        && obj_old->ip_address.addr_source != NM_IP_CONFIG_SOURCE_KERNEL)
# 1230|                       || nm_platform_ip_address_cmp_expiry(NMP_OBJECT_CAST_IP_ADDRESS(obj_old),

Error: GCC_ANALYZER_WARNING (CWE-476): [#def26]
NetworkManager-1.57.3-dev/src/core/nm-l3-config-data.c:1235:25: warning[-Wanalyzer-null-dereference]: dereference of NULL ‘0’
NetworkManager-1.57.3-dev/src/core/nm-l3-config-data.c:3254:1: enter_function: entry to ‘nm_l3_config_data_new_from_connection’
NetworkManager-1.57.3-dev/src/core/nm-l3-config-data.c:3263:5: call_function: calling ‘_init_from_connection_ip’ from ‘nm_l3_config_data_new_from_connection’
NetworkManager-1.57.3-dev/src/core/nm-l3-config-data.c:3263:5: return_function: returning to ‘nm_l3_config_data_new_from_connection’ from ‘_init_from_connection_ip’
NetworkManager-1.57.3-dev/src/core/nm-l3-config-data.c:3264:5: call_function: calling ‘_init_from_connection_ip’ from ‘nm_l3_config_data_new_from_connection’
# 1233|                       obj_new = nmp_object_stackinit_obj(&obj_new_stackinit, obj_new);
# 1234|                       obj_new_stackinit.ip_address.timestamp =
# 1235|->                         NMP_OBJECT_CAST_IP_ADDRESS(obj_old)->timestamp;
# 1236|                       obj_new_stackinit.ip_address.lifetime =
# 1237|                           NMP_OBJECT_CAST_IP_ADDRESS(obj_old)->lifetime;

Error: GCC_ANALYZER_WARNING (CWE-457): [#def27]
NetworkManager-1.57.3-dev/src/core/nm-l3-config-data.c:1254:21: warning[-Wanalyzer-use-of-uninitialized-value]: use of uninitialized value ‘*obj_new.<U6780>.ip_route.rt_source’
NetworkManager-1.57.3-dev/src/core/nm-l3-config-data.c:3364:1: enter_function: entry to ‘nm_l3_config_data_new_from_platform’
NetworkManager-1.57.3-dev/src/core/nm-l3-config-data.c:3375:8: branch_false: following ‘false’ branch...
NetworkManager-1.57.3-dev/src/core/nm-l3-config-data.c:3378:12: branch_false: ...to here
NetworkManager-1.57.3-dev/src/core/nm-l3-config-data.c:3380:5: call_function: calling ‘_init_from_platform’ from ‘nm_l3_config_data_new_from_platform’
# 1252|               case NMP_OBJECT_TYPE_IP6_ROUTE:
# 1253|                   /* keep the maximum rt_source. */
# 1254|->                 if (obj_new->ip_route.rt_source < obj_old->ip_route.rt_source) {
# 1255|                       obj_new = nmp_object_stackinit_obj(&obj_new_stackinit, obj_new);
# 1256|                       obj_new_stackinit.ip_route.rt_source = obj_old->ip_route.rt_source;

Error: GCC_ANALYZER_WARNING (CWE-476): [#def28]
NetworkManager-1.57.3-dev/src/core/nm-l3cfg.c:4216:17: warning[-Wanalyzer-null-dereference]: dereference of NULL ‘ip4_route’
NetworkManager-1.57.3-dev/src/core/nm-l3cfg.c:6239:1: enter_function: entry to ‘nm_l3cfg_get_combined_l3cd’
NetworkManager-1.57.3-dev/src/core/nm-l3cfg.c:6246:5: call_function: calling ‘_l3cfg_update_combined_config’ from ‘nm_l3cfg_get_combined_l3cd’
# 4214|           /* disable if there is a native IPv4 gateway */
# 4215|           nm_l3_config_data_iter_ip4_route_for_each (&iter, l3cd, &ip4_route) {
# 4216|->             if (ip4_route->network == INADDR_ANY && ip4_route->plen == 0
# 4217|                   && ip4_route->gateway != INADDR_ANY)
# 4218|                   clat_enabled = FALSE;

Error: CPPCHECK_WARNING (CWE-457): [#def29]
NetworkManager-1.57.3-dev/src/core/nm-l3cfg.c:4261: error[uninitvar]: Uninitialized variable: ip6_entry
# 4259|                * draft-ietf-v6ops-claton-14 Section 7 */
# 4260|               nm_l3_config_data_iter_ip6_address_for_each (&iter, l3cd, &ip6_entry) {
# 4261|->                 if (ip6_entry->addr_source == NM_IP_CONFIG_SOURCE_NDISC && ip6_entry->plen == 64) {
# 4262|                       if (_clat_prefix_is_better(best_prefix, ip6_entry, &pref64))
# 4263|                           best_prefix = ip6_entry;

Error: GCC_ANALYZER_WARNING (CWE-476): [#def30]
NetworkManager-1.57.3-dev/src/core/nm-l3cfg.c:4261:21: warning[-Wanalyzer-null-dereference]: dereference of NULL ‘ip6_entry’
NetworkManager-1.57.3-dev/src/core/nm-l3cfg.c:6239:1: enter_function: entry to ‘nm_l3cfg_get_combined_l3cd’
NetworkManager-1.57.3-dev/src/core/nm-l3cfg.c:6246:5: call_function: calling ‘_l3cfg_update_combined_config’ from ‘nm_l3cfg_get_combined_l3cd’
# 4259|                * draft-ietf-v6ops-claton-14 Section 7 */
# 4260|               nm_l3_config_data_iter_ip6_address_for_each (&iter, l3cd, &ip6_entry) {
# 4261|->                 if (ip6_entry->addr_source == NM_IP_CONFIG_SOURCE_NDISC && ip6_entry->plen == 64) {
# 4262|                       if (_clat_prefix_is_better(best_prefix, ip6_entry, &pref64))
# 4263|                           best_prefix = ip6_entry;

Scan Properties

analyzer-version-clippy1.95.0
analyzer-version-cppcheck2.20.0
analyzer-version-gcc16.1.1
analyzer-version-gcc-analyzer16.1.1
analyzer-version-shellcheck0.11.0
analyzer-version-unicontrol0.0.2
diffbase-analyzer-version-clippy1.95.0
diffbase-analyzer-version-cppcheck2.20.0
diffbase-analyzer-version-gcc16.1.1
diffbase-analyzer-version-gcc-analyzer16.1.1
diffbase-analyzer-version-shellcheck0.11.0
diffbase-analyzer-version-unicontrol0.0.2
diffbase-enabled-pluginsclippy, cppcheck, gcc, shellcheck, unicontrol
diffbase-exit-code0
diffbase-hostip-172-16-1-253.us-west-2.compute.internal
diffbase-known-false-positives/usr/share/csmock/known-false-positives.js
diffbase-known-false-positives-rpmknown-false-positives-0.0.0.20260524.213755.g3c6d0be.main-1.el9.noarch
diffbase-mock-configfedora-rawhide-x86_64
diffbase-project-nameNetworkManager-1.56.0-1.fc44
diffbase-store-results-to/tmp/tmptkj_kaz6/NetworkManager-1.56.0-1.fc44.tar.xz
diffbase-time-created2026-06-01 11:17:19
diffbase-time-finished2026-06-01 11:39:20
diffbase-toolcsmock
diffbase-tool-args'/usr/bin/csmock' '-r' 'fedora-rawhide-x86_64' '-t' 'shellcheck,cppcheck,clippy,unicontrol,gcc' '-o' '/tmp/tmptkj_kaz6/NetworkManager-1.56.0-1.fc44.tar.xz' '--gcc-analyze' '--unicontrol-notests' '--unicontrol-bidi-only' '--install' 'pam' '--gcc-analyzer-bin=/usr/bin/gcc' '/tmp/tmptkj_kaz6/NetworkManager-1.56.0-1.fc44.src.rpm'
diffbase-tool-versioncsmock-3.8.5.20260529.133039.g6f3b5c6-1.el9
enabled-pluginsclippy, cppcheck, gcc, shellcheck, unicontrol
exit-code0
hostip-172-16-1-253.us-west-2.compute.internal
known-false-positives/usr/share/csmock/known-false-positives.js
known-false-positives-rpmknown-false-positives-0.0.0.20260524.213755.g3c6d0be.main-1.el9.noarch
mock-configfedora-rawhide-x86_64
project-nameNetworkManager-1.57.3~dev-1.fc45
store-results-to/tmp/tmp82u1qpd6/NetworkManager-1.57.3~dev-1.fc45.tar.xz
time-created2026-06-01 11:39:38
time-finished2026-06-01 12:01:40
titleNewly introduced findings
toolcsmock
tool-args'/usr/bin/csmock' '-r' 'fedora-rawhide-x86_64' '-t' 'shellcheck,cppcheck,clippy,unicontrol,gcc' '-o' '/tmp/tmp82u1qpd6/NetworkManager-1.57.3~dev-1.fc45.tar.xz' '--gcc-analyze' '--unicontrol-notests' '--unicontrol-bidi-only' '--install' 'pam' '--gcc-analyzer-bin=/usr/bin/gcc' '/tmp/tmp82u1qpd6/NetworkManager-1.57.3~dev-1.fc45.src.rpm'
tool-versioncsmock-3.8.5.20260529.133039.g6f3b5c6-1.el9