Task #117530 - added.err
back to task #117530download
Error: CLIPPY_WARNING:
crates/lib/src/cli.rs:2131:75: warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
# |
# 2131 | std::iter::once(OsString::from("--system")).chain(args.into_iter()),
# | ^^^^^^^^^^^^^^^^
# |
# note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
# --> library/core/src/iter/traits/iterator.rs:510:11
# = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.95.0/index.html#useless_conversion
# help: consider removing the `.into_iter()`
# |
# 2131 - std::iter::once(OsString::from("--system")).chain(args.into_iter()),
# 2131 + std::iter::once(OsString::from("--system")).chain(args),
# |
Error: CLIPPY_WARNING:
crates/lib/src/deploy.rs:605:62: warning: unnecessary use of `to_string`
# |
# 605 | crate::bootc_composefs::repo::bootc_tag_for_manifest(&pull_result.manifest_digest.to_string());
# | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `pull_result.manifest_digest.as_ref()`
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.95.0/index.html#unnecessary_to_owned
Error: CLIPPY_WARNING:
crates/lib/src/image.rs:161:30: warning: in an `if` condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a `let`
# |
# 161 | let image_type = if {
# | ______________________________^
# 162 | | let id = &entry.id;
# 163 | | composefs_config_digests.contains(&format!("sha256:{id}"))
# 164 | | || composefs_config_digests.contains(id.as_str())
# 165 | | } {
# | |_____________^
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.95.0/index.html#blocks_in_conditions
# = note: `#[warn(clippy::blocks_in_conditions)]` on by default
# help: try
# |
# 161 ~ let image_type = let res = {
# 162 + let id = &entry.id;
# 163 + composefs_config_digests.contains(&format!("sha256:{id}"))
# 164 + || composefs_config_digests.contains(id.as_str())
# 165 ~ }; if res {
# |
Error: CLIPPY_WARNING:
crates/lib/src/image.rs:348:30: warning: manual implementation of `ok`
# |
# 348 | let reflinks_supported = match sysroot.reflinks_supported() {
# | ______________________________^
# 349 | | Ok(v) => Some(v),
# 350 | | Err(_) => None,
# 351 | | };
# | |_____^ help: replace with: `sysroot.reflinks_supported().ok()`
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.95.0/index.html#manual_ok_err
# = note: `#[warn(clippy::manual_ok_err)]` on by default
Error: CLIPPY_WARNING:
crates/lib/src/image.rs:1159:13: warning: unnecessary use of `to_string`
# |
# 1159 | &pull_result.manifest_digest.to_string(),
# | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `pull_result.manifest_digest.as_ref()`
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.95.0/index.html#unnecessary_to_owned
Error: CLIPPY_WARNING:
crates/ostree-ext/src/container/composefs_import.rs:150:17: warning: this `map_or` can be simplified
# |
# 150 | && !value.last().copied().map_or(true, |b| b == 0)
# | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.95.0/index.html#unnecessary_map_or
# = note: `#[warn(clippy::unnecessary_map_or)]` on by default
# help: use `is_none_or` instead
# |
# 150 - && !value.last().copied().map_or(true, |b| b == 0)
# 150 + && !value.last().copied().is_none_or(|b| b == 0)
# |
Error: CLIPPY_WARNING:
crates/ostree-ext/src/container/composefs_import.rs:503:25: warning: this `map_or` can be simplified
# |
# 503 | && !value.last().copied().map_or(true, |b| b == 0)
# | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.95.0/index.html#unnecessary_map_or
# help: use `is_none_or` instead
# |
# 503 - && !value.last().copied().map_or(true, |b| b == 0)
# 503 + && !value.last().copied().is_none_or(|b| b == 0)
# |
Error: CLIPPY_WARNING:
crates/xtask/src/tmt.rs:1245:9: warning: this `if` statement can be collapsed
# |
# 1245 | / if let serde_yaml::Value::Mapping(map) = &test.tmt {
# 1246 | | if let Some(adjust) = map.get(&serde_yaml::Value::String(FIELD_ADJUST.to_string())) {
# 1247 | | plan_value.insert(
# 1248 | | serde_yaml::Value::String(FIELD_ADJUST.to_string()),
# ... |
# 1252 | | }
# | |_________^
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.95.0/index.html#collapsible_if
# help: collapse nested if block
# |
# 1245 ~ if let serde_yaml::Value::Mapping(map) = &test.tmt
# 1246 ~ && let Some(adjust) = map.get(&serde_yaml::Value::String(FIELD_ADJUST.to_string())) {
# 1247 | plan_value.insert(
# ...
# 1250 | );
# 1251 ~ }
# |