Newly introduced findings

List of Findings

Error: CLIPPY_WARNING: [#def1]
crates/xtask/src/tmt.rs:3:5: warning: importing legacy numeric constants
#    |
#  3 | use std::usize;
#    |     ^^^^^^^^^^
#    |
#    = help: remove this import
#    = note: then `usize::<CONST>` will resolve to the respective associated constant
#    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.95.0/index.html#legacy_numeric_constants
#    = note: `#[warn(clippy::legacy_numeric_constants)]` on by default

Error: CLIPPY_WARNING: [#def2]
crates/xtask/src/tmt.rs:371:1: warning: this function has too many arguments (12/7)
#      |
#  371 | / fn run_plan(
#  372 | |     plan: String,
#  373 | |     vm_name: String,
#  374 | |     image: String,
#  ...   |
#  383 | |     libvirt_lock: Arc<Mutex<()>>,
#  384 | | ) -> RunPlanResult {
#      | |__________________^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.95.0/index.html#too_many_arguments
#      = note: `#[warn(clippy::too_many_arguments)]` on by default

Error: CLIPPY_WARNING: [#def3]
crates/xtask/src/tmt.rs:893:5: warning: consider using `sort_by_key`
#      |
#  893 |     test_results.sort_by(|a, b| b.time_taken.cmp(&a.time_taken));
#      |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.95.0/index.html#unnecessary_sort_by
#      = note: `#[warn(clippy::unnecessary_sort_by)]` on by default
#  help: try
#      |
#  893 -     test_results.sort_by(|a, b| b.time_taken.cmp(&a.time_taken));
#  893 +     test_results.sort_by_key(|b| std::cmp::Reverse(b.time_taken));
#      |

Error: CLIPPY_WARNING: [#def4]
crates/xtask/src/tmt.rs:1458:9: warning: this `if` statement can be collapsed
#       |
#  1458 | /         if let serde_yaml::Value::Mapping(map) = &test.tmt {
#  1459 | |             if let Some(adjust) = map.get(&serde_yaml::Value::String(FIELD_ADJUST.to_string())) {
#  1460 | |                 plan_value.insert(
#  1461 | |                     serde_yaml::Value::String(FIELD_ADJUST.to_string()),
#  ...    |
#  1465 | |         }
#       | |_________^
#       |
#       = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.95.0/index.html#collapsible_if
#  help: collapse nested if block
#       |
#  1458 ~         if let serde_yaml::Value::Mapping(map) = &test.tmt
#  1459 ~             && let Some(adjust) = map.get(&serde_yaml::Value::String(FIELD_ADJUST.to_string())) {
#  1460 |                 plan_value.insert(
#   ...
#  1463 |                 );
#  1464 ~             }
#       |

Scan Properties