Task #116044 - added.err
back to task #116044download
Error: CLIPPY_WARNING:
crates/xtask/src/tmt.rs:3:5: warning: importing legacy numeric constants
# |
# 3 | use std::usize;
# | ^^^^^^^^^^
# |
# = help: remove this import
# = note: then `usize::<CONST>` will resolve to the respective associated constant
# = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.95.0/index.html#legacy_numeric_constants
# = note: `#[warn(clippy::legacy_numeric_constants)]` on by default
Error: CLIPPY_WARNING:
crates/xtask/src/tmt.rs:371:1: warning: this function has too many arguments (11/7)
# |
# 371 | / fn run_plan(
# 372 | | plan: String,
# 373 | | vm_name: String,
# 374 | | image: String,
# ... |
# 382 | | vm_mem_mb: String,
# 383 | | ) -> RunPlanResult {
# | |__________________^
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.95.0/index.html#too_many_arguments
# = note: `#[warn(clippy::too_many_arguments)]` on by default
Error: CLIPPY_WARNING:
crates/xtask/src/tmt.rs:877:5: warning: consider using `sort_by_key`
# |
# 877 | test_results.sort_by(|a, b| b.time_taken.cmp(&a.time_taken));
# | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.95.0/index.html#unnecessary_sort_by
# = note: `#[warn(clippy::unnecessary_sort_by)]` on by default
# help: try
# |
# 877 - test_results.sort_by(|a, b| b.time_taken.cmp(&a.time_taken));
# 877 + test_results.sort_by_key(|b| std::cmp::Reverse(b.time_taken));
# |
Error: CLIPPY_WARNING:
crates/xtask/src/tmt.rs:1442:9: warning: this `if` statement can be collapsed
# |
# 1442 | / if let serde_yaml::Value::Mapping(map) = &test.tmt {
# 1443 | | if let Some(adjust) = map.get(&serde_yaml::Value::String(FIELD_ADJUST.to_string())) {
# 1444 | | plan_value.insert(
# 1445 | | serde_yaml::Value::String(FIELD_ADJUST.to_string()),
# ... |
# 1449 | | }
# | |_________^
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.95.0/index.html#collapsible_if
# help: collapse nested if block
# |
# 1442 ~ if let serde_yaml::Value::Mapping(map) = &test.tmt
# 1443 ~ && let Some(adjust) = map.get(&serde_yaml::Value::String(FIELD_ADJUST.to_string())) {
# 1444 | plan_value.insert(
# ...
# 1447 | );
# 1448 ~ }
# |