Newly introduced findings

List of Findings

Error: COMPILER_WARNING (CWE-1164): [#def1]
util-linux-2.43.devel/agetty-cmd/agetty.c:1050:16: warning[-Wunused-function]: ‘append’ defined but not used
# 1050 | static ssize_t append(char *dest, size_t len, const char  *sep, const char *src)
#      |                ^~~~~~
# 1048|    * Returns the final @dest length or -1 in case of error.
# 1049|    */
# 1050|-> static ssize_t append(char *dest, size_t len, const char  *sep, const char *src)
# 1051|   {
# 1052|   	size_t dsz = 0, ssz = 0, sz;

Error: GCC_ANALYZER_WARNING (CWE-688): [#def2]
util-linux-2.43.devel/agetty-cmd/issuefile.c: scope_hint: In function ‘issuefile_read_stream.part.0’
util-linux-2.43.devel/agetty-cmd/issuefile.c:250:25: warning[-Wanalyzer-possible-null-argument]: use of possibly-NULL ‘*ie.output’ where non-null expected
util-linux-2.43.devel/agetty-cmd/issuefile.c:9: included_from: Included from here.
/usr/include/stdio.h:616:12: note: argument 2 of ‘putc’ must be non-null
#  248|   			output_special_char(ie, fgetc(f), op, tp, f);
#  249|   		else
#  250|-> 			putc(c, ie->output);
#  251|   	}
#  252|   

Error: GCC_ANALYZER_WARNING (CWE-688): [#def3]
util-linux-2.43.devel/agetty-cmd/issuefile.c: scope_hint: In function ‘dump_iface_all’
util-linux-2.43.devel/agetty-cmd/issuefile.c:601:25: warning[-Wanalyzer-possible-null-argument]: use of possibly-NULL ‘*ie.output’ where non-null expected
util-linux-2.43.devel/include/netlink.h:28: included_from: Included from here.
util-linux-2.43.devel/include/netaddrq.h:17: included_from: Included from here.
util-linux-2.43.devel/agetty-cmd/agetty.h:34: included_from: Included from here.
util-linux-2.43.devel/agetty-cmd/issuefile.c:19: included_from: Included from here.
util-linux-2.43.devel/include/netaddrq.h:62:46: note: in expansion of macro ‘list_for_each’
util-linux-2.43.devel/agetty-cmd/issuefile.c:843:17: note: in expansion of macro ‘list_for_each_netaddrq_iface’
/usr/include/stdio.h:364:12: note: argument 1 of ‘fprintf’ must be non-null
#  599|   		if (first)
#  600|   		{
#  601|-> 			fprintf(ie->output, "%s: ", ifaceq->ifname);
#  602|   			first = false;
#  603|   		}

Error: GCC_ANALYZER_WARNING (CWE-688): [#def4]
util-linux-2.43.devel/agetty-cmd/issuefile.c:613:25: warning[-Wanalyzer-possible-null-argument]: use of possibly-NULL ‘*ie.output’ where non-null expected
util-linux-2.43.devel/include/netaddrq.h:62:46: note: in expansion of macro ‘list_for_each’
util-linux-2.43.devel/agetty-cmd/issuefile.c:843:17: note: in expansion of macro ‘list_for_each_netaddrq_iface’
util-linux-2.43.devel/agetty-cmd/issuefile.c:596:9: note: in expansion of macro ‘list_for_each’
util-linux-2.43.devel/agetty-cmd/issuefile.c:608:9: note: in expansion of macro ‘list_for_each’
/usr/include/stdio.h:364:12: note: argument 1 of ‘fprintf’ must be non-null
#  611|   		if (first)
#  612|   		{
#  613|-> 			fprintf(ie->output, "%s: ", ifaceq->ifname);
#  614|   			first = false;
#  615|   		}

Error: GCC_ANALYZER_WARNING (CWE-688): [#def5]
util-linux-2.43.devel/agetty-cmd/issuefile.c: scope_hint: In function ‘output_special_char’
util-linux-2.43.devel/agetty-cmd/issuefile.c:673:25: warning[-Wanalyzer-possible-null-argument]: use of possibly-NULL ‘*ie.output’ where non-null expected
<built-in>: note: argument 2 of ‘__builtin_fputc’ must be non-null
#  671|   			}
#  672|   		} else
#  673|-> 			fputs("\033", ie->output);
#  674|   		break;
#  675|   	}

Error: GCC_ANALYZER_WARNING (CWE-688): [#def6]
util-linux-2.43.devel/agetty-cmd/issuefile.c:748:17: warning[-Wanalyzer-possible-null-argument]: use of possibly-NULL ‘*ie.output’ where non-null expected
<built-in>: note: argument 2 of ‘__builtin_fputs’ must be non-null
#  746|   	}
#  747|   	case 'l':
#  748|-> 		fprintf (ie->output, "%s", op->tty);
#  749|   		break;
#  750|   	case 'b':

Error: GCC_ANALYZER_WARNING (CWE-688): [#def7]
util-linux-2.43.devel/agetty-cmd/issuefile.c:853:17: warning[-Wanalyzer-possible-null-argument]: use of possibly-NULL ‘*ie.output’ where non-null expected
/usr/include/stdio.h:616:12: note: argument 2 of ‘putc’ must be non-null
#  851|   #endif /* USE_NETLINK */
#  852|   	default:
#  853|-> 		putc(c, ie->output);
#  854|   		break;
#  855|   	}

Error: GCC_ANALYZER_WARNING (CWE-775): [#def8]
util-linux-2.43.devel/agetty-cmd/tty.c: scope_hint: In function ‘agetty_open_tty’
util-linux-2.43.devel/agetty-cmd/tty.c:314:12: warning[-Wanalyzer-fd-leak]: leak of file descriptor ‘dup(0)’
#  312|   
#  313|   	/* set up stdout and stderr */
#  314|-> 	if (dup(STDIN_FILENO) != 1 || dup(STDIN_FILENO) != 2)
#  315|   		agetty_log_err(_("%s: dup problem: %m"), tty);
#  316|   

Error: GCC_ANALYZER_WARNING (CWE-775): [#def9]
util-linux-2.43.devel/agetty-cmd/tty.c:314:36: warning[-Wanalyzer-fd-leak]: leak of file descriptor ‘dup(0)’
#  312|   
#  313|   	/* set up stdout and stderr */
#  314|-> 	if (dup(STDIN_FILENO) != 1 || dup(STDIN_FILENO) != 2)
#  315|   		agetty_log_err(_("%s: dup problem: %m"), tty);
#  316|   

Error: GCC_ANALYZER_WARNING (CWE-476): [#def10]
util-linux-2.43.devel/disk-utils/cfdisk.c: scope_hint: In function ‘ui_create_label’
util-linux-2.43.devel/disk-utils/cfdisk.c:2174:30: warning[-Wanalyzer-null-dereference]: dereference of NULL ‘xcalloc(fdisk_get_nlabels(*cf.cxt) + 1, 32) + i * 32’
util-linux-2.43.devel/include/debug.h:118:17: note: in expansion of macro ‘__UL_INIT_DEBUG_FROM_STRING’
util-linux-2.43.devel/disk-utils/cfdisk.c:270:9: note: in expansion of macro ‘__UL_INIT_DEBUG_FROM_ENV’
util-linux-2.43.devel/include/debug.h:118:17: note: in expansion of macro ‘__UL_INIT_DEBUG_FROM_STRING’
util-linux-2.43.devel/disk-utils/cfdisk.c:270:9: note: in expansion of macro ‘__UL_INIT_DEBUG_FROM_ENV’
util-linux-2.43.devel/include/debug.h:82:9: note: in expansion of macro ‘__UL_DBG_CALL’
util-linux-2.43.devel/include/debug.h:88:9: note: in expansion of macro ‘__UL_DBG_OBJ’
util-linux-2.43.devel/disk-utils/cfdisk.c:266:25: note: in expansion of macro ‘__UL_DBG’
util-linux-2.43.devel/disk-utils/cfdisk.c:2162:9: note: in expansion of macro ‘DBG’
# 2172|   		    fdisk_label_get_type(lb) == FDISK_DISKLABEL_BSD)
# 2173|   			continue;
# 2174|-> 		cm[i++].name = fdisk_label_get_name(lb);
# 2175|   	}
# 2176|   

Error: GCC_ANALYZER_WARNING (CWE-476): [#def11]
util-linux-2.43.devel/disk-utils/fdformat.c: scope_hint: In function ‘verify_disk’
util-linux-2.43.devel/disk-utils/fdformat.c:129:49: warning[-Wanalyzer-possible-null-dereference]: dereference of possibly-NULL ‘xmalloc(track_size) + count’
util-linux-2.43.devel/disk-utils/fdformat.c:28: included_from: Included from here.
#  127|   				}
#  128|   				for (count = 0; count < track_size; count++)
#  129|-> 					if (data[count] != FD_FILL_BYTE) {
#  130|   						if (retries_left) {
#  131|   							format_begin(ctrl);

Error: COMPILER_WARNING: [#def12]
util-linux-2.43.devel/agetty-cmd/agetty.c:30: included_from: Included from here.
util-linux-2.43.devel/include/logindefs.h:36:40: warning: ‘struct passwd’ declared inside parameter list will not be visible outside of this definition or declaration
#   34|   
#   35|   extern int effective_access(const char *path, int mode);
#   36|-> extern int get_hushlogin_status(struct passwd *pwd, const char *override_home, int force_check);
#   37|   
#   38|   #endif /* UTIL_LINUX_LOGINDEFS_H */

Error: GCC_ANALYZER_WARNING (CWE-476): [#def13]
util-linux-2.43.devel/misc-utils/cal.c: scope_hint: In function ‘monthly’
util-linux-2.43.devel/misc-utils/cal.c:1099:28: warning[-Wanalyzer-null-dereference]: dereference of NULL ‘xcalloc((long unsigned int)*ctl.months_in_row, 208) + (sizetype)i * 208’
util-linux-2.43.devel/misc-utils/cal.c:79: included_from: Included from here.
# 1097|   
# 1098|   	for (i = 0; i < ctl->months_in_row - 1; i++)
# 1099|-> 		ms[i].next = &ms[i + 1];
# 1100|   
# 1101|   	rows = (ctl->num_months - 1) / ctl->months_in_row;

Scan Properties