Task #114195 - added.err
back to task #114195download
Error: CLIPPY_WARNING:
crates/lib/src/bootc_composefs/backwards_compat/bcompat_boot.rs:229:20: warning: useless conversion to the same type: `std::string::String`
# |
# 229 | fixed.push(digest.into());
# | ^^^^^^^^^^^^^ help: consider removing `.into()`: `digest`
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.95.0/index.html#useless_conversion
# = note: `#[warn(clippy::useless_conversion)]` on by default
Error: CLIPPY_WARNING:
crates/lib/src/bootc_composefs/backwards_compat/bcompat_boot.rs:261:26: warning: useless use of `format!`
# |
# 261 | .with_context(|| format!("Failed to parse origin as ini"))?;
# | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Failed to parse origin as ini".to_string()`
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.95.0/index.html#useless_format
# = note: `#[warn(clippy::useless_format)]` on by default
Error: CLIPPY_WARNING:
crates/lib/src/bootc_composefs/backwards_compat/bcompat_boot.rs:292:9: warning: returning the result of a `let` binding from a block
# |
# 290 | let uki_dir = esp.fd.open_dir(BOOTC_UKI_DIR).context("Opening UKI dir")?;
# | ------------------------------------------------------------------------- unnecessary `let` binding
# 291 |
# 292 | uki_dir
# | ^^^^^^^
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.95.0/index.html#let_and_return
# = note: `#[warn(clippy::let_and_return)]` on by default
# help: return the expression directly
# |
# 290 ~
# 291 |
# 292 ~ esp.fd.open_dir(BOOTC_UKI_DIR).context("Opening UKI dir")?
# |
Error: CLIPPY_WARNING:
crates/lib/src/bootc_composefs/boot.rs:1300:9: warning: unnecessary use of `to_string`
# |
# 1300 | &pull_result.manifest_digest.to_string(),
# | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `pull_result.manifest_digest.as_ref()`
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.95.0/index.html#unnecessary_to_owned
# = note: `#[warn(clippy::unnecessary_to_owned)]` on by default
Error: CLIPPY_WARNING:
crates/lib/src/bootc_composefs/gc.rs:392:51: warning: unnecessary use of `to_string`
# |
# 392 | let expected_tag = bootc_tag_for_manifest(&manifest_digest.to_string());
# | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `manifest_digest.as_ref()`
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.95.0/index.html#unnecessary_to_owned
Error: CLIPPY_WARNING:
crates/lib/src/bootc_composefs/repo.rs:116:38: warning: unnecessary use of `to_string`
# |
# 116 | let tag = bootc_tag_for_manifest(&pull_result.manifest_digest.to_string());
# | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `pull_result.manifest_digest.as_ref()`
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.95.0/index.html#unnecessary_to_owned
Error: CLIPPY_WARNING:
crates/lib/src/bootc_composefs/repo.rs:283:38: warning: unnecessary use of `to_string`
# |
# 283 | let tag = bootc_tag_for_manifest(&pull_result.manifest_digest.to_string());
# | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `pull_result.manifest_digest.as_ref()`
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.95.0/index.html#unnecessary_to_owned
Error: CLIPPY_WARNING:
crates/lib/src/bootc_composefs/update.rs:524:53: warning: deref which would be done by auto-deref
# |
# 524 | let current_manifest = get_imginfo(storage, &*composefs.cmdline.digest)?;
# | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&composefs.cmdline.digest`
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.95.0/index.html#explicit_auto_deref
Error: CLIPPY_WARNING:
crates/lib/src/podman_client.rs:236:61: warning: redundant closure
# |
# 236 | Ok(frame) => frame.into_data().ok().map(|b| Ok::<_, std::io::Error>(b)),
# | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `Ok::<_, std::io::Error>`
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.95.0/index.html#redundant_closure
# = note: `#[warn(clippy::redundant_closure)]` on by default
Error: CLIPPY_WARNING:
crates/xtask/src/xtask.rs:303:9: warning: this `if` statement can be collapsed
# |
# 303 | / if let Ok(toplevel_path) = Command::new("git")
# 304 | | .args(["rev-parse", "--show-toplevel"])
# 305 | | .output()
# ... |
# 311 | | }
# | |_________^
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.95.0/index.html#collapsible_if
# help: collapse nested if block
# |
# 305 ~ .output()
# 306 ~ && toplevel_path.status.success() {
# 307 | let path = String::from_utf8(toplevel_path.stdout)?;
# 308 | std::env::set_current_dir(path.trim()).context("Changing to toplevel")?;
# 309 ~ }
# |
Error: CLIPPY_WARNING:
crates/xtask/src/xtask.rs:523:13: warning: this `if` statement can be collapsed
# |
# 523 | / if let Some(name) = name.to_str() {
# 524 | | if name.ends_with(".src.rpm") {
# 525 | | sh.remove_path(name)?;
# 526 | | }
# 527 | | }
# | |_____________^
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.95.0/index.html#collapsible_if
# help: collapse nested if block
# |
# 523 ~ if let Some(name) = name.to_str()
# 524 ~ && name.ends_with(".src.rpm") {
# 525 | sh.remove_path(name)?;
# 526 ~ }
# |