Fixed findings

List of Findings

Error: CPPCHECK_WARNING (CWE-398): [#def1]
avahi-0.9.rc4/avahi-core/dns-test.c:50: warning[assignmentInAssert]: Assert statement modifies 'a'.
#   48|       p = avahi_dns_packet_new(0);
#   49|   
#   50|->     assert(avahi_dns_packet_append_name(p, a = "Ahello.hello.hello.de."));
#   51|       assert(avahi_dns_packet_append_name(p, b = "Bthis is a test.hello.de."));
#   52|       assert(avahi_dns_packet_append_name(p, c = "Cthis\\.is\\.a\\.test\\.with\\.dots.hello.de."));

Error: CPPCHECK_WARNING (CWE-398): [#def2]
avahi-0.9.rc4/avahi-core/dns-test.c:51: warning[assignmentInAssert]: Assert statement modifies 'b'.
#   49|   
#   50|       assert(avahi_dns_packet_append_name(p, a = "Ahello.hello.hello.de."));
#   51|->     assert(avahi_dns_packet_append_name(p, b = "Bthis is a test.hello.de."));
#   52|       assert(avahi_dns_packet_append_name(p, c = "Cthis\\.is\\.a\\.test\\.with\\.dots.hello.de."));
#   53|       assert(avahi_dns_packet_append_name(p, d = "Dthis\\\\is another test.hello.de."));

Error: CPPCHECK_WARNING (CWE-398): [#def3]
avahi-0.9.rc4/avahi-core/dns-test.c:52: warning[assignmentInAssert]: Assert statement modifies 'c'.
#   50|       assert(avahi_dns_packet_append_name(p, a = "Ahello.hello.hello.de."));
#   51|       assert(avahi_dns_packet_append_name(p, b = "Bthis is a test.hello.de."));
#   52|->     assert(avahi_dns_packet_append_name(p, c = "Cthis\\.is\\.a\\.test\\.with\\.dots.hello.de."));
#   53|       assert(avahi_dns_packet_append_name(p, d = "Dthis\\\\is another test.hello.de."));
#   54|   

Error: CPPCHECK_WARNING (CWE-398): [#def4]
avahi-0.9.rc4/avahi-core/dns-test.c:53: warning[assignmentInAssert]: Assert statement modifies 'd'.
#   51|       assert(avahi_dns_packet_append_name(p, b = "Bthis is a test.hello.de."));
#   52|       assert(avahi_dns_packet_append_name(p, c = "Cthis\\.is\\.a\\.test\\.with\\.dots.hello.de."));
#   53|->     assert(avahi_dns_packet_append_name(p, d = "Dthis\\\\is another test.hello.de."));
#   54|   
#   55|       avahi_hexdump(AVAHI_DNS_PACKET_DATA(p), p->size);

Error: CPPCHECK_WARNING (CWE-398): [#def5]
avahi-0.9.rc4/avahi-core/dns-test.c:84: warning[assignmentInAssert]: Assert statement modifies 'l'.
#   82|   
#   83|       /* Serialize it into a blob */
#   84|->     assert((l = avahi_rdata_serialize(r, rdata, sizeof(rdata))) != (size_t) -1);
#   85|   
#   86|       /* Print it */

Error: COMPILER_WARNING (CWE-569): [#def6]
avahi-0.9.rc4/avahi-core/dns-test.c: scope_hint: In function ‘main’
avahi-0.9.rc4/avahi-core/dns-test.c:104:5: warning[-Wparentheses]: suggest parentheses around assignment used as truth value
#  104 |     assert(r->data.generic.data = avahi_memdup("HALLO", r->data.generic.size = 5));
#      |     ^~~~~~
#  102|       assert(r);
#  103|   
#  104|->     assert(r->data.generic.data = avahi_memdup("HALLO", r->data.generic.size = 5));
#  105|   
#  106|       m = avahi_record_to_string(r);

Scan Properties