Newly introduced findings

List of Findings

Error: CLIPPY_WARNING: [#def1]
crates/openshell-bootstrap/src/docker.rs:271:1: warning: pub(crate) function inside private module
#      |
#  271 | pub(crate) fn connect_local_auto() -> Result<Docker> {
#      | ----------^^^^^^^^^^^^^^^^^^^^^^
#      | |
#      | help: consider using: `pub`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#redundant_pub_crate

Error: CLIPPY_WARNING: [#def2]
crates/openshell-bootstrap/src/lib.rs:673:27: warning: called `map(<f>).unwrap_or_else(<g>)` on an `Option` value
#      |
#  673 |               let runtime = get_gateway_metadata(name)
#      |  ___________________________^
#  674 | |                 .map(|m| m.container_runtime)
#  675 | |                 .unwrap_or_else(|| detect_runtime(None).unwrap_or(ContainerRuntime::Docker));
#      | |____________________________________________________________________________________________^ help: try: `get_gateway_metadata(name).map_or_else(|| detect_runtime(None).unwrap_or(ContainerRuntime::Docker), |m| m.container_runtime)`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#map_unwrap_or

Error: CLIPPY_WARNING: [#def3]
crates/openshell-bootstrap/src/lib.rs:721:27: warning: called `map(<f>).unwrap_or_else(<g>)` on an `Option` value
#      |
#  721 |               let runtime = get_gateway_metadata(name)
#      |  ___________________________^
#  722 | |                 .map(|m| m.container_runtime)
#  723 | |                 .unwrap_or_else(|| detect_runtime(None).unwrap_or(ContainerRuntime::Docker));
#      | |____________________________________________________________________________________________^ help: try: `get_gateway_metadata(name).map_or_else(|| detect_runtime(None).unwrap_or(ContainerRuntime::Docker), |m| m.container_runtime)`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#map_unwrap_or

Error: CLIPPY_WARNING: [#def4]
crates/openshell-tui/src/lib.rs:2033:17: warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
#       |
#  2033 | /                 match openshell_core::settings::parse_bool_like(&raw) {
#  2034 | |                     Some(v) => setting_value::Value::BoolValue(v),
#  2035 | |                     None => {
#  2036 | |                         let _ = tx.send(Event::SandboxSettingSetResult(Err(format!(
#  ...    |
#  2041 | |                 }
#       | |_________________^
#       |
#       = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#single_match_else
#  help: try
#       |
#  2033 ~                 if let Some(v) = openshell_core::settings::parse_bool_like(&raw) { setting_value::Value::BoolValue(v) } else {
#  2034 +                     let _ = tx.send(Event::SandboxSettingSetResult(Err(format!(
#  2035 +                         "invalid bool value: {raw}"
#  2036 +                     ))));
#  2037 +                     return;
#  2038 +                 }
#       |

Error: CLIPPY_WARNING: [#def5]
crates/openshell-tui/src/lib.rs:2043:64: warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
#       |
#  2043 |               openshell_core::settings::SettingValueKind::Int => match raw.parse::<i64>() {
#       |  ________________________________________________________________^
#  2044 | |                 Ok(v) => setting_value::Value::IntValue(v),
#  2045 | |                 Err(_) => {
#  2046 | |                     let _ = tx.send(Event::SandboxSettingSetResult(Err(format!(
#  ...    |
#  2051 | |             },
#       | |_____________^
#       |
#       = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#single_match_else
#  help: try
#       |
#  2043 ~             openshell_core::settings::SettingValueKind::Int => if let Ok(v) = raw.parse::<i64>() { setting_value::Value::IntValue(v) } else {
#  2044 +                 let _ = tx.send(Event::SandboxSettingSetResult(Err(format!(
#  2045 +                     "invalid int value: {raw}"
#  2046 +                 ))));
#  2047 +                 return;
#  2048 ~             },
#       |

Scan Properties