Task #108014 - added.err
back to task #108014download
Error: CLIPPY_WARNING:
crates/blockdev/src/blockdev.rs:142:9: warning: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)`
# |
# 142 | / self.find_colocated_esps()?
# 143 | | .and_then(|mut v| Some(v.remove(0)))
# | |________________________________________________^ help: try: `self.find_colocated_esps()?.map(|mut v| v.remove(0))`
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#bind_instead_of_map
# = note: `#[warn(clippy::bind_instead_of_map)]` on by default
Error: CLIPPY_WARNING:
crates/lib/src/bootc_composefs/boot.rs:1303:9: warning: unnecessary use of `to_string`
# |
# 1303 | &pull_result.manifest_digest.to_string(),
# | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `pull_result.manifest_digest.as_ref()`
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#unnecessary_to_owned
# = note: `#[warn(clippy::unnecessary_to_owned)]` on by default
Error: CLIPPY_WARNING:
crates/lib/src/bootc_composefs/gc.rs:388:51: warning: unnecessary use of `to_string`
# |
# 388 | let expected_tag = bootc_tag_for_manifest(&manifest_digest.to_string());
# | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `manifest_digest.as_ref()`
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#unnecessary_to_owned
Error: CLIPPY_WARNING:
crates/lib/src/bootc_composefs/repo.rs:88:38: warning: unnecessary use of `to_string`
# |
# 88 | let tag = bootc_tag_for_manifest(&pull_result.manifest_digest.to_string());
# | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `pull_result.manifest_digest.as_ref()`
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#unnecessary_to_owned
Error: CLIPPY_WARNING:
crates/lib/src/bootc_composefs/repo.rs:264:38: warning: unnecessary use of `to_string`
# |
# 264 | let tag = bootc_tag_for_manifest(&pull_result.manifest_digest.to_string());
# | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `pull_result.manifest_digest.as_ref()`
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#unnecessary_to_owned
Error: CLIPPY_WARNING:
crates/lib/src/podman_client.rs:219:30: warning: redundant closure
# |
# 219 | .map(|b| Ok::<_, std::io::Error>(b)),
# | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `Ok::<_, std::io::Error>`
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#redundant_closure
# = note: `#[warn(clippy::redundant_closure)]` on by default
Error: CLIPPY_WARNING:
crates/xtask/src/xtask.rs:242:9: warning: this `if` statement can be collapsed
# |
# 242 | / if let Ok(toplevel_path) = Command::new("git")
# 243 | | .args(["rev-parse", "--show-toplevel"])
# 244 | | .output()
# ... |
# 250 | | }
# | |_________^
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#collapsible_if
# help: collapse nested if block
# |
# 244 ~ .output()
# 245 ~ && toplevel_path.status.success() {
# 246 | let path = String::from_utf8(toplevel_path.stdout)?;
# 247 | std::env::set_current_dir(path.trim()).context("Changing to toplevel")?;
# 248 ~ }
# |
Error: CLIPPY_WARNING:
crates/xtask/src/xtask.rs:436:13: warning: this `if` statement can be collapsed
# |
# 436 | / if let Some(name) = name.to_str() {
# 437 | | if name.ends_with(".src.rpm") {
# 438 | | sh.remove_path(name)?;
# 439 | | }
# 440 | | }
# | |_____________^
# |
# = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#collapsible_if
# help: collapse nested if block
# |
# 436 ~ if let Some(name) = name.to_str()
# 437 ~ && name.ends_with(".src.rpm") {
# 438 | sh.remove_path(name)?;
# 439 ~ }
# |