Fixed findings

List of Findings

Error: CLIPPY_WARNING: [#def1]
crates/openshell-bootstrap/src/docker.rs:545:1: warning: this function has too many arguments (12/7)
#      |
#  545 | / pub async fn ensure_container(
#  546 | |     docker: &Docker,
#  547 | |     name: &str,
#  548 | |     image_ref: &str,
#  ...   |
#  557 | |     runtime: ContainerRuntime,
#  558 | | ) -> Result<u16> {
#      | |________________^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#too_many_arguments
#      = note: `-W clippy::too-many-arguments` implied by `-W clippy::all`
#      = help: to override `-W clippy::all` add `#[allow(clippy::too_many_arguments)]`

Error: CLIPPY_WARNING: [#def2]
crates/openshell-cli/src/main.rs:1596:17: warning: large future with a size of 16776 bytes
#       |
#  1596 | /                 run::gateway_admin_deploy(
#  1597 | |                     &name,
#  1598 | |                     remote.as_deref(),
#  1599 | |                     ssh_key.as_deref(),
#  ...    |
#  1608 | |                     cli.container_runtime.as_deref(),
#  1609 | |                 )
#       | |_________________^
#       |
#       = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#large_futures
#       = note: `-W clippy::large-futures` implied by `-W clippy::pedantic`
#       = help: to override `-W clippy::pedantic` add `#[allow(clippy::large_futures)]`
#  help: consider `Box::pin` on it
#       |
#  1596 ~                 Box::pin(run::gateway_admin_deploy(
#  1597 +                     &name,
#  1598 +                     remote.as_deref(),
#  1599 +                     ssh_key.as_deref(),
#  1600 +                     port,
#  1601 +                     gateway_host.as_deref(),
#  1602 +                     recreate,
#  1603 +                     plaintext,
#  1604 +                     disable_gateway_auth,
#  1605 +                     registry_username.as_deref(),
#  1606 +                     registry_token.as_deref(),
#  1607 +                     gpu,
#  1608 +                     cli.container_runtime.as_deref(),
#  1609 +                 ))
#       |

Error: CLIPPY_WARNING: [#def3]
crates/openshell-cli/src/run.rs:1897:9: warning: large future with a size of 16992 bytes
#       |
#  1897 |         crate::bootstrap::run_bootstrap(remote, ssh_key, requested_gpu).await?;
#       |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider `Box::pin` on it: `Box::pin(crate::bootstrap::run_bootstrap(remote, ssh_key, requested_gpu))`
#       |
#       = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#large_futures
#       = note: `-W clippy::large-futures` implied by `-W clippy::pedantic`
#       = help: to override `-W clippy::pedantic` add `#[allow(clippy::large_futures)]`

Error: CLIPPY_WARNING: [#def4]
crates/openshell-cli/src/run.rs:1900:5: warning: large future with a size of 19616 bytes
#       |
#  1900 | /     sandbox_create(
#  1901 | |         &server,
#  1902 | |         name,
#  1903 | |         from,
#  ...    |
#  1918 | |         &tls,
#  1919 | |     )
#       | |_____^
#       |
#       = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#large_futures
#  help: consider `Box::pin` on it
#       |
#  1900 ~     Box::pin(sandbox_create(
#  1901 +         &server,
#  1902 +         name,
#  1903 +         from,
#  1904 +         &gateway_name,
#  1905 +         upload,
#  1906 +         keep,
#  1907 +         gpu,
#  1908 +         editor,
#  1909 +         remote,
#  1910 +         ssh_key,
#  1911 +         providers,
#  1912 +         policy,
#  1913 +         forward,
#  1914 +         command,
#  1915 +         tty_override,
#  1916 +         Some(false),
#  1917 +         auto_providers_override,
#  1918 +         &tls,
#  1919 +     ))
#       |

Error: CLIPPY_WARNING: [#def5]
crates/openshell-cli/src/run.rs:2022:17: warning: large future with a size of 16992 bytes
#       |
#  2022 |                 crate::bootstrap::run_bootstrap(remote, ssh_key, requested_gpu).await?;
#       |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider `Box::pin` on it: `Box::pin(crate::bootstrap::run_bootstrap(remote, ssh_key, requested_gpu))`
#       |
#       = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#large_futures

Error: CLIPPY_WARNING: [#def6]
crates/openshell-policy/src/lib.rs:104:15: warning: this argument (4 byte) is passed by reference, but would be more efficient if passed by value (limit: 8 byte)
#      |
#  104 | fn is_zero(v: &u32) -> bool {
#      |               ^^^^ help: consider passing by value instead: `u32`
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#trivially_copy_pass_by_ref
#      = note: `-W clippy::trivially-copy-pass-by-ref` implied by `-W clippy::pedantic`
#      = help: to override `-W clippy::pedantic` add `#[allow(clippy::trivially_copy_pass_by_ref)]`

Scan Properties

analyzer-version-clippy1.94.1
analyzer-version-cppcheck2.20.0
analyzer-version-gcc16.0.1
analyzer-version-gcc-analyzer16.0.1
analyzer-version-shellcheck0.11.0
analyzer-version-unicontrol0.0.2
diffbase-analyzer-version-clippy1.94.1
diffbase-analyzer-version-cppcheck2.20.0
diffbase-analyzer-version-gcc16.0.1
diffbase-analyzer-version-gcc-analyzer16.0.1
diffbase-analyzer-version-shellcheck0.11.0
diffbase-analyzer-version-unicontrol0.0.2
diffbase-enabled-pluginsclippy, cppcheck, gcc, shellcheck, unicontrol
diffbase-exit-code0
diffbase-hostip-172-16-1-91.us-west-2.compute.internal
diffbase-known-false-positives/usr/share/csmock/known-false-positives.js
diffbase-known-false-positives-rpmknown-false-positives-0.0.0.20260320.200800.gd35503f.main-1.el9.noarch
diffbase-mock-configfedora-rawhide-x86_64
diffbase-project-nameopenshell-0.0.21-1.20260406223917424056.pr21.75.g9ac1ab8
diffbase-store-results-to/tmp/tmpgy68ochz/openshell-0.0.21-1.20260406223917424056.pr21.75.g9ac1ab8.tar.xz
diffbase-time-created2026-04-06 23:17:58
diffbase-time-finished2026-04-06 23:33:56
diffbase-toolcsmock
diffbase-tool-args'/usr/bin/csmock' '-r' 'fedora-rawhide-x86_64' '-t' 'cppcheck,gcc,shellcheck,clippy,unicontrol' '-o' '/tmp/tmpgy68ochz/openshell-0.0.21-1.20260406223917424056.pr21.75.g9ac1ab8.tar.xz' '--gcc-analyze' '--unicontrol-notests' '--unicontrol-bidi-only' '--install' 'pam' '/tmp/tmpgy68ochz/openshell-0.0.21-1.20260406223917424056.pr21.75.g9ac1ab8.src.rpm'
diffbase-tool-versioncsmock-3.8.4.20260302.153719.g8203630-1.el9
enabled-pluginsclippy, cppcheck, gcc, shellcheck, unicontrol
exit-code0
hostip-172-16-1-91.us-west-2.compute.internal
known-false-positives/usr/share/csmock/known-false-positives.js
known-false-positives-rpmknown-false-positives-0.0.0.20260320.200800.gd35503f.main-1.el9.noarch
mock-configfedora-rawhide-x86_64
project-nameopenshell-0.0.21-1.20260406205235926512.midstream.73.g8592ab0
store-results-to/tmp/tmptqag_i0b/openshell-0.0.21-1.20260406205235926512.midstream.73.g8592ab0.tar.xz
time-created2026-04-06 23:00:33
time-finished2026-04-06 23:17:01
titleFixed findings
toolcsmock
tool-args'/usr/bin/csmock' '-r' 'fedora-rawhide-x86_64' '-t' 'cppcheck,gcc,shellcheck,clippy,unicontrol' '-o' '/tmp/tmptqag_i0b/openshell-0.0.21-1.20260406205235926512.midstream.73.g8592ab0.tar.xz' '--gcc-analyze' '--unicontrol-notests' '--unicontrol-bidi-only' '--install' 'pam' '/tmp/tmptqag_i0b/openshell-0.0.21-1.20260406205235926512.midstream.73.g8592ab0.src.rpm'
tool-versioncsmock-3.8.4.20260302.153719.g8203630-1.el9