Task #108 - libreport-2.17.15-1.fc41/scan-results.err
back to task #108download
Error: GCC_ANALYZER_WARNING (CWE-775): libreport-2.17.15/src/cli/cli-report.c: scope_hint: In function ‘run_report_editor’ libreport-2.17.15/src/cli/cli-report.c:381:9: warning[-Wanalyzer-file-leak]: leak of FILE ‘fopen(&filename, "r")’ libreport-2.17.15/src/cli/cli-report.c: scope_hint: In function ‘run_report_editor’ libreport-2.17.15/src/cli/cli-report.c: scope_hint: In function ‘run_report_editor’ libreport-2.17.15/src/cli/cli-report.c: scope_hint: In function ‘run_report_editor’ # 379| size = INT_MAX/4; /* paranoia */ # 380| g_autofree char *text = g_malloc(size + 1); # 381|-> if (fread(text, 1, size, fp) != size) # 382| { # 383| error_msg("Can't read '%s'", filename); Error: GCC_ANALYZER_WARNING (CWE-401): libreport-2.17.15/src/cli/cli-report.c:381:9: warning[-Wanalyzer-malloc-leak]: leak of ‘fopen(&filename, "r")’ libreport-2.17.15/src/cli/cli-report.c: scope_hint: In function ‘run_report_editor’ libreport-2.17.15/src/cli/cli-report.c: scope_hint: In function ‘run_report_editor’ libreport-2.17.15/src/cli/cli-report.c: scope_hint: In function ‘run_report_editor’ # 379| size = INT_MAX/4; /* paranoia */ # 380| g_autofree char *text = g_malloc(size + 1); # 381|-> if (fread(text, 1, size, fp) != size) # 382| { # 383| error_msg("Can't read '%s'", filename); Error: CPPCHECK_WARNING (CWE-457): libreport-2.17.15/src/cli/cli-report.c:845: warning[uninitvar]: Uninitialized variable: help_wf_array # 843| # 844| const unsigned picked = choose_number_from_range(1, count, _("Select a workflow to run: ")); # 845|-> return help_wf_array[picked - 1]; # 846| } # 847| Error: CLANG_WARNING: libreport-2.17.15/src/cli/cli.c:121:5: warning[deadcode.DeadStores]: Value stored to 'argc' is never read # 119| # 120| argv += optind; # 121|-> argc -= optind; # 122| # 123| if (op == OPT_version) Error: COMPILER_WARNING (CWE-477): libreport-2.17.15/src/lib/curl.c: scope_hint: In function 'post' libreport-2.17.15/src/lib/curl.c:426:9: warning[-Wdeprecated-declarations]: 'curl_formadd' is deprecated: since 7.56.0. Use curl_mime_init() # 426 | CURLFORMcode curlform_err = curl_formadd(&post, &last, # | ^~~~~~~~~~~~ libreport-2.17.15/src/include/libreport_curl.h:22: included_from: Included from here. libreport-2.17.15/src/lib/curl.c:21: included_from: Included from here. /usr/include/curl/curl.h:2581:1: note: declared here # 2581 | curl_formadd(struct curl_httppost **httppost, # | ^~~~~~~~~~~~ # 424| fseeko(data_file, 0, SEEK_SET); # 425| // Create formdata # 426|-> CURLFORMcode curlform_err = curl_formadd(&post, &last, # 427| CURLFORM_PTRNAME, "file", // element name # 428| // use CURLOPT_READFUNCTION for reading, pass data_file as its last param: Error: COMPILER_WARNING (CWE-477): libreport-2.17.15/src/lib/curl.c:427:25: warning[-Wdeprecated-declarations]: 'CURLFORM_PTRNAME' is deprecated: since 7.56.0. Use curl_mime_name() # 427 | CURLFORM_PTRNAME, "file", // element name # | ^~~~~~~~~~~~~~~~ /usr/include/curl/curl.h:2507:3: note: declared here # 2507 | CURLFORM_PTRNAME CURL_DEPRECATED(7.56.0, "Use curl_mime_name()"), # | ^~~~~~~~~~~~~~~~ # 425| // Create formdata # 426| CURLFORMcode curlform_err = curl_formadd(&post, &last, # 427|-> CURLFORM_PTRNAME, "file", // element name # 428| // use CURLOPT_READFUNCTION for reading, pass data_file as its last param: # 429| CURLFORM_STREAM, data_file, Error: COMPILER_WARNING (CWE-477): libreport-2.17.15/src/lib/curl.c:429:25: warning[-Wdeprecated-declarations]: 'CURLFORM_STREAM' is deprecated: since 7.56.0. Use curl_mime_data_cb() # 429 | CURLFORM_STREAM, data_file, # | ^~~~~~~~~~~~~~~ /usr/include/curl/curl.h:2527:3: note: declared here # 2527 | CURLFORM_STREAM CURL_DEPRECATED(7.56.0, "Use curl_mime_data_cb()"), # | ^~~~~~~~~~~~~~~ # 427| CURLFORM_PTRNAME, "file", // element name # 428| // use CURLOPT_READFUNCTION for reading, pass data_file as its last param: # 429|-> CURLFORM_STREAM, data_file, # 430| CURLFORM_CONTENTSLENGTH, (long)sz, // a must if we use CURLFORM_STREAM option # 431| //FIXME: what if file size doesn't fit in long? Error: COMPILER_WARNING (CWE-477): libreport-2.17.15/src/lib/curl.c:430:25: warning[-Wdeprecated-declarations]: 'CURLFORM_CONTENTSLENGTH' is deprecated: since 7.56.0. Use curl_mime_data() # 430 | CURLFORM_CONTENTSLENGTH, (long)sz, // a must if we use CURLFORM_STREAM option # | ^~~~~~~~~~~~~~~~~~~~~~~ /usr/include/curl/curl.h:2511:3: note: declared here # 2511 | CURLFORM_CONTENTSLENGTH CURL_DEPRECATED(7.56.0, "Use curl_mime_data()"), # | ^~~~~~~~~~~~~~~~~~~~~~~ # 428| // use CURLOPT_READFUNCTION for reading, pass data_file as its last param: # 429| CURLFORM_STREAM, data_file, # 430|-> CURLFORM_CONTENTSLENGTH, (long)sz, // a must if we use CURLFORM_STREAM option # 431| //FIXME: what if file size doesn't fit in long? # 432| CURLFORM_CONTENTTYPE, content_type, Error: COMPILER_WARNING (CWE-477): libreport-2.17.15/src/lib/curl.c:432:25: warning[-Wdeprecated-declarations]: 'CURLFORM_CONTENTTYPE' is deprecated: since 7.56.0. Use curl_mime_type() # 432 | CURLFORM_CONTENTTYPE, content_type, # | ^~~~~~~~~~~~~~~~~~~~ /usr/include/curl/curl.h:2521:3: note: declared here # 2521 | CURLFORM_CONTENTTYPE CURL_DEPRECATED(7.56.0, "Use curl_mime_type()"), # | ^~~~~~~~~~~~~~~~~~~~ # 430| CURLFORM_CONTENTSLENGTH, (long)sz, // a must if we use CURLFORM_STREAM option # 431| //FIXME: what if file size doesn't fit in long? # 432|-> CURLFORM_CONTENTTYPE, content_type, # 433| CURLFORM_FILENAME, basename, // filename to put in the form # 434| CURLFORM_END); Error: COMPILER_WARNING (CWE-477): libreport-2.17.15/src/lib/curl.c:433:25: warning[-Wdeprecated-declarations]: 'CURLFORM_FILENAME' is deprecated: since 7.56.0. Use curl_mime_filename() # 433 | CURLFORM_FILENAME, basename, // filename to put in the form # | ^~~~~~~~~~~~~~~~~ /usr/include/curl/curl.h:2523:3: note: declared here # 2523 | CURLFORM_FILENAME CURL_DEPRECATED(7.56.0, "Use curl_mime_filename()"), # | ^~~~~~~~~~~~~~~~~ # 431| //FIXME: what if file size doesn't fit in long? # 432| CURLFORM_CONTENTTYPE, content_type, # 433|-> CURLFORM_FILENAME, basename, // filename to put in the form # 434| CURLFORM_END); # 435| Error: COMPILER_WARNING (CWE-477): libreport-2.17.15/src/lib/curl.c:439:9: warning[-Wdeprecated-declarations]: 'CURLOPT_HTTPPOST' is deprecated: since 7.56.0. Use CURLOPT_MIMEPOST # 439 | xcurl_easy_setopt_ptr(handle, CURLOPT_HTTPPOST, post); # | ^~~~~~~~~~~~~~~~~~~~~ /usr/include/curl/curl.h:1191:3: note: declared here # 1191 | CURLOPTDEPRECATED(CURLOPT_HTTPPOST, CURLOPTTYPE_OBJECTPOINT, 24, # | ^~~~~~~~~~~~~~~~~ # 437| //FIXME: # 438| error_msg_and_die("out of memory or read error (curl_formadd error code: %d)", (int)curlform_err); # 439|-> xcurl_easy_setopt_ptr(handle, CURLOPT_HTTPPOST, post); # 440| } # 441| else if (data_size == POST_DATA_STRING_AS_FORM_DATA) Error: COMPILER_WARNING (CWE-477): libreport-2.17.15/src/lib/curl.c:443:9: warning[-Wdeprecated-declarations]: 'curl_formadd' is deprecated: since 7.56.0. Use curl_mime_init() # 443 | CURLFORMcode curlform_err = curl_formadd(&post, &last, # | ^~~~~~~~~~~~ /usr/include/curl/curl.h:2581:1: note: declared here # 2581 | curl_formadd(struct curl_httppost **httppost, # | ^~~~~~~~~~~~ # 441| else if (data_size == POST_DATA_STRING_AS_FORM_DATA) # 442| { # 443|-> CURLFORMcode curlform_err = curl_formadd(&post, &last, # 444| CURLFORM_PTRNAME, "file", // element name # 445| // curl bug - missing filename Error: COMPILER_WARNING (CWE-477): libreport-2.17.15/src/lib/curl.c:444:25: warning[-Wdeprecated-declarations]: 'CURLFORM_PTRNAME' is deprecated: since 7.56.0. Use curl_mime_name() # 444 | CURLFORM_PTRNAME, "file", // element name # | ^~~~~~~~~~~~~~~~ /usr/include/curl/curl.h:2507:3: note: declared here # 2507 | CURLFORM_PTRNAME CURL_DEPRECATED(7.56.0, "Use curl_mime_name()"), # | ^~~~~~~~~~~~~~~~ # 442| { # 443| CURLFORMcode curlform_err = curl_formadd(&post, &last, # 444|-> CURLFORM_PTRNAME, "file", // element name # 445| // curl bug - missing filename # 446| // http://curl.haxx.se/mail/lib-2011-07/0176.html Error: COMPILER_WARNING (CWE-477): libreport-2.17.15/src/lib/curl.c:451:25: warning[-Wdeprecated-declarations]: 'CURLFORM_BUFFER' is deprecated: since 7.56.0. Use curl_mime_filename() # 451 | CURLFORM_BUFFER, "*buffer*", // provides filename # | ^~~~~~~~~~~~~~~ /usr/include/curl/curl.h:2517:3: note: declared here # 2517 | CURLFORM_BUFFER CURL_DEPRECATED(7.56.0, "Use curl_mime_filename()"), # | ^~~~~~~~~~~~~~~ # 449| // tested with curl-7.24.0-3 # 450| // should be working on F17 # 451|-> CURLFORM_BUFFER, "*buffer*", // provides filename # 452| CURLFORM_BUFFERPTR, data, # 453| CURLFORM_BUFFERLENGTH, (long)strlen(data), Error: COMPILER_WARNING (CWE-477): libreport-2.17.15/src/lib/curl.c:452:25: warning[-Wdeprecated-declarations]: 'CURLFORM_BUFFERPTR' is deprecated: since 7.56.0. Use curl_mime_data() # 452 | CURLFORM_BUFFERPTR, data, # | ^~~~~~~~~~~~~~~~~~ /usr/include/curl/curl.h:2518:3: note: declared here # 2518 | CURLFORM_BUFFERPTR CURL_DEPRECATED(7.56.0, "Use curl_mime_data()"), # | ^~~~~~~~~~~~~~~~~~ # 450| // should be working on F17 # 451| CURLFORM_BUFFER, "*buffer*", // provides filename # 452|-> CURLFORM_BUFFERPTR, data, # 453| CURLFORM_BUFFERLENGTH, (long)strlen(data), # 454| //FIXME: what if file size doesn't fit in long? Error: COMPILER_WARNING (CWE-477): libreport-2.17.15/src/lib/curl.c:453:25: warning[-Wdeprecated-declarations]: 'CURLFORM_BUFFERLENGTH' is deprecated: since 7.56.0. Use curl_mime_data() # 453 | CURLFORM_BUFFERLENGTH, (long)strlen(data), # | ^~~~~~~~~~~~~~~~~~~~~ /usr/include/curl/curl.h:2519:3: note: declared here # 2519 | CURLFORM_BUFFERLENGTH CURL_DEPRECATED(7.56.0, "Use curl_mime_data()"), # | ^~~~~~~~~~~~~~~~~~~~~ # 451| CURLFORM_BUFFER, "*buffer*", // provides filename # 452| CURLFORM_BUFFERPTR, data, # 453|-> CURLFORM_BUFFERLENGTH, (long)strlen(data), # 454| //FIXME: what if file size doesn't fit in long? # 455| CURLFORM_CONTENTTYPE, content_type, Error: COMPILER_WARNING (CWE-477): libreport-2.17.15/src/lib/curl.c:455:25: warning[-Wdeprecated-declarations]: 'CURLFORM_CONTENTTYPE' is deprecated: since 7.56.0. Use curl_mime_type() # 455 | CURLFORM_CONTENTTYPE, content_type, # | ^~~~~~~~~~~~~~~~~~~~ /usr/include/curl/curl.h:2521:3: note: declared here # 2521 | CURLFORM_CONTENTTYPE CURL_DEPRECATED(7.56.0, "Use curl_mime_type()"), # | ^~~~~~~~~~~~~~~~~~~~ # 453| CURLFORM_BUFFERLENGTH, (long)strlen(data), # 454| //FIXME: what if file size doesn't fit in long? # 455|-> CURLFORM_CONTENTTYPE, content_type, # 456| CURLFORM_END); # 457| if (curlform_err != 0) Error: COMPILER_WARNING (CWE-477): libreport-2.17.15/src/lib/curl.c:459:9: warning[-Wdeprecated-declarations]: 'CURLOPT_HTTPPOST' is deprecated: since 7.56.0. Use CURLOPT_MIMEPOST # 459 | xcurl_easy_setopt_ptr(handle, CURLOPT_HTTPPOST, post); # | ^~~~~~~~~~~~~~~~~~~~~ /usr/include/curl/curl.h:1191:3: note: declared here # 1191 | CURLOPTDEPRECATED(CURLOPT_HTTPPOST, CURLOPTTYPE_OBJECTPOINT, 24, # | ^~~~~~~~~~~~~~~~~ # 457| if (curlform_err != 0) # 458| error_msg_and_die("out of memory or read error (curl_formadd error code: %d)", (int)curlform_err); # 459|-> xcurl_easy_setopt_ptr(handle, CURLOPT_HTTPPOST, post); # 460| } # 461| else if (data_size != POST_DATA_GET) Error: COMPILER_WARNING (CWE-477): libreport-2.17.15/src/lib/curl.c:565:9: warning[-Wdeprecated-declarations]: 'curl_formfree' is deprecated: since 7.56.0. Use curl_mime_free() # 565 | curl_formfree(post); # | ^~~~~~~~~~~~~ /usr/include/curl/curl.h:2617:1: note: declared here # 2617 | curl_formfree(struct curl_httppost *form); # | ^~~~~~~~~~~~~ # 563| fclose(data_file); # 564| if (post) # 565|-> curl_formfree(post); # 566| # 567| return response_code; Error: GCC_ANALYZER_WARNING: libreport-2.17.15/src/lib/curl.c: scope_hint: In function 'libreport_upload_file_ext' libreport-2.17.15/src/lib/curl.c:652:5: warning[-Wanalyzer-fd-use-without-check]: 'dup2' on possibly invalid file descriptor 'stdin_bck' libreport-2.17.15/src/lib/curl.c: scope_hint: In function 'libreport_upload_file_ext' libreport-2.17.15/src/lib/curl.c: scope_hint: In function 'libreport_upload_file_ext' # 650| ); # 651| # 652|-> dup2(stdin_bck, 0); # 653| # 654| int error = (state->curl_result != 0); Error: GCC_ANALYZER_WARNING (CWE-688): libreport-2.17.15/src/lib/event_xml_parser.c: scope_hint: In function 'load_event_description_from_file' libreport-2.17.15/src/lib/event_xml_parser.c:521:42: warning[-Wanalyzer-null-argument]: use of NULL 'parse_data.cur_locale' where non-null expected /usr/include/glib-2.0/glib/gstring.h:37: included_from: Included from here. /usr/include/glib-2.0/glib/giochannel.h:36: included_from: Included from here. /usr/include/glib-2.0/glib.h:56: included_from: Included from here. libreport-2.17.15/src/include/event_config.h:23: included_from: Included from here. libreport-2.17.15/src/lib/event_xml_parser.c:19: included_from: Included from here. libreport-2.17.15/src/lib/event_xml_parser.c:520:29: note: in expansion of macro 'g_strdup' libreport-2.17.15/src/lib/event_xml_parser.c: scope_hint: In function 'load_event_description_from_file' /usr/include/glib-2.0/glib/galloca.h:35: included_from: Included from here. /usr/include/glib-2.0/glib.h:32: included_from: Included from here. /usr/include/string.h:286:14: note: argument 1 of 'strchrnul' must be non-null # 519| }; # 520| parse_data.cur_locale = g_strdup(setlocale(LC_ALL, NULL)); # 521|-> strchrnul(parse_data.cur_locale, '.')[0] = '\0'; # 522| # 523| GMarkupParser parser; Error: CLANG_WARNING: libreport-2.17.15/src/lib/get_cmdline.c:789:37: warning[core.UndefinedBinaryOperatorResult]: The left operand of '!=' is a garbage value # 787| { # 788| for (size_t i = 0; i < ARRAY_SIZE(lhs_ids->nsi_ids); ++i) # 789|-> if ( lhs_ids->nsi_ids[i] != PROC_NS_UNSUPPORTED # 790| && (neg ? lhs_ids->nsi_ids[i] == rhs_ids->nsi_ids[i] # 791| : lhs_ids->nsi_ids[i] != rhs_ids->nsi_ids[i])) Error: GCC_ANALYZER_WARNING (CWE-688): libreport-2.17.15/src/lib/problem_report.c: scope_hint: In function 'format_percented_string' libreport-2.17.15/src/lib/problem_report.c:319:13: warning[-Wanalyzer-null-argument]: use of NULL 'result' where non-null expected libreport-2.17.15/src/lib/problem_report.c:21: included_from: Included from here. libreport-2.17.15/src/include/internal_libreport.h:393:115: note: in definition of macro 'log_standard' libreport-2.17.15/src/lib/problem_report.c:1276:9: note: in expansion of macro 'log_debug' libreport-2.17.15/src/lib/problem_report.c:27: included_from: Included from here. libreport-2.17.15/src/include/problem_report.h:138: included_from: Included from here. libreport-2.17.15/src/lib/problem_report.c:20: included_from: Included from here. /usr/include/stdio.h:612:12: note: argument 2 of 'putc' must be non-null # 317| switch (*str) { # 318| default: # 319|-> putc(*str, result); # 320| len++; # 321| str++; Error: GCC_ANALYZER_WARNING (CWE-688): libreport-2.17.15/src/lib/problem_report.c:326:13: warning[-Wanalyzer-null-argument]: use of NULL 'result' where non-null expected libreport-2.17.15/src/include/internal_libreport.h:393:115: note: in definition of macro 'log_standard' libreport-2.17.15/src/lib/problem_report.c:1276:9: note: in expansion of macro 'log_debug' /usr/include/stdio.h:612:12: note: argument 2 of 'putc' must be non-null # 324| if (str[1]) # 325| str++; # 326|-> putc(*str, result); # 327| len++; # 328| str++; Error: GCC_ANALYZER_WARNING (CWE-688): libreport-2.17.15/src/lib/problem_report.c:338:17: warning[-Wanalyzer-null-argument]: use of NULL 'result' where non-null expected libreport-2.17.15/src/include/internal_libreport.h:393:115: note: in definition of macro 'log_standard' libreport-2.17.15/src/lib/problem_report.c:1276:9: note: in expansion of macro 'log_debug' /usr/include/stdio.h:612:12: note: argument 2 of 'putc' must be non-null # 336| str += 2; # 337| } else { # 338|-> putc(*str, result); # 339| len++; # 340| str++; Error: GCC_ANALYZER_WARNING (CWE-688): libreport-2.17.15/src/lib/problem_report.c:355:17: warning[-Wanalyzer-null-argument]: use of NULL 'result' where non-null expected libreport-2.17.15/src/include/internal_libreport.h:393:115: note: in definition of macro 'log_standard' libreport-2.17.15/src/lib/problem_report.c:1276:9: note: in expansion of macro 'log_debug' /usr/include/stdio.h:612:12: note: argument 2 of 'putc' must be non-null # 353| str += 2; # 354| } else { # 355|-> putc(*str, result); # 356| len++; # 357| str++; Error: GCC_ANALYZER_WARNING (CWE-476): libreport-2.17.15/src/lib/report_result.c: scope_hint: In function 'report_result_new_with_label_from_env' libreport-2.17.15/src/lib/report_result.c:179:26: warning[-Wanalyzer-null-dereference]: dereference of NULL '0' /usr/lib64/glib-2.0/include/glibconfig.h:9: included_from: Included from here. /usr/include/glib-2.0/glib/gtypes.h:34: included_from: Included from here. /usr/include/glib-2.0/glib/galloca.h:34: included_from: Included from here. /usr/include/glib-2.0/glib.h:32: included_from: Included from here. libreport-2.17.15/src/include/libreport_types.h:23: included_from: Included from here. libreport-2.17.15/src/include/global_configuration.h:23: included_from: Included from here. libreport-2.17.15/src/include/internal_libreport.h:93: included_from: Included from here. libreport-2.17.15/src/lib/report_result.c:1: included_from: Included from here. /usr/include/glib-2.0/glib/gmacros.h:1243:31: note: in expansion of macro '_G_BOOLEAN_EXPR_IMPL' /usr/include/glib-2.0/glib/gmacros.h:1244:43: note: in expansion of macro '_G_BOOLEAN_EXPR' /usr/include/glib-2.0/glib/gmessages.h:664:9: note: in expansion of macro 'G_LIKELY' libreport-2.17.15/src/lib/report_result.c:158:5: note: in expansion of macro 'g_return_val_if_fail' /usr/include/glib-2.0/glib.h:64: included_from: Included from here. libreport-2.17.15/src/lib/report_result.c:158:5: note: in expansion of macro 'g_return_val_if_fail' /usr/include/glib-2.0/glib/gstring.h:37: included_from: Included from here. /usr/include/glib-2.0/glib/giochannel.h:36: included_from: Included from here. /usr/include/glib-2.0/glib.h:56: included_from: Included from here. libreport-2.17.15/src/lib/report_result.c:179:28: note: in expansion of macro 'g_strdup' libreport-2.17.15/src/lib/report_result.c: scope_hint: In function 'report_result_new_with_label_from_env' # 177| if (NULL != workflow) # 178| { # 179|-> result->workflow = g_strdup(workflow); # 180| } # 181| Error: GCC_ANALYZER_WARNING (CWE-476): libreport-2.17.15/src/lib/run_event.c: scope_hint: In function 'pop_next_command' libreport-2.17.15/src/lib/run_event.c:413:59: warning[-Wanalyzer-null-dereference]: dereference of NULL 'eq_sign' # 411| } # 412| /* Is it "VAR~=REGEX"? */ # 413|-> int regex = (eq_sign > cond_str && eq_sign[-1] == '~'); # 414| /* Is it "VAR!=VAL"? */ # 415| int inverted = (eq_sign > cond_str && eq_sign[-1] == '!'); Error: GCC_ANALYZER_WARNING (CWE-476): libreport-2.17.15/src/lib/run_event.c:415:62: warning[-Wanalyzer-null-dereference]: dereference of NULL 'eq_sign' # 413| int regex = (eq_sign > cond_str && eq_sign[-1] == '~'); # 414| /* Is it "VAR!=VAL"? */ # 415|-> int inverted = (eq_sign > cond_str && eq_sign[-1] == '!'); # 416| g_autofree char *var_name = g_strndup(cond_str, eq_sign - cond_str - (regex|inverted)); # 417| char *real_val = NULL; Error: CLANG_WARNING: libreport-2.17.15/src/lib/run_event.c:420:21: warning[deadcode.DeadStores]: Value stored to 'free_me' is never read # 418| g_autofree char *free_me = NULL; # 419| if (pd == NULL) # 420|-> free_me = real_val = dd_load_text_ext(dd, var_name, DD_FAIL_QUIETLY_ENOENT); # 421| else # 422| { Error: CLANG_WARNING: libreport-2.17.15/src/lib/run_event.c:425:25: warning[deadcode.DeadStores]: Value stored to 'free_me' is never read # 423| real_val = problem_data_get_content_or_NULL(pd, var_name); # 424| if (real_val == NULL) # 425|-> free_me = real_val = g_strdup(""); # 426| } # 427| int vals_differ = regex ? regcmp_lines(real_val, eq_sign + 1) : strcmp(real_val, eq_sign + 1); Error: GCC_ANALYZER_WARNING (CWE-775): libreport-2.17.15/src/lib/spawn.c: scope_hint: In function 'libreport_fork_execv_on_steroids' libreport-2.17.15/src/lib/spawn.c:111:25: warning[-Wanalyzer-fd-leak]: leak of file descriptor 'open("/dev/null", 2)' # 109| libreport_xmove_fd(pipe_to_child[0], STDIN_FILENO); # 110| } else if (flags & EXECFLG_INPUT_NUL) { # 111|-> libreport_xmove_fd(g_open("/dev/null", O_RDWR), STDIN_FILENO); # 112| } # 113| if (flags & EXECFLG_OUTPUT) { Error: GCC_ANALYZER_WARNING (CWE-775): libreport-2.17.15/src/lib/spawn.c:117:25: warning[-Wanalyzer-fd-leak]: leak of file descriptor 'open("/dev/null", 2)' # 115| libreport_xmove_fd(pipe_fm_child[1], STDOUT_FILENO); # 116| } else if (flags & EXECFLG_OUTPUT_NUL) { # 117|-> libreport_xmove_fd(g_open("/dev/null", O_RDWR), STDOUT_FILENO); # 118| } # 119| Error: GCC_ANALYZER_WARNING (CWE-775): libreport-2.17.15/src/lib/spawn.c:127:25: warning[-Wanalyzer-fd-leak]: leak of file descriptor 'open("/dev/null", 2)' # 125| libreport_xdup2(STDOUT_FILENO, STDERR_FILENO); # 126| } else if (flags & EXECFLG_ERR_NUL) { # 127|-> libreport_xmove_fd(g_open("/dev/null", O_RDWR), STDERR_FILENO); # 128| } # 129| Error: CLANG_WARNING: libreport-2.17.15/src/lib/spawn.c:143:6: warning[unix.Malloc]: Potential leak of memory pointed to by 'prog_as_string' # 141| /* Parent */ # 142| # 143|-> if (flags & EXECFLG_INPUT) { # 144| close(pipe_to_child[0]); # 145| pipefds[1] = pipe_to_child[1]; Error: GCC_ANALYZER_WARNING (CWE-688): libreport-2.17.15/src/lib/strbuf.c: scope_hint: In function 'libreport_shorten_string_to_length' libreport-2.17.15/src/lib/strbuf.c:53:9: warning[-Wanalyzer-null-argument]: use of NULL 'str' where non-null expected /usr/include/glib-2.0/glib/gstring.h:37: included_from: Included from here. /usr/include/glib-2.0/glib/giochannel.h:36: included_from: Included from here. /usr/include/glib-2.0/glib.h:56: included_from: Included from here. libreport-2.17.15/src/include/libreport_types.h:23: included_from: Included from here. libreport-2.17.15/src/include/global_configuration.h:23: included_from: Included from here. libreport-2.17.15/src/include/internal_libreport.h:93: included_from: Included from here. libreport-2.17.15/src/lib/strbuf.c:20: included_from: Included from here. libreport-2.17.15/src/lib/strbuf.c:52:21: note: in expansion of macro 'g_strdup' libreport-2.17.15/src/lib/strbuf.c: scope_hint: In function 'libreport_shorten_string_to_length' <built-in>: note: argument 1 of '__builtin_strlen' must be non-null # 51| { # 52| char *dup_str = g_strdup(str); # 53|-> if (strlen(str) > length) # 54| { # 55| char *max_end = dup_str + (length - strlen("...")); Error: GCC_ANALYZER_WARNING (CWE-688): libreport-2.17.15/src/lib/workflow_xml_parser.c: scope_hint: In function 'load_workflow_description_from_file' libreport-2.17.15/src/lib/workflow_xml_parser.c:198:42: warning[-Wanalyzer-null-argument]: use of NULL 'parse_data.cur_locale' where non-null expected /usr/include/glib-2.0/glib/gstring.h:37: included_from: Included from here. /usr/include/glib-2.0/glib/giochannel.h:36: included_from: Included from here. /usr/include/glib-2.0/glib.h:56: included_from: Included from here. libreport-2.17.15/src/include/workflow.h:22: included_from: Included from here. libreport-2.17.15/src/lib/workflow_xml_parser.c:19: included_from: Included from here. libreport-2.17.15/src/lib/workflow_xml_parser.c:197:29: note: in expansion of macro 'g_strdup' libreport-2.17.15/src/lib/workflow_xml_parser.c: scope_hint: In function 'load_workflow_description_from_file' /usr/include/glib-2.0/glib/galloca.h:35: included_from: Included from here. /usr/include/glib-2.0/glib.h:32: included_from: Included from here. /usr/include/string.h:286:14: note: argument 1 of 'strchrnul' must be non-null # 196| struct my_parse_data parse_data = { workflow, NULL, NULL, 0, 0, 0}; # 197| parse_data.cur_locale = g_strdup(setlocale(LC_ALL, NULL)); # 198|-> strchrnul(parse_data.cur_locale, '.')[0] = '\0'; # 199| # 200| GMarkupParser parser; Error: GCC_ANALYZER_WARNING (CWE-775): libreport-2.17.15/src/lib/xfuncs.c: scope_hint: In function 'libreport_xdup2' libreport-2.17.15/src/lib/xfuncs.c:74:8: warning[-Wanalyzer-fd-leak]: leak of file descriptor 'dup2(from, to)' # 72| void libreport_xdup2(int from, int to) # 73| { # 74|-> if (dup2(from, to) != to) # 75| perror_msg_and_die("Can't duplicate file descriptor"); # 76| } Error: CLANG_WARNING: libreport-2.17.15/src/plugins/mantisbt.c:662:19: warning[deadcode.DeadStores]: Although the value stored to 'url_copy' is used in the enclosing expression, the value is never actually read from 'url_copy' # 660| if (++redirect_count < 10 && location) # 661| { # 662|-> url = url_copy = g_strdup(location); # 663| free_post_state(post_state); # 664| goto redirect; Error: GCC_ANALYZER_WARNING (CWE-688): libreport-2.17.15/src/plugins/mantisbt.c: scope_hint: In function ‘mantisbt_get_issue_info’ libreport-2.17.15/src/plugins/mantisbt.c:1007:9: warning[-Wanalyzer-null-argument]: use of NULL where non-null expected libreport-2.17.15/src/plugins/mantisbt.c: scope_hint: In function ‘mantisbt_get_issue_info’ libreport-2.17.15/src/plugins/mantisbt.c: scope_hint: In function ‘mantisbt_get_issue_info’ libreport-2.17.15/src/plugins/mantisbt.c: scope_hint: In function ‘mantisbt_get_issue_info’ libreport-2.17.15/src/include/internal_libreport.h:35: included_from: Included from here. libreport-2.17.15/src/plugins/mantisbt.c:24: included_from: Included from here. /usr/include/string.h:156:12: note: argument 1 of ‘strcmp’ must be non-null # 1005| issue_info->mii_project = response_get_name_value_of_element(result->mr_body, "project"); # 1006| # 1007|-> if (strcmp(issue_info->mii_status, "closed") == 0 && !issue_info->mii_resolution) # 1008| error_msg(_("Issue %i is CLOSED, but it has no RESOLUTION"), issue_info->mii_id); # 1009| Error: GCC_ANALYZER_WARNING (CWE-775): libreport-2.17.15/src/plugins/reporter-bugzilla.c: scope_hint: In function ‘main’ libreport-2.17.15/src/plugins/reporter-bugzilla.c:520:26: warning[-Wanalyzer-fd-leak]: leak of file descriptor ‘open(*argv, 0)’ /usr/include/glib-2.0/glib/gstring.h:37: included_from: Included from here. /usr/include/glib-2.0/glib/giochannel.h:36: included_from: Included from here. /usr/include/glib-2.0/glib.h:56: included_from: Included from here. libreport-2.17.15/src/include/libreport_types.h:23: included_from: Included from here. libreport-2.17.15/src/include/global_configuration.h:23: included_from: Included from here. libreport-2.17.15/src/include/internal_libreport.h:93: included_from: Included from here. libreport-2.17.15/src/plugins/reporter-bugzilla.c:19: included_from: Included from here. libreport-2.17.15/src/plugins/reporter-bugzilla.c:114:20: note: in expansion of macro ‘g_strdup’ libreport-2.17.15/src/plugins/reporter-bugzilla.c: scope_hint: In function ‘main’ libreport-2.17.15/src/plugins/reporter-bugzilla.c:119:25: note: in expansion of macro ‘g_strdup’ libreport-2.17.15/src/plugins/reporter-bugzilla.c: scope_hint: In function ‘main’ libreport-2.17.15/src/include/internal_libreport.h:386:26: note: in expansion of macro ‘log_standard’ libreport-2.17.15/src/plugins/reporter-bugzilla.c:175:5: note: in expansion of macro ‘log_notice’ libreport-2.17.15/src/include/internal_libreport.h:386:26: note: in expansion of macro ‘log_standard’ libreport-2.17.15/src/plugins/reporter-bugzilla.c:175:5: note: in expansion of macro ‘log_notice’ # 518| log_notice("Attaching file '%s' to bug %s", filename, ticket_no); # 519| # 520|-> int fd = open(filename, O_RDONLY); # 521| if (fd < 0) # 522| { Error: GCC_ANALYZER_WARNING (CWE-688): libreport-2.17.15/src/plugins/reporter-bugzilla.c:639:22: warning[-Wanalyzer-null-argument]: use of NULL ‘id’ where non-null expected libreport-2.17.15/src/plugins/reporter-bugzilla.c:114:20: note: in expansion of macro ‘g_strdup’ libreport-2.17.15/src/plugins/reporter-bugzilla.c: scope_hint: In function ‘main’ libreport-2.17.15/src/plugins/reporter-bugzilla.c:119:25: note: in expansion of macro ‘g_strdup’ libreport-2.17.15/src/plugins/reporter-bugzilla.c: scope_hint: In function ‘main’ libreport-2.17.15/src/include/internal_libreport.h:386:26: note: in expansion of macro ‘log_standard’ libreport-2.17.15/src/plugins/reporter-bugzilla.c:175:5: note: in expansion of macro ‘log_notice’ libreport-2.17.15/src/include/internal_libreport.h:386:26: note: in expansion of macro ‘log_standard’ libreport-2.17.15/src/plugins/reporter-bugzilla.c:175:5: note: in expansion of macro ‘log_notice’ /usr/lib64/glib-2.0/include/glibconfig.h:9: included_from: Included from here. /usr/include/glib-2.0/glib/gtypes.h:34: included_from: Included from here. /usr/include/glib-2.0/glib/galloca.h:34: included_from: Included from here. /usr/include/glib-2.0/glib.h:32: included_from: Included from here. /usr/include/glib-2.0/glib/gmacros.h:1243:31: note: in expansion of macro ‘_G_BOOLEAN_EXPR_IMPL’ /usr/include/glib-2.0/glib/gmacros.h:1245:45: note: in expansion of macro ‘_G_BOOLEAN_EXPR’ /usr/include/glib-2.0/glib/gstrfuncs.h:166:11: note: in expansion of macro ‘G_UNLIKELY’ libreport-2.17.15/src/plugins/reporter-bugzilla.c:635:13: note: in expansion of macro ‘g_str_has_prefix’ libreport-2.17.15/src/include/internal_libreport.h:26: included_from: Included from here. /usr/include/features.h:511: included_from: Included from here. /usr/include/assert.h:35: included_from: Included from here. libreport-2.17.15/src/include/internal_libreport.h:23: included_from: Included from here. /usr/include/stdlib.h:219:26: note: argument 1 of ‘strtoul’ must be non-null # 637| errno = 0; # 638| char *e; # 639|-> bug_id = strtoul(id, &e, 10); # 640| if (errno || id == e || *e != '\0' || bug_id > INT_MAX) # 641| { Error: COMPILER_WARNING (CWE-477): libreport-2.17.15/src/plugins/reporter-kerneloops.c: scope_hint: In function ‘http_post_to_kerneloops_site’ libreport-2.17.15/src/plugins/reporter-kerneloops.c:51:5: warning[-Wdeprecated-declarations]: ‘curl_formadd’ is deprecated: since 7.56.0. Use curl_mime_init() libreport-2.17.15/src/include/libreport_curl.h:22: included_from: Included from here. libreport-2.17.15/src/plugins/reporter-kerneloops.c:19: included_from: Included from here. /usr/include/curl/curl.h:2581:1: note: declared here # 49| curl_easy_setopt(handle, CURLOPT_HTTPHEADER, headers); # 50| # 51|-> curl_formadd(&post, &last, # 52| CURLFORM_COPYNAME, "oopsdata", # 53| CURLFORM_COPYCONTENTS, oopsdata, Error: COMPILER_WARNING (CWE-477): libreport-2.17.15/src/plugins/reporter-kerneloops.c:52:13: warning[-Wdeprecated-declarations]: ‘CURLFORM_COPYNAME’ is deprecated: since 7.56.0. Use curl_mime_name() /usr/include/curl/curl.h:2506:3: note: declared here # 50| # 51| curl_formadd(&post, &last, # 52|-> CURLFORM_COPYNAME, "oopsdata", # 53| CURLFORM_COPYCONTENTS, oopsdata, # 54| CURLFORM_END); Error: COMPILER_WARNING (CWE-477): libreport-2.17.15/src/plugins/reporter-kerneloops.c:53:13: warning[-Wdeprecated-declarations]: ‘CURLFORM_COPYCONTENTS’ is deprecated: since 7.56.0. Use curl_mime_data() /usr/include/curl/curl.h:2509:3: note: declared here # 51| curl_formadd(&post, &last, # 52| CURLFORM_COPYNAME, "oopsdata", # 53|-> CURLFORM_COPYCONTENTS, oopsdata, # 54| CURLFORM_END); # 55| curl_formadd(&post, &last, Error: COMPILER_WARNING (CWE-477): libreport-2.17.15/src/plugins/reporter-kerneloops.c:55:5: warning[-Wdeprecated-declarations]: ‘curl_formadd’ is deprecated: since 7.56.0. Use curl_mime_init() /usr/include/curl/curl.h:2581:1: note: declared here # 53| CURLFORM_COPYCONTENTS, oopsdata, # 54| CURLFORM_END); # 55|-> curl_formadd(&post, &last, # 56| CURLFORM_COPYNAME, "pass_on_allowed", # 57| CURLFORM_COPYCONTENTS, "yes", Error: COMPILER_WARNING (CWE-477): libreport-2.17.15/src/plugins/reporter-kerneloops.c:56:13: warning[-Wdeprecated-declarations]: ‘CURLFORM_COPYNAME’ is deprecated: since 7.56.0. Use curl_mime_name() /usr/include/curl/curl.h:2506:3: note: declared here # 54| CURLFORM_END); # 55| curl_formadd(&post, &last, # 56|-> CURLFORM_COPYNAME, "pass_on_allowed", # 57| CURLFORM_COPYCONTENTS, "yes", # 58| CURLFORM_END); Error: COMPILER_WARNING (CWE-477): libreport-2.17.15/src/plugins/reporter-kerneloops.c:57:13: warning[-Wdeprecated-declarations]: ‘CURLFORM_COPYCONTENTS’ is deprecated: since 7.56.0. Use curl_mime_data() /usr/include/curl/curl.h:2509:3: note: declared here # 55| curl_formadd(&post, &last, # 56| CURLFORM_COPYNAME, "pass_on_allowed", # 57|-> CURLFORM_COPYCONTENTS, "yes", # 58| CURLFORM_END); # 59| Error: COMPILER_WARNING (CWE-477): libreport-2.17.15/src/plugins/reporter-kerneloops.c:60:5: warning[-Wdeprecated-declarations]: ‘CURLOPT_HTTPPOST’ is deprecated: since 7.56.0. Use CURLOPT_MIMEPOST /usr/include/curl/curl.h:1191:3: note: declared here # 58| CURLFORM_END); # 59| # 60|-> curl_easy_setopt(handle, CURLOPT_HTTPPOST, post); # 61| curl_easy_setopt(handle, CURLOPT_WRITEFUNCTION, writefunction); # 62| Error: COMPILER_WARNING (CWE-477): libreport-2.17.15/src/plugins/reporter-kerneloops.c:65:5: warning[-Wdeprecated-declarations]: ‘curl_formfree’ is deprecated: since 7.56.0. Use curl_mime_free() /usr/include/curl/curl.h:2617:1: note: declared here # 63| ret = curl_easy_perform_with_proxy(handle, url); # 64| # 65|-> curl_formfree(post); # 66| curl_slist_free_all(headers); # 67| curl_easy_cleanup(handle); Error: GCC_ANALYZER_WARNING (CWE-688): libreport-2.17.15/src/plugins/reporter-mantisbt.c: scope_hint: In function ‘main’ libreport-2.17.15/src/plugins/reporter-mantisbt.c:504:22: warning[-Wanalyzer-null-argument]: use of NULL ‘id’ where non-null expected /usr/include/glib-2.0/glib/gstring.h:37: included_from: Included from here. /usr/include/glib-2.0/glib/giochannel.h:36: included_from: Included from here. /usr/include/glib-2.0/glib.h:56: included_from: Included from here. libreport-2.17.15/src/include/libreport_types.h:23: included_from: Included from here. libreport-2.17.15/src/include/global_configuration.h:23: included_from: Included from here. libreport-2.17.15/src/include/internal_libreport.h:93: included_from: Included from here. libreport-2.17.15/src/plugins/reporter-mantisbt.c:20: included_from: Included from here. libreport-2.17.15/src/plugins/reporter-mantisbt.c:129:18: note: in expansion of macro ‘g_strdup’ libreport-2.17.15/src/plugins/reporter-mantisbt.c: scope_hint: In function ‘main’ libreport-2.17.15/src/plugins/reporter-mantisbt.c:134:21: note: in expansion of macro ‘g_strdup’ libreport-2.17.15/src/plugins/reporter-mantisbt.c: scope_hint: In function ‘main’ /usr/lib64/glib-2.0/include/glibconfig.h:9: included_from: Included from here. /usr/include/glib-2.0/glib/gtypes.h:34: included_from: Included from here. /usr/include/glib-2.0/glib/galloca.h:34: included_from: Included from here. /usr/include/glib-2.0/glib.h:32: included_from: Included from here. /usr/include/glib-2.0/glib/gmacros.h:1243:31: note: in expansion of macro ‘_G_BOOLEAN_EXPR_IMPL’ /usr/include/glib-2.0/glib/gmacros.h:1245:45: note: in expansion of macro ‘_G_BOOLEAN_EXPR’ /usr/include/glib-2.0/glib/gstrfuncs.h:166:11: note: in expansion of macro ‘G_UNLIKELY’ libreport-2.17.15/src/plugins/reporter-mantisbt.c:500:13: note: in expansion of macro ‘g_str_has_prefix’ libreport-2.17.15/src/include/internal_libreport.h:26: included_from: Included from here. /usr/include/features.h:511: included_from: Included from here. /usr/include/assert.h:35: included_from: Included from here. libreport-2.17.15/src/include/internal_libreport.h:23: included_from: Included from here. /usr/include/stdlib.h:219:26: note: argument 1 of ‘strtoul’ must be non-null # 502| errno = 0; # 503| char *e; # 504|-> bug_id = strtoul(id, &e, 10); # 505| if (errno || id == e || *e != '\0' || bug_id > INT_MAX) # 506| { Error: CLANG_WARNING: libreport-2.17.15/src/plugins/reporter-upload.c:52:31: warning[deadcode.DeadStores]: Although the value stored to 'password_inp' is used in the enclosing expression, the value is never actually read from 'password_inp' # 50| /* may work somehow??? */ # 51| g_autofree char *msg = g_strdup_printf(_("Please enter password for uploading:")); # 52|-> state->password = password_inp = libreport_ask_password(msg); # 53| } # 54| } Error: CLANG_WARNING: libreport-2.17.15/src/plugins/reporter-upload.c:217:20: warning[deadcode.DeadStores]: Although the value stored to 'input_url' is used in the enclosing expression, the value is never actually read from 'input_url' # 215| conf_url = g_hash_table_lookup(settings, "URL"); # 216| if (!conf_url || conf_url[0] == '\0') # 217|-> conf_url = input_url = ask_url(_("Please enter a URL (scp, ftp, etc.) where the problem data is to be exported:")); # 218| # 219| g_hash_table_replace(settings, g_strdup("UploadUsername"), g_strdup(getenv("Upload_Username"))); Error: CLANG_WARNING: libreport-2.17.15/src/plugins/reporter-ureport.c:256:13: warning[deadcode.DeadStores]: Value stored to 'attach_value_from_rt_data' is never read # 254| /* Avoid the need to duplicate the string. */ # 255| attach_value = url; # 256|-> attach_value_from_rt_data = url; # 257| } # 258| Error: GCC_ANALYZER_WARNING (CWE-688): libreport-2.17.15/src/plugins/rhbz.c: scope_hint: In function ‘rhbz_bug_info’ libreport-2.17.15/src/plugins/rhbz.c:485:12: warning[-Wanalyzer-null-argument]: use of NULL where non-null expected libreport-2.17.15/src/plugins/rhbz.c:28: included_from: Included from here. libreport-2.17.15/src/plugins/rhbz.c:363:9: note: in expansion of macro ‘IS_READ_STR’ libreport-2.17.15/src/plugins/rhbz.c:377:9: note: in expansion of macro ‘IS_READ_INT’ libreport-2.17.15/src/plugins/rhbz.c:27: included_from: Included from here. libreport-2.17.15/src/include/internal_libreport.h:384:26: note: in expansion of macro ‘log_standard’ libreport-2.17.15/src/plugins/rhbz.c:385:9: note: in expansion of macro ‘log_debug’ libreport-2.17.15/src/plugins/rhbz.c:363:9: note: in expansion of macro ‘IS_READ_STR’ libreport-2.17.15/src/include/internal_libreport.h:384:26: note: in expansion of macro ‘log_standard’ libreport-2.17.15/src/plugins/rhbz.c:373:9: note: in expansion of macro ‘log_debug’ libreport-2.17.15/src/plugins/rhbz.c:363:9: note: in expansion of macro ‘IS_READ_STR’ libreport-2.17.15/src/include/internal_libreport.h:384:26: note: in expansion of macro ‘log_standard’ libreport-2.17.15/src/plugins/rhbz.c:373:9: note: in expansion of macro ‘log_debug’ libreport-2.17.15/src/plugins/rhbz.c:363:9: note: in expansion of macro ‘IS_READ_STR’ libreport-2.17.15/src/include/internal_libreport.h:384:26: note: in expansion of macro ‘log_standard’ libreport-2.17.15/src/plugins/rhbz.c:373:9: note: in expansion of macro ‘log_debug’ libreport-2.17.15/src/include/internal_libreport.h:35: included_from: Included from here. /usr/include/string.h:156:12: note: argument 1 of ‘strcmp’ must be non-null # 483| RHBZ_READ_INT); # 484| if (strcmp(bz->bi_status, "CLOSED") == 0 # 485|-> && strcmp(bz->bi_resolution, "DUPLICATE") == 0 # 486| && !ret) # 487| { Error: CLANG_WARNING: libreport-2.17.15/src/report-newt/report-newt.c:209:13: warning[unix.Malloc]: Potential leak of memory pointed to by 'options' # 207| } # 208| # 209|-> return !error_list; # 210| } # 211|