Task #1058 - gnome-software-46.0-1.fc40/scan-results.err
back to task #1058download
Error: CPPCHECK_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app-list.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app-list.c:463:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 461| g_return_if_fail (GS_IS_APP_LIST (list)); # 462| g_return_if_fail (GS_IS_APP (app)); # 463|-> locker = g_mutex_locker_new (&list->mutex); # 464| gs_app_list_add_safe (list, app, GS_APP_LIST_ADD_FLAG_CHECK_FOR_DUPE); # 465| Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app-list.c:491:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 489| g_return_val_if_fail (GS_IS_APP (app), FALSE); # 490| # 491|-> locker = g_mutex_locker_new (&list->mutex); # 492| removed = g_ptr_array_remove (list->array, app); # 493| if (removed) { Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app-list.c:523:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 521| g_return_if_fail (list != donor); # 522| # 523|-> locker = g_mutex_locker_new (&list->mutex); # 524| # 525| /* add each app */ Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app-list.c:595:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 593| g_autoptr(GMutexLocker) locker = NULL; # 594| g_return_if_fail (GS_IS_APP_LIST (list)); # 595|-> locker = g_mutex_locker_new (&list->mutex); # 596| gs_app_list_remove_all_safe (list); # 597| } Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app-list.c:620:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 618| g_return_if_fail (func != NULL); # 619| # 620|-> locker = g_mutex_locker_new (&list->mutex); # 621| # 622| /* deep copy to a temp list and clear the current one */ Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app-list.c:664:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 662| GsAppListSortHelper helper; # 663| g_return_if_fail (GS_IS_APP_LIST (list)); # 664|-> locker = g_mutex_locker_new (&list->mutex); # 665| helper.func = func; # 666| helper.user_data = user_data; Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app-list.c:698:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 696| # 697| /* remove the apps in the positions larger than the length */ # 698|-> locker = g_mutex_locker_new (&list->mutex); # 699| g_ptr_array_set_size (list->array, length); # 700| } Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app-list.c:720:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 718| g_return_if_fail (GS_IS_APP_LIST (list)); # 719| # 720|-> locker = g_mutex_locker_new (&list->mutex); # 721| # 722| if (!gs_app_list_length (list)) Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app-list.c:833:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 831| g_return_if_fail (GS_IS_APP_LIST (list)); # 832| # 833|-> locker = g_mutex_locker_new (&list->mutex); # 834| # 835| /* a hash table to hold apps with unique app ids */ Error: CPPCHECK_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app-permissions.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: GCC_ANALYZER_WARNING (CWE-688): gnome-software-46.0-build/gnome-software-46.0/lib/gs-app-query.c: scope_hint: In function ‘gs_app_query_sanitize_keywords’ gnome-software-46.0-build/gnome-software-46.0/lib/gs-app-query.c:142:21: warning[-Wanalyzer-null-argument]: use of NULL where non-null expected /usr/include/glib-2.0/glib/gstring.h:37: included_from: Included from here. /usr/include/glib-2.0/glib/giochannel.h:36: included_from: Included from here. /usr/include/glib-2.0/glib.h:56: included_from: Included from here. gnome-software-46.0-build/gnome-software-46.0/lib/gs-app-query.c:47: included_from: Included from here. gnome-software-46.0-build/gnome-software-46.0/lib/gs-app-query.c:140:42: note: in expansion of macro ‘g_strdup’ gnome-software-46.0-build/gnome-software-46.0/lib/gs-app-query.c:140:42: note: in expansion of macro ‘g_strdup’ gnome-software-46.0-build/gnome-software-46.0/lib/gs-app-query.c: scope_hint: In function ‘gs_app_query_sanitize_keywords’ gnome-software-46.0-build/gnome-software-46.0/lib/gs-app-query.c:141:17: note: in expansion of macro ‘g_strstrip’ <built-in>: note: argument 1 of ‘__builtin_strchr’ must be non-null # 140| g_autofree gchar *term = g_strdup (terms[0]); # 141| g_strstrip (term); # 142|-> if (strchr (term, ' ')) { # 143| g_auto(GStrv) split = g_strsplit (term, " ", -1); # 144| for (guint i = 0; split[i] != NULL; i++) { Error: CPPCHECK_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app.c:546:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 544| klass = GS_APP_GET_CLASS (app); # 545| # 546|-> locker = g_mutex_locker_new (&priv->mutex); # 547| # 548| g_string_append_printf (str, " [%p]\n", app); Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app.c:862:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 860| g_autoptr(GMutexLocker) locker = NULL; # 861| g_return_if_fail (GS_IS_APP (app)); # 862|-> locker = g_mutex_locker_new (&priv->mutex); # 863| if (_g_set_str (&priv->id, id)) # 864| priv->unique_id_valid = FALSE; Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app.c:1258:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 1256| g_autoptr(GMutexLocker) locker = NULL; # 1257| g_return_if_fail (GS_IS_APP (app)); # 1258|-> locker = g_mutex_locker_new (&priv->mutex); # 1259| if (priv->progress == percentage) # 1260| return; Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app.c:1287:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 1285| g_autoptr(GMutexLocker) locker = NULL; # 1286| g_return_if_fail (GS_IS_APP (app)); # 1287|-> locker = g_mutex_locker_new (&priv->mutex); # 1288| if (priv->allow_cancel == allow_cancel) # 1289| return; Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app.c:1337:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 1335| g_return_if_fail (GS_IS_APP (app)); # 1336| # 1337|-> locker = g_mutex_locker_new (&priv->mutex); # 1338| # 1339| if (gs_app_set_state_internal (app, state)) { Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app.c:1400:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 1398| g_return_if_fail (GS_IS_APP (app)); # 1399| # 1400|-> locker = g_mutex_locker_new (&priv->mutex); # 1401| # 1402| /* same */ Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app.c:1471:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 1469| g_autoptr(GMutexLocker) locker = NULL; # 1470| g_return_val_if_fail (GS_IS_APP (app), NULL); # 1471|-> locker = g_mutex_locker_new (&priv->mutex); # 1472| return gs_app_get_unique_id_unlocked (app); # 1473| } Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app.c:1492:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 1490| g_return_if_fail (GS_IS_APP (app)); # 1491| # 1492|-> locker = g_mutex_locker_new (&priv->mutex); # 1493| # 1494| /* check for sanity */ Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app.c:1538:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 1536| g_return_if_fail (GS_IS_APP (app)); # 1537| # 1538|-> locker = g_mutex_locker_new (&priv->mutex); # 1539| # 1540| /* only save this if the data is sufficiently high quality */ Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app.c:1582:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 1580| g_autoptr(GMutexLocker) locker = NULL; # 1581| g_return_if_fail (GS_IS_APP (app)); # 1582|-> locker = g_mutex_locker_new (&priv->mutex); # 1583| _g_set_str (&priv->renamed_from, renamed_from); # 1584| } Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app.c:1619:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 1617| g_autoptr(GMutexLocker) locker = NULL; # 1618| g_return_if_fail (GS_IS_APP (app)); # 1619|-> locker = g_mutex_locker_new (&priv->mutex); # 1620| if (_g_set_str (&priv->branch, branch)) # 1621| priv->unique_id_valid = FALSE; Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app.c:1664:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 1662| g_return_if_fail (source != NULL); # 1663| # 1664|-> locker = g_mutex_locker_new (&priv->mutex); # 1665| # 1666| /* check source doesn't already exist */ Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app.c:1710:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 1708| g_autoptr(GMutexLocker) locker = NULL; # 1709| g_return_if_fail (GS_IS_APP (app)); # 1710|-> locker = g_mutex_locker_new (&priv->mutex); # 1711| _g_set_ptr_array (&priv->sources, sources); # 1712| } Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app.c:1766:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 1764| g_autoptr(GMutexLocker) locker = NULL; # 1765| g_return_if_fail (GS_IS_APP (app)); # 1766|-> locker = g_mutex_locker_new (&priv->mutex); # 1767| g_ptr_array_set_size (priv->source_ids, 0); # 1768| } Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app.c:1786:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 1784| g_autoptr(GMutexLocker) locker = NULL; # 1785| g_return_if_fail (GS_IS_APP (app)); # 1786|-> locker = g_mutex_locker_new (&priv->mutex); # 1787| _g_set_ptr_array (&priv->source_ids, source_ids); # 1788| } Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app.c:1871:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 1869| g_autoptr(GMutexLocker) locker = NULL; # 1870| g_return_if_fail (GS_IS_APP (app)); # 1871|-> locker = g_mutex_locker_new (&priv->mutex); # 1872| _g_set_str (&priv->project_group, project_group); # 1873| } Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app.c:1890:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 1888| g_autoptr(GMutexLocker) locker = NULL; # 1889| g_return_if_fail (GS_IS_APP (app)); # 1890|-> locker = g_mutex_locker_new (&priv->mutex); # 1891| _g_set_str (&priv->developer_name, developer_name); # 1892| } Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app.c:2076:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 2074| g_return_val_if_fail (GS_IS_APP (app), NULL); # 2075| # 2076|-> locker = g_mutex_locker_new (&priv->mutex); # 2077| # 2078| if (priv->icons == NULL || priv->icons->len == 0) Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app.c:2107:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 2105| g_return_val_if_fail (GS_IS_APP (app), NULL); # 2106| # 2107|-> locker = g_mutex_locker_new (&priv->mutex); # 2108| # 2109| if (priv->icons == NULL || priv->icons->len == 0) Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app.c:2138:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 2136| g_return_val_if_fail (GS_IS_APP (app), FALSE); # 2137| # 2138|-> locker = g_mutex_locker_new (&priv->mutex); # 2139| # 2140| return priv->icons != NULL && priv->icons->len > 0; Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app.c:2181:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 2179| g_return_if_fail (G_IS_ICON (icon)); # 2180| # 2181|-> locker = g_mutex_locker_new (&priv->mutex); # 2182| # 2183| if (priv->icons == NULL) Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app.c:2206:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 2204| g_autoptr(GMutexLocker) locker = NULL; # 2205| g_return_if_fail (GS_IS_APP (app)); # 2206|-> locker = g_mutex_locker_new (&priv->mutex); # 2207| # 2208| if (priv->icons != NULL) Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app.c:2246:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 2244| g_autoptr(GMutexLocker) locker = NULL; # 2245| g_return_if_fail (GS_IS_APP (app)); # 2246|-> locker = g_mutex_locker_new (&priv->mutex); # 2247| _g_set_str (&priv->agreement, agreement); # 2248| } Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app.c:2285:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 2283| g_autoptr(GMutexLocker) locker = NULL; # 2284| g_return_if_fail (GS_IS_APP (app)); # 2285|-> locker = g_mutex_locker_new (&priv->mutex); # 2286| g_set_object (&priv->local_file, local_file); # 2287| } Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app.c:2305:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 2303| g_autoptr(GMutexLocker) locker = NULL; # 2304| g_return_val_if_fail (GS_IS_APP (app), NULL); # 2305|-> locker = g_mutex_locker_new (&priv->mutex); # 2306| return (priv->content_rating != NULL) ? g_object_ref (priv->content_rating) : NULL; # 2307| } Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app.c:2324:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 2322| g_autoptr(GMutexLocker) locker = NULL; # 2323| g_return_if_fail (GS_IS_APP (app)); # 2324|-> locker = g_mutex_locker_new (&priv->mutex); # 2325| if (g_set_object (&priv->content_rating, content_rating)) # 2326| gs_app_queue_notify (app, obj_props[PROP_CONTENT_RATING]); Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app.c:2364:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 2362| g_return_if_fail (GS_IS_APP (runtime)); # 2363| g_return_if_fail (app != runtime); # 2364|-> locker = g_mutex_locker_new (&priv->mutex); # 2365| g_set_object (&priv->runtime, runtime); # 2366| Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app.c:2387:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 2385| g_autoptr(GMutexLocker) locker = NULL; # 2386| g_return_if_fail (GS_IS_APP (app)); # 2387|-> locker = g_mutex_locker_new (&priv->mutex); # 2388| g_set_object (&priv->action_screenshot, action_screenshot); # 2389| } Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app.c:2554:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 2552| g_return_if_fail (GS_IS_APP (app)); # 2553| # 2554|-> locker = g_mutex_locker_new (&priv->mutex); # 2555| # 2556| if (_g_set_str (&priv->version, version)) { Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app.c:2597:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 2595| g_return_if_fail (GS_IS_APP (app)); # 2596| # 2597|-> locker = g_mutex_locker_new (&priv->mutex); # 2598| # 2599| /* only save this if the data is sufficiently high quality */ Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app.c:2642:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 2640| g_return_if_fail (GS_IS_APP (app)); # 2641| # 2642|-> locker = g_mutex_locker_new (&priv->mutex); # 2643| # 2644| /* only save this if the data is sufficiently high quality */ Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app.c:2668:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 2666| g_autoptr(GMutexLocker) locker = NULL; # 2667| g_return_val_if_fail (GS_IS_APP (app), NULL); # 2668|-> locker = g_mutex_locker_new (&priv->mutex); # 2669| # 2670| if (priv->urls == NULL) Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app.c:2695:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 2693| g_return_if_fail (GS_IS_APP (app)); # 2694| # 2695|-> locker = g_mutex_locker_new (&priv->mutex); # 2696| # 2697| if (priv->urls == NULL) Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app.c:2730:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 2728| g_autoptr(GMutexLocker) locker = NULL; # 2729| g_return_val_if_fail (GS_IS_APP (app), NULL); # 2730|-> locker = g_mutex_locker_new (&priv->mutex); # 2731| return priv->url_missing; # 2732| } Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app.c:2750:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 2748| g_autoptr(GMutexLocker) locker = NULL; # 2749| g_return_if_fail (GS_IS_APP (app)); # 2750|-> locker = g_mutex_locker_new (&priv->mutex); # 2751| # 2752| if (g_strcmp0 (priv->url_missing, url) == 0) Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app.c:2776:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 2774| g_autoptr(GMutexLocker) locker = NULL; # 2775| g_return_val_if_fail (GS_IS_APP (app), NULL); # 2776|-> locker = g_mutex_locker_new (&priv->mutex); # 2777| return g_hash_table_lookup (priv->launchables, # 2778| as_launchable_kind_to_string (kind)); Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app.c:2799:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 2797| g_autoptr(GMutexLocker) locker = NULL; # 2798| g_return_if_fail (GS_IS_APP (app)); # 2799|-> locker = g_mutex_locker_new (&priv->mutex); # 2800| key = as_launchable_kind_to_string (kind); # 2801| if (g_hash_table_lookup_extended (priv->launchables, key, NULL, ¤t_value)) { Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app.c:2866:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 2864| g_return_if_fail (GS_IS_APP (app)); # 2865| # 2866|-> locker = g_mutex_locker_new (&priv->mutex); # 2867| # 2868| /* only save this if the data is sufficiently high quality */ Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app.c:2914:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 2912| g_autoptr(GMutexLocker) locker = NULL; # 2913| g_return_if_fail (GS_IS_APP (app)); # 2914|-> locker = g_mutex_locker_new (&priv->mutex); # 2915| _g_set_str (&priv->summary_missing, summary_missing); # 2916| } Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app.c:3003:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 3001| g_autoptr(GMutexLocker) locker = NULL; # 3002| g_return_if_fail (GS_IS_APP (app)); # 3003|-> locker = g_mutex_locker_new (&priv->mutex); # 3004| _g_set_strv (&priv->menu_path, menu_path); # 3005| } Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app.c:3041:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 3039| g_return_if_fail (GS_IS_APP (app)); # 3040| # 3041|-> locker = g_mutex_locker_new (&priv->mutex); # 3042| # 3043| /* same */ Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app.c:3097:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 3095| g_return_if_fail (GS_IS_APP (app)); # 3096| # 3097|-> locker = g_mutex_locker_new (&priv->mutex); # 3098| # 3099| /* same */ Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app.c:3151:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 3149| g_return_if_fail (GS_IS_APP (app)); # 3150| # 3151|-> locker = g_mutex_locker_new (&priv->mutex); # 3152| # 3153| /* same */ Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app.c:3195:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 3193| g_return_if_fail (AS_IS_SCREENSHOT (screenshot)); # 3194| # 3195|-> locker = g_mutex_locker_new (&priv->mutex); # 3196| g_ptr_array_add (priv->screenshots, g_object_ref (screenshot)); # 3197| } Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app.c:3283:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 3281| g_autoptr(GMutexLocker) locker = NULL; # 3282| g_return_if_fail (GS_IS_APP (app)); # 3283|-> locker = g_mutex_locker_new (&priv->mutex); # 3284| gs_app_set_update_version_internal (app, update_version); # 3285| gs_app_queue_notify (app, obj_props[PROP_VERSION]); Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app.c:3324:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 3322| g_autoptr(GMutexLocker) locker = NULL; # 3323| g_return_if_fail (GS_IS_APP (app)); # 3324|-> locker = g_mutex_locker_new (&priv->mutex); # 3325| priv->update_details_set = TRUE; # 3326| _g_set_str (&priv->update_details_markup, markup); Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app.c:3348:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 3346| g_autoptr(GMutexLocker) locker = NULL; # 3347| g_return_if_fail (GS_IS_APP (app)); # 3348|-> locker = g_mutex_locker_new (&priv->mutex); # 3349| priv->update_details_set = TRUE; # 3350| if (text == NULL) { Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app.c:3376:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 3374| g_autoptr(GMutexLocker) locker = NULL; # 3375| g_return_val_if_fail (GS_IS_APP (app), FALSE); # 3376|-> locker = g_mutex_locker_new (&priv->mutex); # 3377| return priv->update_details_set; # 3378| } Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app.c:3483:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 3481| g_return_if_fail (management_plugin == NULL || GS_IS_PLUGIN (management_plugin)); # 3482| # 3483|-> locker = g_mutex_locker_new (&priv->mutex); # 3484| # 3485| /* plugins cannot adopt wildcard packages */ Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app.c:3546:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 3544| g_autoptr(GMutexLocker) locker = NULL; # 3545| g_return_if_fail (GS_IS_APP (app)); # 3546|-> locker = g_mutex_locker_new (&priv->mutex); # 3547| if (rating == priv->rating) # 3548| return; Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app.c:3586:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 3584| g_autoptr(GMutexLocker) locker = NULL; # 3585| g_return_if_fail (GS_IS_APP (app)); # 3586|-> locker = g_mutex_locker_new (&priv->mutex); # 3587| _g_set_array (&priv->review_ratings, review_ratings); # 3588| } Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app.c:3624:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 3622| g_return_if_fail (GS_IS_APP (app)); # 3623| g_return_if_fail (AS_IS_REVIEW (review)); # 3624|-> locker = g_mutex_locker_new (&priv->mutex); # 3625| g_ptr_array_add (priv->reviews, g_object_ref (review)); # 3626| } Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app.c:3643:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 3641| g_autoptr(GMutexLocker) locker = NULL; # 3642| g_return_if_fail (GS_IS_APP (app)); # 3643|-> locker = g_mutex_locker_new (&priv->mutex); # 3644| g_ptr_array_remove (priv->reviews, review); # 3645| } Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app.c:3712:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 3710| g_return_if_fail (kind != AS_PROVIDED_KIND_UNKNOWN && kind < AS_PROVIDED_KIND_LAST); # 3711| # 3712|-> locker = g_mutex_locker_new (&priv->mutex); # 3713| prov = gs_app_get_provided_for_kind (app, kind); # 3714| if (prov == NULL) { Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app.c:4274:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 4272| g_return_if_fail (GS_IS_APP (app)); # 4273| # 4274|-> locker = g_mutex_locker_new (&priv->mutex); # 4275| # 4276| /* if no value, then remove the key */ Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app.c:4320:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 4318| g_autoptr(GMutexLocker) locker = NULL; # 4319| g_return_val_if_fail (GS_IS_APP (app), NULL); # 4320|-> locker = g_mutex_locker_new (&priv->mutex); # 4321| return (priv->addons != NULL) ? g_object_ref (priv->addons) : NULL; # 4322| } Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app.c:4347:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 4345| return; # 4346| # 4347|-> locker = g_mutex_locker_new (&priv->mutex); # 4348| # 4349| if (priv->addons != NULL) Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app.c:4374:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 4372| g_return_if_fail (GS_IS_APP (app)); # 4373| g_return_if_fail (GS_IS_APP (addon)); # 4374|-> locker = g_mutex_locker_new (&priv->mutex); # 4375| # 4376| if (priv->addons != NULL) Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app.c:4417:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 4415| g_return_if_fail (GS_IS_APP (app2)); # 4416| # 4417|-> locker = g_mutex_locker_new (&priv->mutex); # 4418| # 4419| /* if the app is updatable-live and any related app is not then Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app.c:4468:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 4466| g_return_if_fail (GS_IS_APP (app)); # 4467| g_return_if_fail (GS_IS_APP (app2)); # 4468|-> locker = g_mutex_locker_new (&priv->mutex); # 4469| gs_app_list_add (priv->history, app2); # 4470| } Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app.c:4653:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 4651| g_return_if_fail (GS_IS_APP (app)); # 4652| g_return_if_fail (categories != NULL); # 4653|-> locker = g_mutex_locker_new (&priv->mutex); # 4654| _g_set_ptr_array (&priv->categories, categories); # 4655| } Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app.c:4673:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 4671| g_return_if_fail (GS_IS_APP (app)); # 4672| g_return_if_fail (category != NULL); # 4673|-> locker = g_mutex_locker_new (&priv->mutex); # 4674| if (gs_app_has_category (app, category)) # 4675| return; Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app.c:4700:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 4698| g_return_val_if_fail (GS_IS_APP (app), FALSE); # 4699| # 4700|-> locker = g_mutex_locker_new (&priv->mutex); # 4701| # 4702| for (i = 0; i < priv->categories->len; i++) { Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app.c:4902:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 4900| g_return_if_fail (GS_IS_APP (app)); # 4901| g_return_if_fail (key_colors != NULL); # 4902|-> locker = g_mutex_locker_new (&priv->mutex); # 4903| priv->user_key_colors = FALSE; # 4904| if (_g_set_array (&priv->key_colors, key_colors)) Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app.c:5147:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 5145| return; # 5146| # 5147|-> locker = g_mutex_locker_new (&priv->mutex); # 5148| priv->quirk |= quirk; # 5149| gs_app_queue_notify (app, obj_props[PROP_QUIRK]); Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app.c:5172:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 5170| return; # 5171| # 5172|-> locker = g_mutex_locker_new (&priv->mutex); # 5173| priv->quirk &= ~quirk; # 5174| gs_app_queue_notify (app, obj_props[PROP_QUIRK]); Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app.c:5287:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 5285| g_return_val_if_fail (GS_IS_APP (app), NULL); # 5286| # 5287|-> locker = g_mutex_locker_new (&priv->mutex); # 5288| # 5289| if (priv->cancellable == NULL || g_cancellable_is_cancelled (priv->cancellable)) { Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app.c:5315:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 5313| g_return_val_if_fail (GS_IS_APP (app), NULL); # 5314| # 5315|-> locker = g_mutex_locker_new (&priv->mutex); # 5316| if (priv->cancellable) # 5317| return g_object_ref (priv->cancellable); Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app.c:5336:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 5334| g_autoptr(GMutexLocker) locker = NULL; # 5335| g_return_val_if_fail (GS_IS_APP (app), GS_PLUGIN_ACTION_UNKNOWN); # 5336|-> locker = g_mutex_locker_new (&priv->mutex); # 5337| return priv->pending_action; # 5338| } Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app.c:5354:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 5352| g_autoptr(GMutexLocker) locker = NULL; # 5353| g_return_if_fail (GS_IS_APP (app)); # 5354|-> locker = g_mutex_locker_new (&priv->mutex); # 5355| gs_app_set_pending_action_internal (app, action); # 5356| } Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app.c:6330:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 6328| # 6329| priv = gs_app_get_instance_private (app); # 6330|-> locker = g_mutex_locker_new (&priv->mutex); # 6331| # 6332| if (!origin_str) { Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app.c:6382:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 6380| # 6381| priv = gs_app_get_instance_private (app); # 6382|-> locker = g_mutex_locker_new (&priv->mutex); # 6383| # 6384| if (origin_ui && !*origin_ui) Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app.c:6524:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 6522| g_autoptr(GMutexLocker) locker = NULL; # 6523| g_return_val_if_fail (GS_IS_APP (app), NULL); # 6524|-> locker = g_mutex_locker_new (&priv->mutex); # 6525| return priv->permissions ? g_object_ref (priv->permissions) : NULL; # 6526| } Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app.c:6549:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 6547| g_return_if_fail (permissions == NULL || gs_app_permissions_is_sealed (permissions)); # 6548| # 6549|-> locker = g_mutex_locker_new (&priv->mutex); # 6550| if (priv->permissions == permissions) # 6551| return; Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app.c:6578:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 6576| g_autoptr(GMutexLocker) locker = NULL; # 6577| g_return_val_if_fail (GS_IS_APP (app), NULL); # 6578|-> locker = g_mutex_locker_new (&priv->mutex); # 6579| return priv->update_permissions ? g_object_ref (priv->update_permissions) : NULL; # 6580| } Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app.c:6603:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 6601| g_return_if_fail (GS_IS_APP (app)); # 6602| g_return_if_fail (update_permissions == NULL || gs_app_permissions_is_sealed (update_permissions)); # 6603|-> locker = g_mutex_locker_new (&priv->mutex); # 6604| if (priv->update_permissions != update_permissions) { # 6605| g_clear_object (&priv->update_permissions); Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app.c:6630:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 6628| g_return_val_if_fail (GS_IS_APP (app), NULL); # 6629| # 6630|-> locker = g_mutex_locker_new (&priv->mutex); # 6631| if (priv->version_history == NULL) # 6632| return NULL; Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app.c:6656:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 6654| version_history = NULL; # 6655| # 6656|-> locker = g_mutex_locker_new (&priv->mutex); # 6657| _g_set_ptr_array (&priv->version_history, version_history); # 6658| } Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app.c:6685:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 6683| # 6684| priv = gs_app_get_instance_private (app); # 6685|-> locker = g_mutex_locker_new (&priv->mutex); # 6686| # 6687| /* process all icons */ Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app.c:6731:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 6729| g_return_val_if_fail (GS_IS_APP (app), NULL); # 6730| # 6731|-> locker = g_mutex_locker_new (&priv->mutex); # 6732| return (priv->relations != NULL) ? g_ptr_array_ref (priv->relations) : NULL; # 6733| } Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app.c:6755:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 6753| g_return_if_fail (AS_IS_RELATION (relation)); # 6754| # 6755|-> locker = g_mutex_locker_new (&priv->mutex); # 6756| # 6757| if (priv->relations == NULL) Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app.c:6785:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 6783| g_return_if_fail (GS_IS_APP (app)); # 6784| # 6785|-> locker = g_mutex_locker_new (&priv->mutex); # 6786| # 6787| if (relations == NULL && priv->relations == NULL) Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app.c:6791:3: warning[deadcode.DeadStores]: Value stored to 'old_relations' is never read # 6789| # 6790| if (priv->relations != NULL) # 6791|-> old_relations = g_steal_pointer (&priv->relations); # 6792| # 6793| if (relations != NULL) Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app.c:6836:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 6834| g_return_if_fail (GS_IS_APP (app)); # 6835| # 6836|-> locker = g_mutex_locker_new (&priv->mutex); # 6837| # 6838| if (priv->has_translations == has_translations) Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-app.c:6915:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 6913| g_return_if_fail (GS_IS_APP (app)); # 6914| # 6915|-> locker = g_mutex_locker_new (&priv->mutex); # 6916| # 6917| if (priv->icons_state == icons_state) Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-appstream.c:1835:16: warning[core.NonNullParamChecker]: Null pointer passed to 2nd parameter expecting 'nonnull' # 1833| split[0], split[1]); # 1834| } # 1835|-> components = xb_silo_query (silo, xpath, 0, &error_local); # 1836| if (components == NULL) { # 1837| if (g_error_matches (error_local, G_IO_ERROR, G_IO_ERROR_NOT_FOUND)) Error: CPPCHECK_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-category.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: GCC_ANALYZER_WARNING (CWE-476): gnome-software-46.0-build/gnome-software-46.0/lib/gs-category.c: scope_hint: In function ‘gs_category_new_for_desktop_data’ gnome-software-46.0-build/gnome-software-46.0/lib/gs-category.c:716:61: warning[-Wanalyzer-null-dereference]: dereference of NULL ‘0’ /usr/include/glib-2.0/glib/gmacros.h:1237:8: note: in definition of macro ‘_G_BOOLEAN_EXPR_IMPL’ /usr/include/glib-2.0/glib/gmacros.h:1244:43: note: in expansion of macro ‘_G_BOOLEAN_EXPR’ /usr/include/glib-2.0/glib/gmessages.h:651:9: note: in expansion of macro ‘G_LIKELY’ gnome-software-46.0-build/gnome-software-46.0/lib/gs-category.c:443:9: note: in expansion of macro ‘g_return_if_fail’ /usr/include/glib-2.0/gobject/gtype.h:1613:40: note: in definition of macro ‘G_DECLARE_FINAL_TYPE’ /usr/include/glib-2.0/gobject/gtype.h:541:66: note: in expansion of macro ‘_G_TYPE_CIT’ /usr/include/glib-2.0/gobject/gtype.h:1614:12: note: in expansion of macro ‘G_TYPE_CHECK_INSTANCE_TYPE’ gnome-software-46.0-build/gnome-software-46.0/lib/gs-category.h:22:1: note: in expansion of macro ‘G_DECLARE_FINAL_TYPE’ /usr/include/glib-2.0/gobject/gtype.h:541:66: note: in expansion of macro ‘_G_TYPE_CIT’ /usr/include/glib-2.0/gobject/gtype.h:1614:12: note: in expansion of macro ‘G_TYPE_CHECK_INSTANCE_TYPE’ gnome-software-46.0-build/gnome-software-46.0/lib/gs-category.h:22:1: note: in expansion of macro ‘G_DECLARE_FINAL_TYPE’ /usr/include/glib-2.0/glib/gmacros.h:1237:8: note: in definition of macro ‘_G_BOOLEAN_EXPR_IMPL’ /usr/include/glib-2.0/glib/gmacros.h:1244:43: note: in expansion of macro ‘_G_BOOLEAN_EXPR’ /usr/include/glib-2.0/glib/gmessages.h:651:9: note: in expansion of macro ‘G_LIKELY’ gnome-software-46.0-build/gnome-software-46.0/lib/gs-category.c:443:9: note: in expansion of macro ‘g_return_if_fail’ /usr/include/glib-2.0/glib/gmacros.h:1237:8: note: in definition of macro ‘_G_BOOLEAN_EXPR_IMPL’ /usr/include/glib-2.0/glib/gmacros.h:1244:43: note: in expansion of macro ‘_G_BOOLEAN_EXPR’ /usr/include/glib-2.0/glib/gtestutils.h:276:49: note: in expansion of macro ‘G_LIKELY’ gnome-software-46.0-build/gnome-software-46.0/lib/gs-category.c:703:17: note: in expansion of macro ‘g_assert’ /usr/include/glib-2.0/glib/gmacros.h:1243:31: note: in expansion of macro ‘_G_BOOLEAN_EXPR_IMPL’ /usr/include/glib-2.0/glib/gmacros.h:1244:43: note: in expansion of macro ‘_G_BOOLEAN_EXPR’ /usr/include/glib-2.0/glib/gtestutils.h:276:49: note: in expansion of macro ‘G_LIKELY’ gnome-software-46.0-build/gnome-software-46.0/lib/gs-category.c:703:17: note: in expansion of macro ‘g_assert’ /usr/include/glib-2.0/glib.h:33: included_from: Included from here. gnome-software-46.0-build/gnome-software-46.0/lib/gs-category.c:710:33: note: in expansion of macro ‘g_ptr_array_index’ /usr/include/glib-2.0/glib/gmacros.h:1243:31: note: in expansion of macro ‘_G_BOOLEAN_EXPR_IMPL’ /usr/include/glib-2.0/glib/gmacros.h:1244:43: note: in expansion of macro ‘_G_BOOLEAN_EXPR’ /usr/include/glib-2.0/glib/gmessages.h:664:9: note: in expansion of macro ‘G_LIKELY’ gnome-software-46.0-build/gnome-software-46.0/lib/gs-category.c:301:9: note: in expansion of macro ‘g_return_val_if_fail’ # 714| /* add all desktop groups */ # 715| desktop_groups = gs_category_get_desktop_groups (child); # 716|-> for (guint j = 0; j < desktop_groups->len; j++) { # 717| const gchar *tmp = g_ptr_array_index (desktop_groups, j); # 718| gs_category_add_desktop_group (subcategory_all, tmp); Error: CPPCHECK_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-cmd.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-debug.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-download-utils.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-external-appstream-utils.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-fedora-third-party.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-fedora-third-party.c:382:2: warning[deadcode.DeadStores]: Value stored to 'executable' is never read # 380| # 381| g_mutex_lock (&self->lock); # 382|-> executable = gs_fedora_third_party_ensure_executable_locked (self, error); # 383| g_mutex_unlock (&self->lock); # 384| Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-icon.c:215:10: warning[deadcode.DeadStores]: Although the value stored to 'name_allocated' is used in the enclosing expression, the value is never actually read from 'name_allocated' # 213| * unnecessary size subdirectory in the icon name. */ # 214| if (g_str_has_prefix (name, "64x64/")) # 215|-> name = name_allocated = g_strdup (name + strlen ("64x64/")); # 216| else if (g_str_has_prefix (name, "128x128/")) # 217| name = name_allocated = g_strdup (name + strlen ("128x128/")); Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-icon.c:217:10: warning[deadcode.DeadStores]: Although the value stored to 'name_allocated' is used in the enclosing expression, the value is never actually read from 'name_allocated' # 215| name = name_allocated = g_strdup (name + strlen ("64x64/")); # 216| else if (g_str_has_prefix (name, "128x128/")) # 217|-> name = name_allocated = g_strdup (name + strlen ("128x128/")); # 218| # 219| if (!g_str_has_suffix (filename, name)) { Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-job-manager.c:333:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 331| g_return_val_if_fail (GS_IS_PLUGIN_JOB (job), FALSE); # 332| # 333|-> locker = g_mutex_locker_new (&self->mutex); # 334| # 335| if (g_ptr_array_find (self->jobs, job, NULL)) Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-job-manager.c:397:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 395| g_return_val_if_fail (GS_IS_PLUGIN_JOB (job), FALSE); # 396| # 397|-> locker = g_mutex_locker_new (&self->mutex); # 398| # 399| if (!g_ptr_array_remove_fast (self->jobs, job)) Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-job-manager.c:464:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 462| g_return_val_if_fail (GS_IS_APP (app), NULL); # 463| # 464|-> locker = g_mutex_locker_new (&self->mutex); # 465| # 466| jobs_for_app = g_ptr_array_new_with_free_func (g_object_unref); Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-job-manager.c:502:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 500| g_return_val_if_fail (g_type_is_a (pending_job_type, GS_TYPE_PLUGIN_JOB), FALSE); # 501| # 502|-> locker = g_mutex_locker_new (&self->mutex); # 503| # 504| for (gsize i = 0; i < self->jobs->len; i++) { Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-job-manager.c:568:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 566| g_return_val_if_fail (match_job_type == G_TYPE_INVALID || g_type_is_a (match_job_type, GS_TYPE_PLUGIN_JOB), 0); # 567| # 568|-> locker = g_mutex_locker_new (&self->mutex); # 569| # 570| g_assert (self->next_watch_id < G_MAXUINT); Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-job-manager.c:610:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 608| g_return_if_fail (watch_id != 0); # 609| # 610|-> locker = g_mutex_locker_new (&self->mutex); # 611| # 612| for (guint i = 0; i < self->watches->len; i++) { Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-job-manager.c:690:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 688| g_task_set_source_tag (task, gs_job_manager_shutdown_async); # 689| # 690|-> locker = g_mutex_locker_new (&self->mutex); # 691| # 692| self->shut_down = TRUE; Error: CPPCHECK_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-key-colors.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-metered.c:98:2: warning[deadcode.DeadStores]: Value stored to 'pusher' is never read # 96| # 97| context = g_main_context_new (); # 98|-> pusher = g_main_context_pusher_new (context); # 99| # 100| gs_metered_block_on_download_scheduler_async (parameters, cancellable, async_result_cb, &result); Error: CPPCHECK_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-odrs-provider.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-odrs-provider.c:178:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 176| # 177| /* Update the shared state */ # 178|-> locker = g_mutex_locker_new (&self->ratings_mutex); # 179| g_clear_pointer (&self->ratings, g_array_unref); # 180| self->ratings = g_steal_pointer (&new_ratings); Error: CPPCHECK_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-os-release.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-plugin-job-list-distro-upgrades.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-plugin-job-manage-repository.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-plugin-loader.c:602:3: warning[deadcode.DeadStores]: Value stored to 'refine_flags' is never read # 600| list = gs_plugin_job_get_list (helper->plugin_job); # 601| if (refine_flags == GS_PLUGIN_REFINE_FLAGS_NONE) # 602|-> refine_flags = gs_plugin_job_get_refine_flags (helper->plugin_job); # 603| # 604| /* set what plugin is running on the job */ Error: CPPCHECK_WARNING (CWE-758): gnome-software-46.0-build/gnome-software-46.0/lib/gs-plugin-types.h:169: error[shiftTooManyBitsSigned]: Shifting signed 32-bit value by 31 bits is undefined behaviour # 167| GS_PLUGIN_REFINE_FLAGS_REQUIRE_DEVELOPER_NAME = 1 << 29, # 168| GS_PLUGIN_REFINE_FLAGS_REQUIRE_KUDOS = 1 << 30, # 169|-> GS_PLUGIN_REFINE_FLAGS_REQUIRE_CONTENT_RATING = 1 << 31, # 170| GS_PLUGIN_REFINE_FLAGS_MASK = ~0, # 171| } GsPluginRefineFlags; Error: CPPCHECK_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-plugin.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-plugin.c:1134:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 1132| g_return_val_if_fail (key != NULL, NULL); # 1133| # 1134|-> locker = g_mutex_locker_new (&priv->cache_mutex); # 1135| app = g_hash_table_lookup (priv->cache, key); # 1136| if (app == NULL) Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-plugin.c:1167:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 1165| # 1166| priv = gs_plugin_get_instance_private (plugin); # 1167|-> locker = g_mutex_locker_new (&priv->cache_mutex); # 1168| # 1169| g_hash_table_iter_init (&iter, priv->cache); Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-plugin.c:1197:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 1195| g_return_if_fail (key != NULL); # 1196| # 1197|-> locker = g_mutex_locker_new (&priv->cache_mutex); # 1198| g_hash_table_remove (priv->cache, key); # 1199| } Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-plugin.c:1221:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 1219| g_return_if_fail (GS_IS_APP (app)); # 1220| # 1221|-> locker = g_mutex_locker_new (&priv->cache_mutex); # 1222| # 1223| /* the user probably doesn't want to do this */ Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-plugin.c:1262:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 1260| g_return_if_fail (GS_IS_PLUGIN (plugin)); # 1261| # 1262|-> locker = g_mutex_locker_new (&priv->cache_mutex); # 1263| g_hash_table_remove_all (priv->cache); # 1264| } Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-plugin.c:1287:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 1285| g_return_val_if_fail (GS_IS_PLUGIN (plugin), NULL); # 1286| # 1287|-> locker = g_mutex_locker_new (&priv->cache_mutex); # 1288| list = gs_app_list_new (); # 1289| Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-plugin.c:1910:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 1908| repo_plugin = gs_app_dup_management_plugin (repository); # 1909| # 1910|-> locker = g_mutex_locker_new (&priv->cache_mutex); # 1911| # 1912| g_hash_table_iter_init (&iter, priv->cache); Error: COMPILER_WARNING (CWE-9001): gnome-software-46.0-build/gnome-software-46.0/lib/gs-profiler.h:93:1: warning[-Winline]: inlining failed in call to ‘gs_profiler_tracing_end’: call is unlikely and code size would grow # 93 | gs_profiler_tracing_end (GsProfilerHead *head) # | ^~~~~~~~~~~~~~~~~~~~~~~ gnome-software-46.0-build/gnome-software-46.0/lib/gs-profiler.h:108:17: note: called from here # 108 | gs_profiler_tracing_end (*head); # | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ # 91| # 92| static inline void # 93|-> gs_profiler_tracing_end (GsProfilerHead *head) # 94| { # 95| sysprof_collector_mark (head->begin_time, Error: GCC_ANALYZER_WARNING (CWE-457): gnome-software-46.0-build/gnome-software-46.0/plugins/flatpak/gs-plugin-flatpak.c:39: included_from: Included from here. gnome-software-46.0-build/gnome-software-46.0/lib/gs-profiler.h: scope_hint: In function ‘gs_profiler_tracing_end’ gnome-software-46.0-build/gnome-software-46.0/lib/gs-profiler.h:99:37: warning[-Wanalyzer-use-of-uninitialized-value]: use of uninitialized value ‘*head.description’ /usr/lib64/glib-2.0/include/glibconfig.h:9: included_from: Included from here. /usr/include/glib-2.0/glib/gtypes.h:34: included_from: Included from here. /usr/include/glib-2.0/glib/galloca.h:34: included_from: Included from here. /usr/include/glib-2.0/glib.h:32: included_from: Included from here. /usr/include/glib-2.0/gobject/gbinding.h:30: included_from: Included from here. /usr/include/glib-2.0/glib-object.h:24: included_from: Included from here. /usr/include/glib-2.0/gio/gioenums.h:30: included_from: Included from here. /usr/include/glib-2.0/gio/giotypes.h:30: included_from: Included from here. /usr/include/glib-2.0/gio/gio.h:28: included_from: Included from here. /usr/include/flatpak/flatpak.h:26: included_from: Included from here. gnome-software-46.0-build/gnome-software-46.0/plugins/flatpak/gs-plugin-flatpak.c:29: included_from: Included from here. /usr/include/glib-2.0/glib/gmacros.h:1243:31: note: in expansion of macro ‘_G_BOOLEAN_EXPR_IMPL’ /usr/include/glib-2.0/glib/gmacros.h:1244:43: note: in expansion of macro ‘_G_BOOLEAN_EXPR’ /usr/include/glib-2.0/glib/gtestutils.h:276:49: note: in expansion of macro ‘G_LIKELY’ gnome-software-46.0-build/gnome-software-46.0/plugins/flatpak/gs-plugin-flatpak.c:70:9: note: in expansion of macro ‘g_assert’ gnome-software-46.0-build/gnome-software-46.0/plugins/flatpak/gs-plugin-flatpak.c:707:9: note: in expansion of macro ‘assert_in_worker’ gnome-software-46.0-build/gnome-software-46.0/lib/gs-profiler.h:123:9: note: in expansion of macro ‘GS_PROFILER_BEGIN_SCOPED_TAKE’ gnome-software-46.0-build/gnome-software-46.0/plugins/flatpak/gs-plugin-flatpak.c:633:9: note: in expansion of macro ‘GS_PROFILER_BEGIN_SCOPED’ gnome-software-46.0-build/gnome-software-46.0/lib/gs-profiler.h:123:9: note: in expansion of macro ‘GS_PROFILER_BEGIN_SCOPED_TAKE’ gnome-software-46.0-build/gnome-software-46.0/plugins/flatpak/gs-plugin-flatpak.c:633:9: note: in expansion of macro ‘GS_PROFILER_BEGIN_SCOPED’ gnome-software-46.0-build/gnome-software-46.0/lib/gs-profiler.h: scope_hint: In function ‘gs_profiler_tracing_end’ # 97| "gnome-software", # 98| head->name, # 99|-> head->description); # 100| # 101| g_clear_pointer (&head->name, g_free); Error: CPPCHECK_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-remote-icon.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-utils.c:1290:18: warning[core.uninitialized.Assign]: Assigned value is garbage or undefined # 1288| for (x = 0; x < width; x++) { # 1289| /* set as the mean of the kernel */ # 1290|-> p_dest_row[0] = div_kernel_size[r]; # 1291| p_dest_row[1] = div_kernel_size[g]; # 1292| p_dest_row[2] = div_kernel_size[b]; Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/gs-worker-thread.c:336:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 334| data->priority = priority; # 335| # 336|-> locker = g_mutex_locker_new (&self->queue_mutex); # 337| g_queue_insert_sorted (&self->queue, g_steal_pointer (&data), gs_worker_thread_cmp, NULL); # 338| g_main_context_wakeup (self->worker_context); Error: CPPCHECK_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/tools/profile-key-colors.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/lib/tools/profile-key-colors.c:62:13: warning[core.DivideZero]: Division by zero # 60| } # 61| # 62|-> mean = sum / n_measurements; # 63| # 64| for (guint i = 0; i < durations->len; i++) { Error: CPPCHECK_WARNING: gnome-software-46.0-build/gnome-software-46.0/plugins/core/gs-plugin-appstream.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/plugins/core/gs-plugin-appstream.c:567:2: warning[deadcode.DeadStores]: Value stored to 'writer_locker' is never read # 565| # 566| /* drat! silo needs regenerating */ # 567|-> writer_locker = g_rw_lock_writer_locker_new (&self->silo_lock); # 568| reload: # 569| g_clear_object (&self->silo); Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/plugins/core/gs-plugin-appstream.c:802:2: warning[deadcode.DeadStores]: Value stored to 'writer_locker' is never read # 800| # 801| self = GS_PLUGIN_APPSTREAM (plugin); # 802|-> writer_locker = g_rw_lock_writer_locker_new (&self->silo_lock); # 803| if (self->silo != NULL) # 804| xb_silo_invalidate (self->silo); Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/plugins/core/gs-plugin-appstream.c:926:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 924| return FALSE; # 925| # 926|-> locker = g_rw_lock_reader_locker_new (&self->silo_lock); # 927| # 928| return gs_appstream_url_to_app (plugin, self->silo, list, url, cancellable, error); Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/plugins/core/gs-plugin-appstream.c:987:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 985| return TRUE; # 986| # 987|-> locker = g_rw_lock_reader_locker_new (&self->silo_lock); # 988| # 989| if (g_hash_table_contains (self->silo_installed_by_id, gs_app_get_id (app))) Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/plugins/core/gs-plugin-appstream.c:1012:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 1010| return TRUE; # 1011| # 1012|-> locker = g_rw_lock_reader_locker_new (&self->silo_lock); # 1013| # 1014| origin = gs_app_get_origin_appstream (app); Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/plugins/core/gs-plugin-appstream.c:1064:3: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 1062| g_autoptr(XbNode) component = NULL; # 1063| # 1064|-> locker = g_rw_lock_reader_locker_new (&self->silo_lock); # 1065| # 1066| /* prefer actual apps and then fallback to anything else */ Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/plugins/core/gs-plugin-appstream.c:1291:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 1289| return TRUE; # 1290| # 1291|-> locker = g_rw_lock_reader_locker_new (&self->silo_lock); # 1292| # 1293| components = g_hash_table_lookup (apps_by_id, id); Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/plugins/core/gs-plugin-appstream.c:1378:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 1376| } # 1377| # 1378|-> locker = g_rw_lock_reader_locker_new (&self->silo_lock); # 1379| # 1380| if (!gs_appstream_refine_category_sizes (self->silo, data->list, cancellable, &local_error)) { Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/plugins/core/gs-plugin-appstream.c:1489:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 1487| } # 1488| # 1489|-> locker = g_rw_lock_reader_locker_new (&self->silo_lock); # 1490| # 1491| if (released_since != NULL && Error: CPPCHECK_WARNING: gnome-software-46.0-build/gnome-software-46.0/plugins/core/gs-plugin-provenance.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING: gnome-software-46.0-build/gnome-software-46.0/plugins/dummy/gs-plugin-dummy.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING: gnome-software-46.0-build/gnome-software-46.0/plugins/epiphany/gs-plugin-epiphany.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING: gnome-software-46.0-build/gnome-software-46.0/plugins/fedora-pkgdb-collections/gs-plugin-fedora-pkgdb-collections.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING: gnome-software-46.0-build/gnome-software-46.0/plugins/flatpak/gs-flatpak-transaction.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING: gnome-software-46.0-build/gnome-software-46.0/plugins/flatpak/gs-flatpak-utils.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING: gnome-software-46.0-build/gnome-software-46.0/plugins/fwupd/gs-fwupd-app.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING: gnome-software-46.0-build/gnome-software-46.0/plugins/fwupd/gs-plugin-fwupd.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/plugins/fwupd/gs-plugin-fwupd.c:61:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 59| g_autoptr(GMutexLocker) locker = NULL; # 60| # 61|-> locker = g_mutex_locker_new (&self->cached_sources_mutex); # 62| # 63| g_assert (self->cached_sources != NULL); Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/plugins/fwupd/gs-plugin-fwupd.c:1837:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 1835| if (remotes == NULL) # 1836| return FALSE; # 1837|-> locker = g_mutex_locker_new (&self->cached_sources_mutex); # 1838| if (self->cached_sources == NULL) # 1839| self->cached_sources = g_hash_table_new_full (g_str_hash, g_str_equal, g_free, NULL); Error: CPPCHECK_WARNING: gnome-software-46.0-build/gnome-software-46.0/plugins/malcontent/gs-plugin-malcontent.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/plugins/malcontent/gs-plugin-malcontent.c:229:3: warning[deadcode.DeadStores]: Value stored to 'old_app_filter' is never read # 227| { # 228| g_autoptr(GMutexLocker) locker = g_mutex_locker_new (&self->mutex); # 229|-> old_app_filter = g_steal_pointer (&self->app_filter); # 230| self->app_filter = g_steal_pointer (&new_app_filter); # 231| } Error: CPPCHECK_WARNING: gnome-software-46.0-build/gnome-software-46.0/plugins/modalias/gs-plugin-modalias.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING: gnome-software-46.0-build/gnome-software-46.0/plugins/packagekit/gs-markdown.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING: gnome-software-46.0-build/gnome-software-46.0/plugins/packagekit/gs-packagekit-helper.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING: gnome-software-46.0-build/gnome-software-46.0/plugins/packagekit/gs-plugin-packagekit.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/plugins/packagekit/gs-plugin-packagekit.c:112:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 110| g_autoptr(GMutexLocker) locker = NULL; # 111| # 112|-> locker = g_mutex_locker_new (&self->cached_sources_mutex); # 113| # 114| g_assert (self->cached_sources != NULL); Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/plugins/packagekit/gs-plugin-packagekit.c:329:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 327| if (!gs_plugin_packagekit_results_valid (results, cancellable, error)) # 328| return FALSE; # 329|-> locker = g_mutex_locker_new (&self->cached_sources_mutex); # 330| if (self->cached_sources == NULL) # 331| self->cached_sources = g_hash_table_new_full (g_str_hash, g_str_equal, g_free, NULL); Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/plugins/packagekit/gs-plugin-packagekit.c:1259:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 1257| # 1258| /* Update the shared state. */ # 1259|-> locker = g_mutex_locker_new (&self->prepared_updates_mutex); # 1260| g_clear_pointer (&self->prepared_updates, g_hash_table_unref); # 1261| self->prepared_updates = g_steal_pointer (&new_prepared_updates); Error: CPPCHECK_WARNING: gnome-software-46.0-build/gnome-software-46.0/plugins/packagekit/packagekit-common.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING: gnome-software-46.0-build/gnome-software-46.0/plugins/repos/gs-plugin-repos.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/plugins/repos/gs-plugin-repos.c:171:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 169| /* success; replace the hash table pointers in the object while the lock # 170| * is held */ # 171|-> locker = g_mutex_locker_new (&self->mutex); # 172| # 173| g_clear_pointer (&self->fns, g_hash_table_unref); Error: CPPCHECK_WARNING: gnome-software-46.0-build/gnome-software-46.0/plugins/rpm-ostree/gs-plugin-rpm-ostree.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/plugins/rpm-ostree/gs-plugin-rpm-ostree.c:83:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 81| g_autoptr(GMutexLocker) locker = NULL; # 82| # 83|-> locker = g_mutex_locker_new (&self->cached_sources_mutex); # 84| # 85| g_assert (self->cached_sources != NULL); Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/plugins/rpm-ostree/gs-plugin-rpm-ostree.c:390:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 388| g_autoptr(GMutexLocker) locker = NULL; # 389| # 390|-> locker = g_mutex_locker_new (&self->mutex); # 391| # 392| return gs_rpmostree_ref_proxies_locked (self, interactive, out_os_proxy, out_sysroot_proxy, cancellable, error); Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/plugins/rpm-ostree/gs-plugin-rpm-ostree.c:2977:2: warning[deadcode.DeadStores]: Value stored to 'locker' is never read # 2975| } # 2976| # 2977|-> locker = g_mutex_locker_new (&self->cached_sources_mutex); # 2978| if (self->cached_sources == NULL) # 2979| self->cached_sources = g_hash_table_new_full (g_str_hash, g_str_equal, g_free, NULL); Error: CPPCHECK_WARNING: gnome-software-46.0-build/gnome-software-46.0/redhat-linux-build/plugins/epiphany/gs-epiphany-generated.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING: gnome-software-46.0-build/gnome-software-46.0/redhat-linux-build/plugins/rpm-ostree/gs-rpmostree-generated.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING: gnome-software-46.0-build/gnome-software-46.0/redhat-linux-build/src/gs-packagekit-generated.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING: gnome-software-46.0-build/gnome-software-46.0/redhat-linux-build/src/gs-packagekit-modify2-generated.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING: gnome-software-46.0-build/gnome-software-46.0/redhat-linux-build/src/gs-shell-search-provider-generated.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING: gnome-software-46.0-build/gnome-software-46.0/src/gs-age-rating-context-dialog.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING: gnome-software-46.0-build/gnome-software-46.0/src/gs-app-context-bar.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING (CWE-457): gnome-software-46.0-build/gnome-software-46.0/src/gs-app-context-bar.c:894: error[legacyUninitvar]: Uninitialized variable: dialog # 892| g_assert_not_reached (); # 893| # 894|-> gtk_window_set_transient_for (dialog, GTK_WINDOW (root)); # 895| gtk_widget_set_visible (GTK_WIDGET (dialog), TRUE); # 896| } Error: CPPCHECK_WARNING: gnome-software-46.0-build/gnome-software-46.0/src/gs-app-reviews-dialog.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING: gnome-software-46.0-build/gnome-software-46.0/src/gs-app-row.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING: gnome-software-46.0-build/gnome-software-46.0/src/gs-app-tile.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING: gnome-software-46.0-build/gnome-software-46.0/src/gs-application.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING: gnome-software-46.0-build/gnome-software-46.0/src/gs-category-page.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING: gnome-software-46.0-build/gnome-software-46.0/src/gs-common.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING: gnome-software-46.0-build/gnome-software-46.0/src/gs-css.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING: gnome-software-46.0-build/gnome-software-46.0/src/gs-dbus-helper.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING: gnome-software-46.0-build/gnome-software-46.0/src/gs-description-box.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/src/gs-description-box.c:123:32: warning[core.NullDereference]: Access to field 'data' results in a dereference of a null pointer (loaded from variable 'opened_markup') # 121| if (box->text[start_index] == '<') { # 122| if (box->text[start_index + 1] == '/') { # 123|-> g_autofree gchar *value = opened_markup->data; # 124| opened_markup = g_slist_remove (opened_markup, value); # 125| } else { Error: GCC_ANALYZER_WARNING (CWE-476): gnome-software-46.0-build/gnome-software-46.0/src/gs-description-box.c: scope_hint: In function ‘gs_description_box_update_content’ gnome-software-46.0-build/gnome-software-46.0/src/gs-description-box.c:123:80: warning[-Wanalyzer-null-dereference]: dereference of NULL ‘opened_markup’ # 121| if (box->text[start_index] == '<') { # 122| if (box->text[start_index + 1] == '/') { # 123|-> g_autofree gchar *value = opened_markup->data; # 124| opened_markup = g_slist_remove (opened_markup, value); # 125| } else { Error: CPPCHECK_WARNING: gnome-software-46.0-build/gnome-software-46.0/src/gs-details-page.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING: gnome-software-46.0-build/gnome-software-46.0/src/gs-extras-page.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING: gnome-software-46.0-build/gnome-software-46.0/src/gs-feature-tile.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING: gnome-software-46.0-build/gnome-software-46.0/src/gs-hardware-support-context-dialog.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/src/gs-hardware-support-context-dialog.c:250:26: warning[core.UndefinedBinaryOperatorResult]: The right operand of '==' is a garbage value # 248| switch (comparator) { # 249| case AS_RELATION_COMPARE_EQ: # 250|-> return (comparand1.min == comparand2.min && # 251| comparand1.max == comparand2.max); # 252| case AS_RELATION_COMPARE_NE: Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/src/gs-hardware-support-context-dialog.c:253:26: warning[core.UndefinedBinaryOperatorResult]: The right operand of '!=' is a garbage value # 251| comparand1.max == comparand2.max); # 252| case AS_RELATION_COMPARE_NE: # 253|-> return (comparand1.min != comparand2.min || # 254| comparand1.max != comparand2.max); # 255| case AS_RELATION_COMPARE_LT: Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/src/gs-hardware-support-context-dialog.c:256:26: warning[core.UndefinedBinaryOperatorResult]: The right operand of '<' is a garbage value # 254| comparand1.max != comparand2.max); # 255| case AS_RELATION_COMPARE_LT: # 256|-> return (comparand1.max < comparand2.min); # 257| case AS_RELATION_COMPARE_GT: # 258| return (comparand1.min > comparand2.max); Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/src/gs-hardware-support-context-dialog.c:258:26: warning[core.UndefinedBinaryOperatorResult]: The right operand of '>' is a garbage value # 256| return (comparand1.max < comparand2.min); # 257| case AS_RELATION_COMPARE_GT: # 258|-> return (comparand1.min > comparand2.max); # 259| case AS_RELATION_COMPARE_LE: # 260| return (comparand1.max <= comparand2.max); Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/src/gs-hardware-support-context-dialog.c:260:26: warning[core.UndefinedBinaryOperatorResult]: The right operand of '<=' is a garbage value # 258| return (comparand1.min > comparand2.max); # 259| case AS_RELATION_COMPARE_LE: # 260|-> return (comparand1.max <= comparand2.max); # 261| case AS_RELATION_COMPARE_GE: # 262| return (comparand1.min >= comparand2.min); Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/src/gs-hardware-support-context-dialog.c:262:26: warning[core.UndefinedBinaryOperatorResult]: The right operand of '>=' is a garbage value # 260| return (comparand1.max <= comparand2.max); # 261| case AS_RELATION_COMPARE_GE: # 262|-> return (comparand1.min >= comparand2.min); # 263| case AS_RELATION_COMPARE_UNKNOWN: # 264| case AS_RELATION_COMPARE_LAST: Error: CPPCHECK_WARNING: gnome-software-46.0-build/gnome-software-46.0/src/gs-installed-page.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING: gnome-software-46.0-build/gnome-software-46.0/src/gs-language.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING: gnome-software-46.0-build/gnome-software-46.0/src/gs-license-tile.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING: gnome-software-46.0-build/gnome-software-46.0/src/gs-lozenge.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING: gnome-software-46.0-build/gnome-software-46.0/src/gs-overview-page.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING: gnome-software-46.0-build/gnome-software-46.0/src/gs-page.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING: gnome-software-46.0-build/gnome-software-46.0/src/gs-repos-dialog.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/src/gs-restarter.c:195:3: warning[unix.Malloc]: Potential leak of memory pointed to by 'priv' # 193| priv = gs_restarter_private_new (); # 194| if (!gs_restarter_setup_watcher (priv, &error)) { # 195|-> g_warning ("Failed to set up: %s", error->message); # 196| return EXIT_FAILURE; # 197| } Error: CPPCHECK_WARNING: gnome-software-46.0-build/gnome-software-46.0/src/gs-review-dialog.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING: gnome-software-46.0-build/gnome-software-46.0/src/gs-safety-context-dialog.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING: gnome-software-46.0-build/gnome-software-46.0/src/gs-screenshot-image.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING: gnome-software-46.0-build/gnome-software-46.0/src/gs-shell-search-provider.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING: gnome-software-46.0-build/gnome-software-46.0/src/gs-shell.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/src/gs-shell.c:1284:4: warning[deadcode.DeadStores]: Value stored to 'str_origin' is never read # 1282| toast_text = _("Unable to download updates"); # 1283| if (origin != NULL) { # 1284|-> str_origin = gs_shell_get_title_from_origin (origin); # 1285| if (gs_app_get_bundle_kind (origin) == AS_BUNDLE_KIND_CABINET) { # 1286| /* TRANSLATORS: failure text for the in-app notification */ Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/src/gs-shell.c:1503:2: warning[deadcode.DeadStores]: Value stored to 'str_app' is never read # 1501| g_autofree gchar *str_origin = NULL; # 1502| # 1503|-> str_app = g_strdup_printf ("%s %s", gs_app_get_name (app), gs_app_get_version (app)); # 1504| # 1505| if (g_error_matches (error, GS_PLUGIN_ERROR, GS_PLUGIN_ERROR_DOWNLOAD_FAILED)) { Error: CLANG_WARNING: gnome-software-46.0-build/gnome-software-46.0/src/gs-shell.c:1507:4: warning[deadcode.DeadStores]: Value stored to 'str_origin' is never read # 1505| if (g_error_matches (error, GS_PLUGIN_ERROR, GS_PLUGIN_ERROR_DOWNLOAD_FAILED)) { # 1506| if (origin != NULL) { # 1507|-> str_origin = gs_shell_get_title_from_origin (origin); # 1508| /* TRANSLATORS: failure text for the in-app notification */ # 1509| toast_text = _("Unable to upgrade"); Error: CPPCHECK_WARNING: gnome-software-46.0-build/gnome-software-46.0/src/gs-storage-context-dialog.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING: gnome-software-46.0-build/gnome-software-46.0/src/gs-update-monitor.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING: gnome-software-46.0-build/gnome-software-46.0/src/gs-updates-page.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING: gnome-software-46.0-build/gnome-software-46.0/src/gs-updates-paused-banner.c: information[normalCheckLevelMaxBranches]: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. Error: CPPCHECK_WARNING (CWE-457): gnome-software-46.0-build/gnome-software-46.0/src/gs-updates-paused-banner.c:96: error[legacyUninitvar]: Uninitialized variable: title # 94| } # 95| # 96|-> adw_banner_set_title (ADW_BANNER (self->banner), title); # 97| } # 98|