Fixed findings

List of Findings

Error: CPPCHECK_WARNING (CWE-398): [#def1]
avahi-0.9.rc3/avahi-discover-standalone/main.c:314: style[constParameterCallback]: Parameter 'event' can be declared as pointer to const. However it seems that 'main_window_on_delete_event' is a callback function, if 'event' is declared with const you might also need to cast function pointer(s).
#  312|   }
#  313|   
#  314|-> static gboolean main_window_on_delete_event(AVAHI_GCC_UNUSED GtkWidget *widget, AVAHI_GCC_UNUSED GdkEvent *event, AVAHI_GCC_UNUSED gpointer user_data) {
#  315|       gtk_main_quit();
#  316|       return FALSE;

Error: CPPCHECK_WARNING (CWE-398): [#def2]
avahi-0.9.rc3/avahi-discover-standalone/main.c:314: style[constParameterCallback]: Parameter 'widget' can be declared as pointer to const. However it seems that 'main_window_on_delete_event' is a callback function, if 'widget' is declared with const you might also need to cast function pointer(s).
#  312|   }
#  313|   
#  314|-> static gboolean main_window_on_delete_event(AVAHI_GCC_UNUSED GtkWidget *widget, AVAHI_GCC_UNUSED GdkEvent *event, AVAHI_GCC_UNUSED gpointer user_data) {
#  315|       gtk_main_quit();
#  316|       return FALSE;

Error: CPPCHECK_WARNING (CWE-570): [#def3]
avahi-0.9.rc3/avahi-ui/avahi-ui.c:758: style[unsignedLessThanZero]: Checking if unsigned expression 'd->priv->service_pulse_timeout' is less than zero.
#  756|       gtk_widget_show(d->priv->service_progress_bar);
#  757|   
#  758|->     if (d->priv->service_pulse_timeout <= 0)
#  759|           d->priv->service_pulse_timeout = g_timeout_add(100, service_pulse_callback, d);
#  760|   

Error: CPPCHECK_WARNING (CWE-570): [#def4]
avahi-0.9.rc3/avahi-ui/avahi-ui.c:1210: style[unsignedLessThanZero]: Checking if unsigned expression 'd->priv->start_idle' is less than zero.
# 1208|       g_return_if_fail(AUI_IS_SERVICE_DIALOG(d));
# 1209|   
# 1210|->     if (d->priv->start_idle <= 0)
# 1211|           d->priv->start_idle = g_idle_add(start_callback, d);
# 1212|   }

Scan Properties