Newly introduced findings

List of Findings

Error: CLIPPY_WARNING: [#def1]
crates/xtask/src/anaconda.rs:833:9: warning: this `if` statement can be collapsed
#      |
#  833 | /         if stage == InstallStage::Booting {
#  834 | |             if anaconda_new.contains(PATTERN_ANACONDA_STARTED) || serial_new.contains("anaconda") {
#  835 | |                 stage = InstallStage::AnacondaStarting;
#  836 | |                 stage_start = Instant::now();
#  837 | |             }
#  838 | |         }
#      | |_________^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#collapsible_if
#      = note: `#[warn(clippy::collapsible_if)]` on by default
#  help: collapse nested if block
#      |
#  833 ~         if stage == InstallStage::Booting
#  834 ~             && (anaconda_new.contains(PATTERN_ANACONDA_STARTED) || serial_new.contains("anaconda")) {
#  835 |                 stage = InstallStage::AnacondaStarting;
#  836 |                 stage_start = Instant::now();
#  837 ~             }
#      |

Error: CLIPPY_WARNING: [#def2]
crates/xtask/src/anaconda.rs:849:9: warning: this `if` statement can be collapsed
#      |
#  849 | /         if stage == InstallStage::Installing {
#  850 | |             if serial_new.contains(PATTERN_INSTALL_COMPLETE)
#  851 | |                 || serial_new.contains("reboot: Restarting")
#  ...   |
#  856 | |         }
#      | |_________^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#collapsible_if
#  help: collapse nested if block
#      |
#  849 ~         if stage == InstallStage::Installing
#  850 ~             && (serial_new.contains(PATTERN_INSTALL_COMPLETE)
#  851 ~                 || serial_new.contains("reboot: Restarting"))
#  852 |             {
#  853 |                 stage = InstallStage::Rebooting;
#  854 |                 stage_start = Instant::now();
#  855 ~             }
#      |

Error: CLIPPY_WARNING: [#def3]
crates/xtask/src/anaconda.rs:931:5: warning: unnecessary `if let` since only the `Ok` variant of the iterator element is used
#      |
#  931 | /     for line in reader.lines() {
#  932 | |         if let Ok(line) = line {
#  933 | |             content.push_str(&line);
#  934 | |             content.push('\n');
#  935 | |         }
#  936 | |     }
#      | |_____^
#      |
#  help: try `.flatten()` and remove the `if let` statement in the for loop
#     --> crates/xtask/src/anaconda.rs:932:9
#      |
#  932 | /         if let Ok(line) = line {
#  933 | |             content.push_str(&line);
#  934 | |             content.push('\n');
#  935 | |         }
#      | |_________^
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#manual_flatten
#      = note: `#[warn(clippy::manual_flatten)]` on by default
#  help: try
#      |
#  931 ~     for line in reader.lines().flatten() {
#  932 +         content.push_str(&line);
#  933 +         content.push('\n');
#  934 +     }
#      |

Error: CLIPPY_WARNING: [#def4]
crates/xtask/src/anaconda.rs:946:34: warning: use of a disallowed method `str::len`
#      |
#  946 |         let end = (idx + pattern.len() + 200).min(content.len());
#      |                                  ^^^
#      |
#      = note: use <str>.as_bytes().len() instead
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#disallowed_methods
#      = note: requested on the command line with `-D clippy::disallowed-methods`

Error: CLIPPY_WARNING: [#def5]
crates/xtask/src/anaconda.rs:946:59: warning: use of a disallowed method `str::len`
#      |
#  946 |         let end = (idx + pattern.len() + 200).min(content.len());
#      |                                                           ^^^
#      |
#      = note: use <str>.as_bytes().len() instead
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#disallowed_methods

Scan Properties