Newly introduced findings

List of Findings

Error: CLIPPY_WARNING: [#def1]
crates/xtask/src/anaconda.rs:832:9: warning: this `if` statement can be collapsed
#      |
#  832 | /         if stage == InstallStage::Booting {
#  833 | |             if anaconda_new.contains(PATTERN_ANACONDA_STARTED) || serial_new.contains("anaconda") {
#  834 | |                 stage = InstallStage::AnacondaStarting;
#  835 | |                 stage_start = Instant::now();
#  836 | |             }
#  837 | |         }
#      | |_________^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#collapsible_if
#      = note: `#[warn(clippy::collapsible_if)]` on by default
#  help: collapse nested if block
#      |
#  832 ~         if stage == InstallStage::Booting
#  833 ~             && (anaconda_new.contains(PATTERN_ANACONDA_STARTED) || serial_new.contains("anaconda")) {
#  834 |                 stage = InstallStage::AnacondaStarting;
#  835 |                 stage_start = Instant::now();
#  836 ~             }
#      |

Error: CLIPPY_WARNING: [#def2]
crates/xtask/src/anaconda.rs:848:9: warning: this `if` statement can be collapsed
#      |
#  848 | /         if stage == InstallStage::Installing {
#  849 | |             if serial_new.contains(PATTERN_INSTALL_COMPLETE)
#  850 | |                 || serial_new.contains("reboot: Restarting")
#  ...   |
#  855 | |         }
#      | |_________^
#      |
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#collapsible_if
#  help: collapse nested if block
#      |
#  848 ~         if stage == InstallStage::Installing
#  849 ~             && (serial_new.contains(PATTERN_INSTALL_COMPLETE)
#  850 ~                 || serial_new.contains("reboot: Restarting"))
#  851 |             {
#  852 |                 stage = InstallStage::Rebooting;
#  853 |                 stage_start = Instant::now();
#  854 ~             }
#      |

Error: CLIPPY_WARNING: [#def3]
crates/xtask/src/anaconda.rs:930:5: warning: unnecessary `if let` since only the `Ok` variant of the iterator element is used
#      |
#  930 | /     for line in reader.lines() {
#  931 | |         if let Ok(line) = line {
#  932 | |             content.push_str(&line);
#  933 | |             content.push('\n');
#  934 | |         }
#  935 | |     }
#      | |_____^
#      |
#  help: try `.flatten()` and remove the `if let` statement in the for loop
#     --> crates/xtask/src/anaconda.rs:931:9
#      |
#  931 | /         if let Ok(line) = line {
#  932 | |             content.push_str(&line);
#  933 | |             content.push('\n');
#  934 | |         }
#      | |_________^
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#manual_flatten
#      = note: `#[warn(clippy::manual_flatten)]` on by default
#  help: try
#      |
#  930 ~     for line in reader.lines().flatten() {
#  931 +         content.push_str(&line);
#  932 +         content.push('\n');
#  933 +     }
#      |

Error: CLIPPY_WARNING: [#def4]
crates/xtask/src/anaconda.rs:945:34: warning: use of a disallowed method `str::len`
#      |
#  945 |         let end = (idx + pattern.len() + 200).min(content.len());
#      |                                  ^^^
#      |
#      = note: use <str>.as_bytes().len() instead
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#disallowed_methods
#      = note: requested on the command line with `-D clippy::disallowed-methods`

Error: CLIPPY_WARNING: [#def5]
crates/xtask/src/anaconda.rs:945:59: warning: use of a disallowed method `str::len`
#      |
#  945 |         let end = (idx + pattern.len() + 200).min(content.len());
#      |                                                           ^^^
#      |
#      = note: use <str>.as_bytes().len() instead
#      = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#disallowed_methods

Scan Properties

analyzer-version-clippy1.93.1
analyzer-version-cppcheck2.19.1
analyzer-version-gcc16.0.1
analyzer-version-gcc-analyzer16.0.1
analyzer-version-shellcheck0.11.0
analyzer-version-unicontrol0.0.2
diffbase-analyzer-version-clippy1.93.1
diffbase-analyzer-version-cppcheck2.19.1
diffbase-analyzer-version-gcc16.0.1
diffbase-analyzer-version-gcc-analyzer16.0.1
diffbase-analyzer-version-shellcheck0.11.0
diffbase-analyzer-version-unicontrol0.0.2
diffbase-enabled-pluginsclippy, cppcheck, gcc, shellcheck, unicontrol
diffbase-exit-code0
diffbase-hostip-172-16-1-57.us-west-2.compute.internal
diffbase-known-false-positives/usr/share/csmock/known-false-positives.js
diffbase-known-false-positives-rpmknown-false-positives-0.0.0.20260119.105402.g7a5be1b.main-1.el9.noarch
diffbase-mock-configfedora-rawhide-x86_64
diffbase-project-namebootc-202602231759.g564de0b17c-1
diffbase-store-results-to/tmp/tmprm0720k_/bootc-202602231759.g564de0b17c-1.tar.xz
diffbase-time-created2026-02-23 22:35:31
diffbase-time-finished2026-02-23 22:58:28
diffbase-toolcsmock
diffbase-tool-args'/usr/bin/csmock' '-r' 'fedora-rawhide-x86_64' '-t' 'unicontrol,clippy,cppcheck,shellcheck,gcc' '-o' '/tmp/tmprm0720k_/bootc-202602231759.g564de0b17c-1.tar.xz' '--gcc-analyze' '--unicontrol-notests' '--unicontrol-bidi-only' '--install' 'pam' '/tmp/tmprm0720k_/bootc-202602231759.g564de0b17c-1.src.rpm'
diffbase-tool-versioncsmock-3.8.3.20260128.181932.g41af877-1.el9
enabled-pluginsclippy, cppcheck, gcc, shellcheck, unicontrol
exit-code0
hostip-172-16-1-57.us-west-2.compute.internal
known-false-positives/usr/share/csmock/known-false-positives.js
known-false-positives-rpmknown-false-positives-0.0.0.20260119.105402.g7a5be1b.main-1.el9.noarch
mock-configfedora-rawhide-x86_64
project-namebootc-202602232157.g6112d3737d-1
store-results-to/tmp/tmpvmknjzar/bootc-202602232157.g6112d3737d-1.tar.xz
time-created2026-02-23 22:59:00
time-finished2026-02-23 23:20:27
titleNewly introduced findings
toolcsmock
tool-args'/usr/bin/csmock' '-r' 'fedora-rawhide-x86_64' '-t' 'unicontrol,clippy,cppcheck,shellcheck,gcc' '-o' '/tmp/tmpvmknjzar/bootc-202602232157.g6112d3737d-1.tar.xz' '--gcc-analyze' '--unicontrol-notests' '--unicontrol-bidi-only' '--install' 'pam' '/tmp/tmpvmknjzar/bootc-202602232157.g6112d3737d-1.src.rpm'
tool-versioncsmock-3.8.3.20260128.181932.g41af877-1.el9